search for: llvm_enable_dump

Hi Matthias, >Jingu: Why do you even want a configuration that has LLVM_ENABLE_DUMP but does not have asserts enabled at the same time? My colleague and I am doing custom project using clang/llvm. We have always wanted to use the IR Value's dump() to check our implementation correctly with Debug, Release and another builds. We thought the LLVM_ENABLE_DUMP is for it. If C...

..., Matthias Braun wrote: > >> On Sep 25, 2017, at 6:03 PM, David Keaton via llvm-dev <llvm-dev at lists.llvm.org> wrote: >> >> On 09/25/2017 02:53 PM, Matthias Braun via llvm-dev wrote: >>> The dump methods can be included in the release builds anyway by enabling LLVM_ENABLE_DUMP. >> >> Is there a way to pass LLVM_ENABLE_DUMP into cmake from outside without changing any of the configuration files? With Chapel's use of LLVM, we try to avoid modifying any of the source files that come from the LLVM distribution. Our own Makefile that builds Chapel also...

...n Apr 10, 2017, at 12:37 PM, Matthias Braun <mbraun at apple.com> wrote: > > The situation is not consistent. Yes there are several places where we have the #if in the headers however there are far more cases where it is not. Some points here: > > - This whole LLVM_DUMP_FUNCTION/LLVM_ENABLE_DUMP is about enabling the linker to strip (or not strip) the dumping function in release (debug) builds. > - For this it doesn't matter whether you have a declaration in the header or not, so it seems we standardized on not having it there. > - Things are 100% consistent so we sometimes have...

...as Braun wrote: >>> >>>> On Sep 25, 2017, at 6:03 PM, David Keaton via llvm-dev <llvm-dev at lists.llvm.org> wrote: >>>> >>>> On 09/25/2017 02:53 PM, Matthias Braun via llvm-dev wrote: >>> In the meantime `cmake -DCMAKE_CXX_FLAGS="-DLLVM_ENABLE_DUMP"` should do the trick. >> Thank you. That was the flag we needed. >> Unfortunately, when I tried this just now, I found that the declaration of llvm::MachineRegisterInfo::dumpUses() in include/llvm/CodeGen/MachineRegisterInfo.h is missing the check against LLVM_ENABLE_DU...

Presently several of our headers have definitions like: #if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP) void dump() const; #endif Would it make sense to modify the build system to define LLVM_ENABLE_DUMP in config.h on debug builds? Then we could wrap dump methods just based on LLVM_ENABLE_DUMP instead of two variables. -Chris > On Apr 10, 2017, at 1:34 PM, Robinson, Paul via llvm-dev <l...

..., Matthias Braun wrote: >> >>> On Sep 25, 2017, at 6:03 PM, David Keaton via llvm-dev >>> <llvm-dev at lists.llvm.org> wrote: >>> >>> On 09/25/2017 02:53 PM, Matthias Braun via llvm-dev wrote: >> In the meantime `cmake -DCMAKE_CXX_FLAGS="-DLLVM_ENABLE_DUMP"` should >> do the trick. > > Thank you. That was the flag we needed. > > Unfortunately, when I tried this just now, I found that the > declaration of llvm::MachineRegisterInfo::dumpUses() in > include/llvm/CodeGen/MachineRegisterInfo.h is missing the...

...> > >>>> On Sep 25, 2017, at 6:03 PM, David Keaton via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > >>>> > >>>> On 09/25/2017 02:53 PM, Matthias Braun via llvm-dev wrote: > >>> In the meantime `cmake -DCMAKE_CXX_FLAGS="-DLLVM_ENABLE_DUMP"` should > do the trick. > >> Thank you. That was the flag we needed. > >> Unfortunately, when I tried this just now, I found that the > declaration of llvm::MachineRegisterInfo::dumpUses() in > include/llvm/CodeGen/MachineRegisterInfo.h is missing the che...

On 09/25/2017 02:53 PM, Matthias Braun via llvm-dev wrote: > The dump methods can be included in the release builds anyway by > enabling LLVM_ENABLE_DUMP. Is there a way to pass LLVM_ENABLE_DUMP into cmake from outside without changing any of the configuration files? With Chapel's use of LLVM, we try to avoid modifying any of the source files that come from the LLVM distribution. Our own Makefile that builds Chapel also invokes cmak...

...hould just consistently implement the things discussed in > http://lists.llvm.org/pipermail/cfe-dev/2014-January/034323.html > > For reference: > - Public headers should just declare the dump() method but not use > LLVM_DUMP_METHOD or #if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP) > - The definition of a dump method should look like this: > #if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP) > LLVM_DUMP_METHOD void MyClass::dump() { > // print stuff to dbgs()... > } > #endif > > git-svn-id: https://llvm.org/svn/l...

> On Sep 25, 2017, at 6:03 PM, David Keaton via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > On 09/25/2017 02:53 PM, Matthias Braun via llvm-dev wrote: >> The dump methods can be included in the release builds anyway by enabling LLVM_ENABLE_DUMP. > > Is there a way to pass LLVM_ENABLE_DUMP into cmake from outside without changing any of the configuration files? With Chapel's use of LLVM, we try to avoid modifying any of the source files that come from the LLVM distribution. Our own Makefile that builds Chapel also invokes...

Hi Don, On 25 September 2017 at 22:37, Don Hinton <hintonda at gmail.com> wrote: > It'll work in release builds -- just rebuild llvm with LLVM_ENABLE_DUMP > enabled. > That assumes one has control over the LLVM build options. > On Mon, Sep 25, 2017 at 2:35 PM, Dibyendu Majumdar <mobile at majumdar.org.uk> > wrote: >> >> On 25 September 2017 at 22:29, Don Hinton <hintonda at gmail.com> wrote: >> > Thanks...

It'll work in release builds -- just rebuild llvm with LLVM_ENABLE_DUMP enabled. On Mon, Sep 25, 2017 at 2:35 PM, Dibyendu Majumdar <mobile at majumdar.org.uk> wrote: > Hi Don, > > On 25 September 2017 at 22:29, Don Hinton <hintonda at gmail.com> wrote: > > Thanks for reporting this. > > > > Looks like this one was missed -- th...

On Sat, Oct 14, 2017 at 11:38 AM, Don Hinton <hintonda at gmail.com> wrote: > Sorry, LLVM_FORCE_ENABLE_DUMP is the variable, which is used along with > LLVM_ENABLE_ASSERTIONS to set LLVM_ENABLE_DUMP. > > Again, I'm working on a fix, but could you also provide your cmake > command? Looks like we aren't handling your use case correctly. > > thanks.. > don > % grep -R LLVM_FORCE_ENABLE_DUMP * CMakeCache.txt:LLVM_FORCE_ENABLE_DUMP:BOOL=OFF CMakeCache.txt.orig:LLVM_FO...

...MAKE_BUILD_TYPE=Release. I can fix that, but not sure > if it's what you are seeing. > > If this isn't your case, could you send me the actual commands you ran? > > In the meantime, you can add -DLLVM_FOURCE_ENABLE_DUMP=ON to your cmake > invocation which should guarantee LLVM_ENABLE_DUMP is defined. > > hth... > don > > Don, Did you try a build with -DLLVM_ENABLE_ASSERTIONS:BOOL=OFF -DCMAKE_BUILD_TYPE:STRING=Release? Jack On Sat, Oct 14, 2017 at 9:36 AM, Jack Howarth <howarth.mailing.lists at gmail. > com> wrote: > >> >> >>...

On Sun, Oct 15, 2017 at 12:40 PM, Don Hinton <hintonda at gmail.com> wrote: > On Sun, Oct 15, 2017 at 8:34 AM, Aaron Ballman <aaron at aaronballman.com> > wrote: >> >> FWIW, most of the ones I was fixing up were guarded by NDEBUG instead >> of LLVM_ENABLE_DUMP. Switching to LLVM_ENABLE_DUMP fixed the link >> errors for me -- the only one I struggled with was >> AsmMatcherEmitter::run(). But it sounds like you're saying switching >> the configuration type in MSVC from Debug to Release would have >> possibly caused issues as wel...

...ack: > > Yes, I was just looking at that. Seems like TableGen wasn't done along > with the rest of llvm. I'll work up a complete patch shortly. > > Btw, I'm curious how this happened. Do you have a stale CMakeCache.txt by > any chance? You might check the value for LLVM_ENABLE_DUMP and see if it's > consistent. > > Again, I'll gen up a complete patch shortly -- sorry for delay, had to > walk my dog first... > > thanks... > don > There are no instances of LLVM_ENABLE_DUMP being emitted during the stage1 build (which is where the failure occurs)...

...if > > to be inline with various other dumpers (like MachineInstr::dump(), Pass::dump(), …) I’m fine with leaving methods there, but we need to be able to compile-out fields in structure. We already have ABI_BREAKING_CHECKS for instance to this end, the naming isn’t completely in line with LLVM_ENABLE_DUMP but could be unified. — Mehdi > > If that works for you please submit a patch to phabricator as described in http://llvm.org/docs/DeveloperPolicy.html#making-and-submitting-a-patch > > - Matthias > >> On Apr 6, 2017, at 7:38 AM, jingu at codeplay.com via llvm-dev <llv...

...e link errors that Jack pointed out before >> stumbling on the problem in AsmMatcherEmitter::run(). I wasn't >> comfortable attempting to work around it there because the >> DEBUG_WITH_TYPE macro was conflicting with trying to guard calls to >> MatchableInfo::dump() with LLVM_ENABLE_DUMP. >> >> I think this is another instance of "TableGen wasn't done along with >> the rest of llvm" -- nothing about it should be Visual Studio- or >> Windows-specific. > > > I think this is specific to cmake generators that create multiple > configura...

...bby for it to enabled by default. On Mon, Sep 25, 2017 at 2:41 PM, Dibyendu Majumdar <mobile at majumdar.org.uk> wrote: > Hi Don, > > On 25 September 2017 at 22:37, Don Hinton <hintonda at gmail.com> wrote: > > It'll work in release builds -- just rebuild llvm with LLVM_ENABLE_DUMP > > enabled. > > > > That assumes one has control over the LLVM build options. > > > > On Mon, Sep 25, 2017 at 2:35 PM, Dibyendu Majumdar < > mobile at majumdar.org.uk> > > wrote: > >> > >> On 25 September 2017 at 22:29, Don Hinton <...

Hi All, I have tried to build llvm tip as following: cmake -DCMAKE_CXX_FLAGS:STRING="-DLLVM_ENABLE_DUMP" -DCMAKE_BUILD_TYPE=RelWithDebInfo ../llvm After running 'make', I have got error messages like below. llvm/lib/CodeGen/MachineRegisterInfo.cpp:462:67: error: no ‘void llvm::MachineRegisterInfo::dumpUses(unsigned int) const’ member function declared in class ‘llvm::MachineRegister...