Dean Michael Berris via llvm-dev
2016-Jul-19 03:53 UTC
[llvm-dev] RFC: FileCheck Enhancements
> On 19 Jul 2016, at 04:18, Mehdi Amini via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > We had a long thread about that a few weeks (months?) ago: the conclusion (as I remember) was roughly a guideline to “always start a new revision to have a proper mailing-list thread starting with context (i.e. patch description)” > (and my dissident minority opinion that it is only worth it if there hasn’t been significant round of reviews going on on the existing revision) >Pardon me for missing that discussion, this may have already been asked before: but is it possible to make arcanist default subscribe the correct commits mailing list in the process? This should make it at least harder to forget. Cheers
> On Jul 18, 2016, at 8:53 PM, Dean Michael Berris <dean.berris at gmail.com> wrote: > > >> On 19 Jul 2016, at 04:18, Mehdi Amini via llvm-dev <llvm-dev at lists.llvm.org> wrote: >> >> We had a long thread about that a few weeks (months?) ago: the conclusion (as I remember) was roughly a guideline to “always start a new revision to have a proper mailing-list thread starting with context (i.e. patch description)” >> (and my dissident minority opinion that it is only worth it if there hasn’t been significant round of reviews going on on the existing revision) >> > > Pardon me for missing that discussion, this may have already been asked before: but is it possible to make arcanist default subscribe the correct commits mailing list in the process? This should make it at least harder to forget.It seems certainly possible, and has been asked before as well, and my memory of the answer is along the line of “patch welcome”. (I.e. some community member are spending time to customize and maintain our fabricator instance, but they have some real work to do as well, so we’re resource limited). — Mehdi
Dean Michael Berris via llvm-dev
2016-Jul-19 04:49 UTC
[llvm-dev] RFC: FileCheck Enhancements
> On 19 Jul 2016, at 14:09, Mehdi Amini <mehdi.amini at apple.com> wrote: > > >> On Jul 18, 2016, at 8:53 PM, Dean Michael Berris <dean.berris at gmail.com> wrote: >> >> >>> On 19 Jul 2016, at 04:18, Mehdi Amini via llvm-dev <llvm-dev at lists.llvm.org> wrote: >>> >>> We had a long thread about that a few weeks (months?) ago: the conclusion (as I remember) was roughly a guideline to “always start a new revision to have a proper mailing-list thread starting with context (i.e. patch description)” >>> (and my dissident minority opinion that it is only worth it if there hasn’t been significant round of reviews going on on the existing revision) >>> >> >> Pardon me for missing that discussion, this may have already been asked before: but is it possible to make arcanist default subscribe the correct commits mailing list in the process? This should make it at least harder to forget. > > It seems certainly possible, and has been asked before as well, and my memory of the answer is along the line of “patch welcome”. > (I.e. some community member are spending time to customize and maintain our fabricator instance, but they have some real work to do as well, so we’re resource limited). >Cool, thanks! PS. I did some searching for this, and it seems there's no "easy" way to do this customisation via the project config. Probably something that has to be done on the server side. (See https://secure.phabricator.com/Q268).
Hi all, I made new patches for most of changes with llvm-commits subscriber. But two patches were updated, because there are a lot of comments (patch for CHECK-WORD and patch for templates pattern). Will it be ok? Thanks, Elena. -----Original Message----- From: llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org] On Behalf Of Dean Michael Berris via llvm-dev Sent: Tuesday, July 19, 2016 6:53 AM To: Mehdi Amini <mehdi.amini at apple.com> Cc: via llvm-dev <llvm-dev at lists.llvm.org> Subject: Re: [llvm-dev] RFC: FileCheck Enhancements> On 19 Jul 2016, at 04:18, Mehdi Amini via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > We had a long thread about that a few weeks (months?) ago: the conclusion (as I remember) was roughly a guideline to “always start a new revision to have a proper mailing-list thread starting with context (i.e. patch description)” > (and my dissident minority opinion that it is only worth it if there hasn’t been significant round of reviews going on on the existing revision) >Pardon me for missing that discussion, this may have already been asked before: but is it possible to make arcanist default subscribe the correct commits mailing list in the process? This should make it at least harder to forget. Cheers _______________________________________________ LLVM Developers mailing list llvm-dev at lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
And I also want to ask again about possible change of regexp library. There are a lot of comments that some changes in FileCheck are useless, because they may be replaced by using some features of regular expressions, but they are not supported by current library. I don't know a lot about modern C++ regexp library, but there are: 1. PCRE(pcre.h) 2. std::regex. It has no necessary features. So it can't be taken. 3. There is regex library in boost. 4. Also there is regex library in poco. Are there any other variants? Thanks, Elena. -----Original Message----- From: llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org] On Behalf Of Elena Lepilkina via llvm-dev Sent: Tuesday, July 19, 2016 4:37 PM To: Dean Michael Berris <dean.berris at gmail.com>; Mehdi Amini <mehdi.amini at apple.com> Cc: llvm-dev at lists.llvm.org Subject: Re: [llvm-dev] RFC: FileCheck Enhancements Hi all, I made new patches for most of changes with llvm-commits subscriber. But two patches were updated, because there are a lot of comments (patch for CHECK-WORD and patch for templates pattern). Will it be ok? Thanks, Elena. -----Original Message----- From: llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org] On Behalf Of Dean Michael Berris via llvm-dev Sent: Tuesday, July 19, 2016 6:53 AM To: Mehdi Amini <mehdi.amini at apple.com> Cc: via llvm-dev <llvm-dev at lists.llvm.org> Subject: Re: [llvm-dev] RFC: FileCheck Enhancements> On 19 Jul 2016, at 04:18, Mehdi Amini via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > We had a long thread about that a few weeks (months?) ago: the conclusion (as I remember) was roughly a guideline to “always start a new revision to have a proper mailing-list thread starting with context (i.e. patch description)” > (and my dissident minority opinion that it is only worth it if there hasn’t been significant round of reviews going on on the existing revision) >Pardon me for missing that discussion, this may have already been asked before: but is it possible to make arcanist default subscribe the correct commits mailing list in the process? This should make it at least harder to forget. Cheers _______________________________________________ LLVM Developers mailing list llvm-dev at lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev _______________________________________________ LLVM Developers mailing list llvm-dev at lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
Hi Elena,> On Jul 19, 2016, at 6:36 AM, Elena Lepilkina via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > Hi all, > > I made new patches for most of changes with llvm-commits subscriber. But two patches were updated, because there are a lot of comments (patch for CHECK-WORD and patch for templates pattern). Will it be ok?IMO it's fine to keep some of the original reviews if you don't want to discard/recreate their state. Please list the most up-to-date set of Phab URL's here, with a little note next to the ones which did not initially CC llvm-commits. Thanks again for working on this! vedant> > Thanks, Elena. > > -----Original Message----- > From: llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org] On Behalf Of Dean Michael Berris via llvm-dev > Sent: Tuesday, July 19, 2016 6:53 AM > To: Mehdi Amini <mehdi.amini at apple.com> > Cc: via llvm-dev <llvm-dev at lists.llvm.org> > Subject: Re: [llvm-dev] RFC: FileCheck Enhancements > > >> On 19 Jul 2016, at 04:18, Mehdi Amini via llvm-dev <llvm-dev at lists.llvm.org> wrote: >> >> We had a long thread about that a few weeks (months?) ago: the conclusion (as I remember) was roughly a guideline to “always start a new revision to have a proper mailing-list thread starting with context (i.e. patch description)” >> (and my dissident minority opinion that it is only worth it if there hasn’t been significant round of reviews going on on the existing revision) >> > > Pardon me for missing that discussion, this may have already been asked before: but is it possible to make arcanist default subscribe the correct commits mailing list in the process? This should make it at least harder to forget. > > Cheers > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev