It does send a patch to the list if you upload a new diff to the existing review after adding the list as a subscriber. That seems the best way to go usually? On Jul 15, 2016 8:36 PM, "Mehdi Amini via llvm-dev" <llvm-dev at lists.llvm.org> wrote:> > On Jul 15, 2016, at 8:58 AM, Robinson, Paul via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > > > > Please add llvm-commits as a subscriber to all of these reviews > > so everyone has a chance to see/comment on them. > > Adding llvm-commits after the fact ends up in the mailing list not > archiving the context of the reviews. > If these patches are fresh (no significant review occurred), they should > be closed and new revisions need to be opened, with llvm-commits as a > subscriber from the start. > > > — > Mehdi > > > > Thanks, > > --paulr > > > >> -----Original Message----- > >> From: llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org] On Behalf Of > Elena > >> Lepilkina via llvm-dev > >> Sent: Friday, July 15, 2016 6:05 AM > >> To: llvm-dev > >> Subject: Re: [llvm-dev] RFC: FileCheck Enhancements > >> > >> Hi all, > >> > >> Now all discussed enhancements are divided into separate patches. > >> Moreover I have found mistake which reduces performance. Now it's fixed. > >> > >> List of patches (for those interested): > >> Repeats in regular expressions - https://reviews.llvm.org/D22342 > >> Including files - https://reviews.llvm.org/D22344 > >> Expressions repeat for CHECK and CHECK-NEXT - > >> https://reviews.llvm.org/D22345 > >> CHECK-LABEL-DAG - https://reviews.llvm.org/D22348 > >> CHECK-WORD - https://reviews.llvm.org/D22353 > >> prefixes-regular expressions - https://reviews.llvm.org/D22401 > >> pattern templates - https://reviews.llvm.org/D22403. > >> > >> Thanks, > >> Elena. > >> _______________________________________________ > >> LLVM Developers mailing list > >> llvm-dev at lists.llvm.org > >> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev > > _______________________________________________ > > LLVM Developers mailing list > > llvm-dev at lists.llvm.org > > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev > > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160718/451d93f7/attachment.html>
Thank you, James. Then I’ll update all patches. From: James Y Knight [mailto:jyknight at google.com] Sent: Monday, July 18, 2016 2:27 PM To: Mehdi Amini <mehdi.amini at apple.com> Cc: llvm-dev at lists.llvm.org; Elena Lepilkina <Elena.Lepilkina at synopsys.com>; Robinson, Paul <paul.robinson at sony.com> Subject: Re: [llvm-dev] RFC: FileCheck Enhancements It does send a patch to the list if you upload a new diff to the existing review after adding the list as a subscriber. That seems the best way to go usually? On Jul 15, 2016 8:36 PM, "Mehdi Amini via llvm-dev" <llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>> wrote:> On Jul 15, 2016, at 8:58 AM, Robinson, Paul via llvm-dev <llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>> wrote: > > Please add llvm-commits as a subscriber to all of these reviews > so everyone has a chance to see/comment on them.Adding llvm-commits after the fact ends up in the mailing list not archiving the context of the reviews. If these patches are fresh (no significant review occurred), they should be closed and new revisions need to be opened, with llvm-commits as a subscriber from the start. — Mehdi> Thanks, > --paulr > >> -----Original Message----- >> From: llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org<mailto:llvm-dev-bounces at lists.llvm.org>] On Behalf Of Elena >> Lepilkina via llvm-dev >> Sent: Friday, July 15, 2016 6:05 AM >> To: llvm-dev >> Subject: Re: [llvm-dev] RFC: FileCheck Enhancements >> >> Hi all, >> >> Now all discussed enhancements are divided into separate patches. >> Moreover I have found mistake which reduces performance. Now it's fixed. >> >> List of patches (for those interested): >> Repeats in regular expressions - https://reviews.llvm.org/D22342 >> Including files - https://reviews.llvm.org/D22344 >> Expressions repeat for CHECK and CHECK-NEXT - >> https://reviews.llvm.org/D22345 >> CHECK-LABEL-DAG - https://reviews.llvm.org/D22348 >> CHECK-WORD - https://reviews.llvm.org/D22353 >> prefixes-regular expressions - https://reviews.llvm.org/D22401 >> pattern templates - https://reviews.llvm.org/D22403. >> >> Thanks, >> Elena. >> _______________________________________________ >> LLVM Developers mailing list >> llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org> >> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev_______________________________________________ LLVM Developers mailing list llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160718/6340d740/attachment.html>
It still doesn't include the original context/description of the patch, though. Yes, you can copy/paste that in, though. On Mon, Jul 18, 2016 at 4:27 AM James Y Knight via llvm-dev < llvm-dev at lists.llvm.org> wrote:> It does send a patch to the list if you upload a new diff to the existing > review after adding the list as a subscriber. That seems the best way to go > usually? > > On Jul 15, 2016 8:36 PM, "Mehdi Amini via llvm-dev" < > llvm-dev at lists.llvm.org> wrote: > >> > On Jul 15, 2016, at 8:58 AM, Robinson, Paul via llvm-dev < >> llvm-dev at lists.llvm.org> wrote: >> > >> > Please add llvm-commits as a subscriber to all of these reviews >> > so everyone has a chance to see/comment on them. >> >> Adding llvm-commits after the fact ends up in the mailing list not >> archiving the context of the reviews. >> If these patches are fresh (no significant review occurred), they should >> be closed and new revisions need to be opened, with llvm-commits as a >> subscriber from the start. >> >> >> — >> Mehdi >> >> >> > Thanks, >> > --paulr >> > >> >> -----Original Message----- >> >> From: llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org] On Behalf Of >> Elena >> >> Lepilkina via llvm-dev >> >> Sent: Friday, July 15, 2016 6:05 AM >> >> To: llvm-dev >> >> Subject: Re: [llvm-dev] RFC: FileCheck Enhancements >> >> >> >> Hi all, >> >> >> >> Now all discussed enhancements are divided into separate patches. >> >> Moreover I have found mistake which reduces performance. Now it's >> fixed. >> >> >> >> List of patches (for those interested): >> >> Repeats in regular expressions - https://reviews.llvm.org/D22342 >> >> Including files - https://reviews.llvm.org/D22344 >> >> Expressions repeat for CHECK and CHECK-NEXT - >> >> https://reviews.llvm.org/D22345 >> >> CHECK-LABEL-DAG - https://reviews.llvm.org/D22348 >> >> CHECK-WORD - https://reviews.llvm.org/D22353 >> >> prefixes-regular expressions - https://reviews.llvm.org/D22401 >> >> pattern templates - https://reviews.llvm.org/D22403. >> >> >> >> Thanks, >> >> Elena. >> >> _______________________________________________ >> >> LLVM Developers mailing list >> >> llvm-dev at lists.llvm.org >> >> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >> > _______________________________________________ >> > LLVM Developers mailing list >> > llvm-dev at lists.llvm.org >> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >> >> _______________________________________________ >> LLVM Developers mailing list >> llvm-dev at lists.llvm.org >> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >> > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160718/a56e1376/attachment.html>
We had a long thread about that a few weeks (months?) ago: the conclusion (as I remember) was roughly a guideline to “always start a new revision to have a proper mailing-list thread starting with context (i.e. patch description)” (and my dissident minority opinion that it is only worth it if there hasn’t been significant round of reviews going on on the existing revision) — Mehdi> On Jul 18, 2016, at 4:27 AM, James Y Knight <jyknight at google.com> wrote: > > It does send a patch to the list if you upload a new diff to the existing review after adding the list as a subscriber. That seems the best way to go usually? > > > On Jul 15, 2016 8:36 PM, "Mehdi Amini via llvm-dev" <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>> wrote: > > On Jul 15, 2016, at 8:58 AM, Robinson, Paul via llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>> wrote: > > > > Please add llvm-commits as a subscriber to all of these reviews > > so everyone has a chance to see/comment on them. > > Adding llvm-commits after the fact ends up in the mailing list not archiving the context of the reviews. > If these patches are fresh (no significant review occurred), they should be closed and new revisions need to be opened, with llvm-commits as a subscriber from the start. > > > — > Mehdi > > > > Thanks, > > --paulr > > > >> -----Original Message----- > >> From: llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org <mailto:llvm-dev-bounces at lists.llvm.org>] On Behalf Of Elena > >> Lepilkina via llvm-dev > >> Sent: Friday, July 15, 2016 6:05 AM > >> To: llvm-dev > >> Subject: Re: [llvm-dev] RFC: FileCheck Enhancements > >> > >> Hi all, > >> > >> Now all discussed enhancements are divided into separate patches. > >> Moreover I have found mistake which reduces performance. Now it's fixed. > >> > >> List of patches (for those interested): > >> Repeats in regular expressions - https://reviews.llvm.org/D22342 <https://reviews.llvm.org/D22342> > >> Including files - https://reviews.llvm.org/D22344 <https://reviews.llvm.org/D22344> > >> Expressions repeat for CHECK and CHECK-NEXT - > >> https://reviews.llvm.org/D22345 <https://reviews.llvm.org/D22345> > >> CHECK-LABEL-DAG - https://reviews.llvm.org/D22348 <https://reviews.llvm.org/D22348> > >> CHECK-WORD - https://reviews.llvm.org/D22353 <https://reviews.llvm.org/D22353> > >> prefixes-regular expressions - https://reviews.llvm.org/D22401 <https://reviews.llvm.org/D22401> > >> pattern templates - https://reviews.llvm.org/D22403 <https://reviews.llvm.org/D22403>. > >> > >> Thanks, > >> Elena. > >> _______________________________________________ > >> LLVM Developers mailing list > >> llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org> > >> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev <http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev> > > _______________________________________________ > > LLVM Developers mailing list > > llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org> > > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev <http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev> > > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev <http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev>-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160718/bdcdbb17/attachment.html>
Dean Michael Berris via llvm-dev
2016-Jul-19 03:53 UTC
[llvm-dev] RFC: FileCheck Enhancements
> On 19 Jul 2016, at 04:18, Mehdi Amini via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > We had a long thread about that a few weeks (months?) ago: the conclusion (as I remember) was roughly a guideline to “always start a new revision to have a proper mailing-list thread starting with context (i.e. patch description)” > (and my dissident minority opinion that it is only worth it if there hasn’t been significant round of reviews going on on the existing revision) >Pardon me for missing that discussion, this may have already been asked before: but is it possible to make arcanist default subscribe the correct commits mailing list in the process? This should make it at least harder to forget. Cheers