search for: arcanist

Hi, I recently tried reviewing/committing some of my code on Phabricator/Arcanist for the first time and I noticed that the docs [1] ask for feedback, so here it is! Phabricator functions reasonably well and it is a lot easier to write comments and respond to comments on particular parts of code as opposed to the old way of copy and pasting patches into e-mails sent to llvm-com...

...>> wrote: >> Hi Dan, thanks for the feedback. >> >> On Mon, Dec 28, 2015 at 6:24 AM Dan Liew <dan at su-root.co.uk <mailto:dan at su-root.co.uk>> wrote: >> Hi, >> >> I recently tried reviewing/committing some of my code on >> Phabricator/Arcanist for the first time and I noticed that the docs >> [1] ask for feedback, so here it is! >> >> Phabricator functions reasonably well and it is a lot easier to write >> comments and respond to comments on particular parts of code as >> opposed to the old way of copy and...

+1 to this. I will not deny that, for whatever reason, people don't seem to use Arcanist. Using PHP as the scripting language seems to be a major sticking point for people, since it is not typically preinstalled or required for normal LLVM development, in the way that Python is. I've done it, and it works for me. I think it makes more sense to try and standardize on the existing t...

Hi, One takeaway for me from the recent Phabricator vs Github PR discussions was that arc (arcanist) can be a pain to set up and may pose a hurdle for some contributors. I think those points could be addressed relatively easily by adding a llvm-patch script (or an even better name) that allows users to create and apply patches from reviews.llvm.org using Phabricators API. In my experience, the t...

Why isn’t it in the LLVM repo? > On Nov 16, 2016, at 7:44 AM, Johannes Doerfert <doerfert at cs.uni-saarland.de> wrote: > > We have a clang format based arcanist linter (and some others) in the > Polly repository. When arcanist is used to create a review, the linter > result is shown online. We also have an arcanist add-on to run the lit > tests and show their result in the review as well. > > The problem is basically that not many ppl use...

Hi all, We upgraded phabricator to use HTTPS by default. All HTTP traffic will now be redirected to HTTPS. Arcanist users: Please run: $ *arc install-certificate* to re-install the certificate. Thanks, Eric -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160714/efc26c7f/attachment.html>

...mek via llvm-dev < llvm-dev at lists.llvm.org> wrote: > Hi Dan, thanks for the feedback. > > On Mon, Dec 28, 2015 at 6:24 AM Dan Liew <dan at su-root.co.uk> wrote: > >> Hi, >> >> I recently tried reviewing/committing some of my code on >> Phabricator/Arcanist for the first time and I noticed that the docs >> [1] ask for feedback, so here it is! >> >> Phabricator functions reasonably well and it is a lot easier to write >> comments and respond to comments on particular parts of code as >> opposed to the old way of copy and p...

So, I forwarded the request for highlighting trailing whitespaces to phabricator upstream (https://secure.phabricator.com/T11879), and upstream folks suggest we enable the Lint feature in Arcanist ( https://secure.phabricator.com/book/phabricator/article/arcanist_lint/). This will enforce the check when `arc diff` is run (reviewers wouldn't see the warnings though). There are two linters we might be interested in enabling: - cpplint (code style checker based on cpplint.py <https://gi...

...:) > > Cheers > > On Thu, Jul 14, 2016 at 11:14 PM Eric Liu via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > >> Hi all, >> >> We upgraded phabricator to use HTTPS by default. All HTTP traffic will >> now be redirected to HTTPS. >> >> Arcanist users: >> Please run: >> $ *arc install-certificate* >> to re-install the certificate. >> >> Thanks, >> Eric >> > _______________________________________________ >> LLVM Developers mailing list >> llvm-dev at lists.llvm.org >> http...

Hi, I tried to commit the Differential revision D3021 with the "arc commit" command. While it showed that the command succeeded and the Differential revision was closed, I can't find the revision anywhere in the SVN repository or the GIT mirror. Did I forget something? I tried a manual commit a few days ago and it worked. I've put the output of the "arc

...on: line must be the last (non-empty) line in the commit message. > >If you add things like “This fixes …” behind it then it won’t get > >recognized. > > My biggest grievance with Phabricator is that you can't just close a > revision manually. It seems that unless you use arcanist, you need to > resort to some sort of trickery to get your revisions closed. Huh? Under "Leap into action" on the bottom of the page, there is "Close revision". Joerg

Hi All, I just posted a review with arcanist (which I'm fairly new to) and it included a build status. How it got there is totally opaque to me, but my workflow was: Using git+svn (following the setup in https://llvm.org/docs/GettingStarted.html#for-developers-to-work-with-git-svn) make a change, commit with 'git commit', create r...

> On 8 Jan 2016, at 15:43, Krzysztof Parzyszek via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > On 1/8/2016 9:39 AM, Joerg Sonnenberger via llvm-dev wrote: >> >> Huh? Under "Leap into action" on the bottom of the page, there is "Close >> revision". > > Hmm. Indeed. I don't know why I didn't notice it before. Oh well,

...; > > On Tue, Jan 7, 2020 at 4:59 PM Doerfert, Johannes <jdoerfert at anl.gov> > wrote: > >> > >> Hi Bill, > >> > >> On 01/07, Bill Wendling via llvm-dev wrote: > >> > Then perhaps those opposed could suggest how to use > Phabricator/Arcanist so > >> > that I don't throw my keyboard through my monitor? > >> > >> Please explain your problems, w/o the hyperbole, so people can actually > do that. > >> > > It's not hyperbole, but fine. How do you use it to keep multiple, > related...

Hi, > Interesting, I don't read it that way :) I personally don't use arc to > commit. Sure the docs don't explicitly state that it's the only way. I just took that to be implied because the instructions for requesting a review provide multiple methods but the instructions for committing only mention using a single method. > Again, there is no one correct way. You can

On Thu, Apr 9, 2020 at 10:29 AM Michael Kruse <llvmdev at meinersbur.de> wrote: > I was always assuming that the suggested commit is assembled in the > PHP code run by arcanist command run locally. If indeed the arc > command requests the commit message from the server, I assumed so too until I went digging for it. Seems the client-side stuff only deals with the structured data, and calls out to the server to construct the raw text when needed: https://github.com/ph...

Hello, on a fresh install (i.e. newly-cloned arcanist and llvm-project), I get this. Any ideas? Thanks! arc install-certificate CONNECT Connecting to "https://reviews.llvm.org/api/"... Usage Exception: Failed to connect to server (https://reviews.llvm.org/api/): [HTTP/500] Internal Server Error As received by the server, this request had...

...g in to reviews.llvm.org. Also, I assume install-certificate is before any of these considerations? On Wed, Apr 8, 2020 at 6:53 PM David Blaikie <dblaikie at gmail.com> wrote: > Hmm - I'm running a pretty old version & seems to be working for me: > > $ arc version > > arcanist 3b6b523c2b236e3724a1e115f126cb6fd05fa128 (18 Feb 2017) > > libphutil 13a200ca7621ab2b48a0c395f52f8c4411bbc686 (4 Mar 2017) > > $ arc install-certificate > > CONNECT Connecting to "https://reviews.llvm.org/api/"... > > LOGIN TO PHABRICATOR > > Open this page...

On Tue, Jan 7, 2020 at 4:59 PM Doerfert, Johannes <jdoerfert at anl.gov> wrote: > Hi Bill, > > On 01/07, Bill Wendling via llvm-dev wrote: > > Then perhaps those opposed could suggest how to use Phabricator/Arcanist > so > > that I don't throw my keyboard through my monitor? > > Please explain your problems, w/o the hyperbole, so people can actually do > that. > > It's not hyperbole, but fine. How do you use it to keep multiple, related changes in order? The interface for review...

...h context (i.e. patch description)” > (and my dissident minority opinion that it is only worth it if there hasn’t been significant round of reviews going on on the existing revision) > Pardon me for missing that discussion, this may have already been asked before: but is it possible to make arcanist default subscribe the correct commits mailing list in the process? This should make it at least harder to forget. Cheers