llvm dev - Jun 2012 - [LLVMdev] How to define macros in a tablegen file?

On Wed, Jun 20, 2012 at 12:26 PM, Sebastian Pop <spop at codeaurora.org>
wrote:
> For reference, here is how the SPU port is using code and pattern
fragments:
>
> // Holder of code fragments (you'd think this'd already be in
> // a td file somewhere... :-)
And this comment makes me think, shouldn't this class CodeFrag be
included in the same place where PatFrag is declared:

./include/llvm/Target/TargetSelectionDAG.td:544:class PatFrag<dag ops,
dag frag, code pred = [{}],

such that we get it included through "llvm/Target/Target.td"?

I will prepare a patch for this.

Sebastian
-- 
Qualcomm Innovation Center, Inc is a member of Code Aurora Forum

On Wed, Jun 20, 2012 at 12:34 PM, Sebastian Pop <spop at codeaurora.org>
wrote:
> On Wed, Jun 20, 2012 at 12:26 PM, Sebastian Pop <spop at
codeaurora.org> wrote:
>> For reference, here is how the SPU port is using code and pattern
fragments:
>>
>> // Holder of code fragments (you'd think this'd already be in
>> // a td file somewhere... :-)
>
> And this comment makes me think, shouldn't this class CodeFrag be
> included in the same place where PatFrag is declared:
>
> ./include/llvm/Target/TargetSelectionDAG.td:544:class PatFrag<dag ops,
> dag frag, code pred = [{}],
>
> such that we get it included through "llvm/Target/Target.td"?
>
> I will prepare a patch for this.
>
Please see the attached patch.  Ok to commit?

Thanks,
Sebastian
-- 
Qualcomm Innovation Center, Inc is a member of Code Aurora Forum
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-move-CodeFrag-from-CellSPU-to-generic-code.patch
Type: application/octet-stream
Size: 1726 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20120620/6977807a/attachment.obj>

Possible to add a test case?

Micah
> -----Original Message-----
> From: Sebastian Pop [mailto:spop at codeaurora.org]
> Sent: Wednesday, June 20, 2012 1:40 PM
> To: Villmow, Micah
> Cc: llvmdev at cs.uiuc.edu; llvm-commits at cs.uiuc.edu
> Subject: Re: [LLVMdev] How to define macros in a tablegen file?
> 
> On Wed, Jun 20, 2012 at 12:34 PM, Sebastian Pop <spop at
codeaurora.org>
> wrote:
> > On Wed, Jun 20, 2012 at 12:26 PM, Sebastian Pop <spop at
codeaurora.org>
> wrote:
> >> For reference, here is how the SPU port is using code and pattern
> fragments:
> >>
> >> // Holder of code fragments (you'd think this'd already be
in // a
> td
> >> file somewhere... :-)
> >
> > And this comment makes me think, shouldn't this class CodeFrag be
> > included in the same place where PatFrag is declared:
> >
> > ./include/llvm/Target/TargetSelectionDAG.td:544:class PatFrag<dag
> ops,
> > dag frag, code pred = [{}],
> >
> > such that we get it included through
"llvm/Target/Target.td"?
> >
> > I will prepare a patch for this.
> >
> 
> Please see the attached patch.  Ok to commit?
> 
> Thanks,
> Sebastian
> --
> Qualcomm Innovation Center, Inc is a member of Code Aurora Forum