llvm dev - May 2011 - [LLVMdev] [MIPS] some type errors in the commentary of *.td file.

Hi all,

I find some some type errors in the commentary of *.td file.
such as:
lib/Target/Mips/MipsInstrFormats.td
MipsRegisterInfo.td - Mips Register defs
it should be
MipsInstrFormats.td - Mips Instruction Formats

lib/Target/Mips/MipsInstrInfo.td
MipsInstrInfo.td - Mips Register defs
it should be
MipsInstrInfo.td - Target Description for Mips Target

and some thing I think it is wrong in lib/Target/Mips/MipsInstrFPU.td.

Will the patch be OK?

Best regards.

--Liu
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Mips-td-comment-type-error.patch
Type: text/x-diff
Size: 1896 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20110506/01d42865/attachment.patch>

On May 5, 2011, at 11:26 PM, Liu wrote:
>  some some type errors in the commentary of *.td file.
> such as:
> lib/Target/Mips/MipsInstrFormats.td
> MipsRegisterInfo.td - Mips Register defs
> it should be
> MipsInstrFormats.td - Mips Instruction Formats
> 
> lib/Target/Mips/MipsInstrInfo.td
> MipsInstrInfo.td - Mips Register defs
> it should be
> MipsInstrInfo.td - Target Description for Mips Target
> 
> and some thing I think it is wrong in lib/Target/Mips/MipsInstrFPU.td.
> 
> Will the patch be OK?
> 
> Best regards.
> 
> --Liu
> <Mips-td-comment-type-error.patch>
Looks fine. Do you need someone to apply this for you?

-eric

On Sat, May 7, 2011 at 12:33 PM, Eric Christopher <echristo at apple.com>
wrote:
>
> On May 5, 2011, at 11:26 PM, Liu wrote:
>
>>  some some type errors in the commentary of *.td file.
>> such as:
>> lib/Target/Mips/MipsInstrFormats.td
>> MipsRegisterInfo.td - Mips Register defs
>> it should be
>> MipsInstrFormats.td - Mips Instruction Formats
>>
>> lib/Target/Mips/MipsInstrInfo.td
>> MipsInstrInfo.td - Mips Register defs
>> it should be
>> MipsInstrInfo.td - Target Description for Mips Target
>>
>> and some thing I think it is wrong in lib/Target/Mips/MipsInstrFPU.td.
>>
>> Will the patch be OK?
>>
>> Best regards.
>>
>> --Liu
>> <Mips-td-comment-type-error.patch>
>
> Looks fine. Do you need someone to apply this for you?
>
> -eric
>
Hi Eric

I'm so glad someone apply this to me. Will you?
Thanks.

--Liu