llvm dev - Jun 2017 - Enabling EarlyCSE w/ MemorySSA by default

+1
If possible, it definitely helps to fuzz it.


On Sat, Jun 10, 2017 at 2:45 PM, Davide Italiano via llvm-dev <
llvm-dev at lists.llvm.org> wrote:
> On Sat, Jun 10, 2017 at 8:21 AM, Geoff Berry via llvm-dev
> <llvm-dev at lists.llvm.org> wrote:
> > Hi All,
> >
> > I'd like to switch the function simplification run of EarlyCSE to
use
> > MemorySSA by default.  This change has been in tree for a while and
I've
> > done benchmark and self-hosting testing on both aarch64 and x86, but I
> > wanted to give other folks with different tests/targets a chance to
try
> this
> > out before I flip the switch. I've added an option
> '-enable-earlycse-memssa'
> > (or '-enable-npm-gvn-hoist' if you're using the new pass
manager) that
> you
> > can be used to test this change out.
> >
>
> Not that I don't trust your self-hosting test strategy, but other
> passes (e.g. GVNHoist or NewGVN) showed us that's not quite enough to
> declare victory. I'll be much more confident if we can do at least a
> round of fuzzing.
>
> Thanks,
>
> --
> Davide
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20170610/ee9bcc30/attachment.html>

Sure, we are happy to start some testing to see what we may help find.

On Sat, Jun 10, 2017 at 3:36 PM, Daniel Berlin <dberlin at dberlin.org>
wrote:
> +1
> If possible, it definitely helps to fuzz it.
>
>
> On Sat, Jun 10, 2017 at 2:45 PM, Davide Italiano via llvm-dev <
> llvm-dev at lists.llvm.org> wrote:
>
>> On Sat, Jun 10, 2017 at 8:21 AM, Geoff Berry via llvm-dev
>> <llvm-dev at lists.llvm.org> wrote:
>> > Hi All,
>> >
>> > I'd like to switch the function simplification run of EarlyCSE
to use
>> > MemorySSA by default.  This change has been in tree for a while
and I've
>> > done benchmark and self-hosting testing on both aarch64 and x86,
but I
>> > wanted to give other folks with different tests/targets a chance
to try
>> this
>> > out before I flip the switch. I've added an option
>> '-enable-earlycse-memssa'
>> > (or '-enable-npm-gvn-hoist' if you're using the new
pass manager) that
>> you
>> > can be used to test this change out.
>> >
>>
>> Not that I don't trust your self-hosting test strategy, but other
>> passes (e.g. GVNHoist or NewGVN) showed us that's not quite enough
to
>> declare victory. I'll be much more confident if we can do at least
a
>> round of fuzzing.
>>
>> Thanks,
>>
>> --
>> Davide
>> _______________________________________________
>> LLVM Developers mailing list
>> llvm-dev at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>>
>
>
-- 
Zhendong Su, Professor
Chancellor's Fellow
UC Davis
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20170610/35df7c18/attachment.html>

For what it's worth, I just ran this on PowerPC and a double bootstrap with
lit and lnt tests passes everything.

On Sun, Jun 11, 2017 at 12:38 AM, Zhendong Su via llvm-dev <
llvm-dev at lists.llvm.org> wrote:
> Sure, we are happy to start some testing to see what we may help find.
>
> On Sat, Jun 10, 2017 at 3:36 PM, Daniel Berlin <dberlin at
dberlin.org>
> wrote:
>
>> +1
>> If possible, it definitely helps to fuzz it.
>>
>>
>> On Sat, Jun 10, 2017 at 2:45 PM, Davide Italiano via llvm-dev <
>> llvm-dev at lists.llvm.org> wrote:
>>
>>> On Sat, Jun 10, 2017 at 8:21 AM, Geoff Berry via llvm-dev
>>> <llvm-dev at lists.llvm.org> wrote:
>>> > Hi All,
>>> >
>>> > I'd like to switch the function simplification run of
EarlyCSE to use
>>> > MemorySSA by default.  This change has been in tree for a
while and
>>> I've
>>> > done benchmark and self-hosting testing on both aarch64 and
x86, but I
>>> > wanted to give other folks with different tests/targets a
chance to
>>> try this
>>> > out before I flip the switch. I've added an option
>>> '-enable-earlycse-memssa'
>>> > (or '-enable-npm-gvn-hoist' if you're using the
new pass manager) that
>>> you
>>> > can be used to test this change out.
>>> >
>>>
>>> Not that I don't trust your self-hosting test strategy, but
other
>>> passes (e.g. GVNHoist or NewGVN) showed us that's not quite
enough to
>>> declare victory. I'll be much more confident if we can do at
least a
>>> round of fuzzing.
>>>
>>> Thanks,
>>>
>>> --
>>> Davide
>>> _______________________________________________
>>> LLVM Developers mailing list
>>> llvm-dev at lists.llvm.org
>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>>>
>>
>>
> --
> Zhendong Su, Professor
> Chancellor's Fellow
> UC Davis
>
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20170619/25999054/attachment.html>