I just wanted to let you know that the hack to make rawk work on Rails
2.2.2 by grouping action calls no longer works.
This is the hack, I have put the TODO where the line crashes Rails:
--
module ActiveSupport
class BufferedLogger
def add(severity, message = nil, progname = nil, &block)
return if @level > severity
message = (message || (block && block.call) || progname).to_s
# If a newline is necessary then create a new message ending with
a newline.
# Ensures that the original message is not mutated.
message = "#{message} (pid:#{$$})" if
RAILS_ENV=="production"
message = "#{message}\n" unless message[-1] == ?\n
@buffer << message # TODO: this line no longer works with Rails
2.2.2
auto_flush
message
end
end
end
--
The error message is the following:
--
Error during failsafe response: undefined method `<<'' for {}:Hash
(originally undefined method `<<'' for {}:Hash)
--
--
Posted via http://www.ruby-forum.com/.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Talk" group.
To post to this group, send email to
rubyonrails-talk-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-talk+unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-talk?hl=en
-~----------~----~----~----~------~----~------~--~---
On 22 Nov 2008, at 13:51, Fernando Perez wrote:> > I just wanted to let you know that the hack to make rawk work on Rails > 2.2.2 by grouping action calls no longer works. > > This is the hack, I have put the TODO where the line crashes Rails: > -- > module ActiveSupport > class BufferedLogger > def add(severity, message = nil, progname = nil, &block) > return if @level > severity > message = (message || (block && block.call) || progname).to_s > # If a newline is necessary then create a new message ending with > a newline. > # Ensures that the original message is not mutated. > message = "#{message} (pid:#{$$})" if RAILS_ENV=="production" > message = "#{message}\n" unless message[-1] == ?\n > @buffer << message # TODO: this line no longer works with Railsthat line needs to be changed to buffer << message Fred --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group. To post to this group, send email to rubyonrails-talk-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org To unsubscribe from this group, send email to rubyonrails-talk+unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org For more options, visit this group at http://groups.google.com/group/rubyonrails-talk?hl=en -~----------~----~----~----~------~----~------~--~---
Frederick Cheung wrote:> On 22 Nov 2008, at 13:51, Fernando Perez wrote: > >> message = (message || (block && block.call) || progname).to_s >> # If a newline is necessary then create a new message ending with >> a newline. >> # Ensures that the original message is not mutated. >> message = "#{message} (pid:#{$$})" if RAILS_ENV=="production" >> message = "#{message}\n" unless message[-1] == ?\n >> @buffer << message # TODO: this line no longer works with Rails > > that line needs to be changed to buffer << message > > FredSmashing it works! Thanks Fred. How did you know about that? Do you often dive into Rails source code? -- Posted via http://www.ruby-forum.com/. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group. To post to this group, send email to rubyonrails-talk-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org To unsubscribe from this group, send email to rubyonrails-talk+unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org For more options, visit this group at http://groups.google.com/group/rubyonrails-talk?hl=en -~----------~----~----~----~------~----~------~--~---
On Nov 22, 2:31 pm, Fernando Perez <rails-mailing-l...-ARtvInVfO7ksV2N9l4h3zg@public.gmane.org> wrote:> Frederick Cheung wrote:> > that line needs to be changed to buffer << message > > > Fred > > Smashing it works! Thanks Fred. How did you know about that? Do you > often dive into Rails source code?Well if you look at the original method this one is replacing it seemed fairly obvious. Fred --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group. To post to this group, send email to rubyonrails-talk-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org To unsubscribe from this group, send email to rubyonrails-talk+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-talk?hl=en -~----------~----~----~----~------~----~------~--~---