Hi! I am creating a application that does a lot of background processing. For this I am using a queue (starling in my case...) and several pollers that will get a message from the queue and execute some code corresponding do it. The code that these pollers process looks a lot like some code in methods included in some of my rails application controllers. I wanted to DRY this a little bit, so I tried to use the controllers method. What I ended up doing is basically using an ActionController::Integration::Session, exactly like in the console or when doing tests. I wanted to know if that was absolutely wrong or if it was ok. I guess there are some consequences as well, but what are they? Thanks a lot for your help! -- Posted via http://www.ruby-forum.com/. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group. To post to this group, send email to rubyonrails-talk-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org To unsubscribe from this group, send email to rubyonrails-talk+unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org For more options, visit this group at http://groups.google.com/group/rubyonrails-talk?hl=en -~----------~----~----~----~------~----~------~--~---
On Sun, Oct 12, 2008 at 12:01 AM, Julien Genestoux <rails-mailing-list-ARtvInVfO7ksV2N9l4h3zg@public.gmane.org> wrote:> The code that these pollers process looks a lot like some code in > methods included in some of my rails application controllers. I wanted > to DRY this a little bit, so I tried to use the controllers method.> I wanted to know if that was absolutely wrong or if it was ok. I guess > there are some consequences as well, but what are they?I''ll let someone with more experience respond to that, but wouldn''t it make sense (and be ultimately cleaner) to refactor those methods out of the controller(s) into application.rb? FWIW, -- Hassan Schroeder ------------------------ hassan.schroeder-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group. To post to this group, send email to rubyonrails-talk-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org To unsubscribe from this group, send email to rubyonrails-talk+unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org For more options, visit this group at http://groups.google.com/group/rubyonrails-talk?hl=en -~----------~----~----~----~------~----~------~--~---
Hassan Schroeder wrote:> On Sun, Oct 12, 2008 at 12:01 AM, Julien Genestoux > <rails-mailing-list-ARtvInVfO7ksV2N9l4h3zg@public.gmane.org> wrote: > >> The code that these pollers process looks a lot like some code in >> methods included in some of my rails application controllers. I wanted >> to DRY this a little bit, so I tried to use the controllers method. > >> I wanted to know if that was absolutely wrong or if it was ok. I guess >> there are some consequences as well, but what are they? > > I''ll let someone with more experience respond to that, but wouldn''t > it make sense (and be ultimately cleaner) to refactor those methods > out of the controller(s) into application.rb? > > FWIW, > -- > Hassan Schroeder ------------------------ hassan.schroeder-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.orgThanks Hassan, Hum, I am a little confused, but I don''t think so... Actually, I am about to write implementations for AbstractResponse and AbstractRequests so that I can call the controller''s methods with them! Anyone else has tips/opinions about this? -- Posted via http://www.ruby-forum.com/. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group. To post to this group, send email to rubyonrails-talk-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org To unsubscribe from this group, send email to rubyonrails-talk+unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org For more options, visit this group at http://groups.google.com/group/rubyonrails-talk?hl=en -~----------~----~----~----~------~----~------~--~---
Controllers are designed (in MVC patterns) to process requests and deliver responses. Rails-based controllers are designed for HTTP request/ response. The answer is to make your own controller that answers your agents'' responses. Take advantage of Ruby here - take common code OUT of the controllers and put it into modules. Include the modules into your controllers, then make your own listener class that also mixes those models in. Use a daemon to keep that listener going. Railscasts.com has a nice screencast on daemons. How does that sound? On Tue, Oct 14, 2008 at 3:50 PM, Julien Genestoux < rails-mailing-list-ARtvInVfO7ksV2N9l4h3zg@public.gmane.org> wrote:> > Hassan Schroeder wrote: > > On Sun, Oct 12, 2008 at 12:01 AM, Julien Genestoux > > <rails-mailing-list-ARtvInVfO7ksV2N9l4h3zg@public.gmane.org> wrote: > > > >> The code that these pollers process looks a lot like some code in > >> methods included in some of my rails application controllers. I wanted > >> to DRY this a little bit, so I tried to use the controllers method. > > > >> I wanted to know if that was absolutely wrong or if it was ok. I guess > >> there are some consequences as well, but what are they? > > > > I''ll let someone with more experience respond to that, but wouldn''t > > it make sense (and be ultimately cleaner) to refactor those methods > > out of the controller(s) into application.rb? > > > > FWIW, > > -- > > Hassan Schroeder ------------------------ hassan.schroeder-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org > > Thanks Hassan, > > Hum, I am a little confused, but I don''t think so... Actually, I am > about to write implementations for AbstractResponse and AbstractRequests > so that I can call the controller''s methods with them! > > Anyone else has tips/opinions about this? > > -- > Posted via http://www.ruby-forum.com/. > > > >--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group. To post to this group, send email to rubyonrails-talk-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org To unsubscribe from this group, send email to rubyonrails-talk+unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org For more options, visit this group at http://groups.google.com/group/rubyonrails-talk?hl=en -~----------~----~----~----~------~----~------~--~---
Thanks Brian for this! That sounds good! A lot of work, but good, thanks for this! julien Brian Hogan wrote:> Controllers are designed (in MVC patterns) to process requests and > deliver > responses. Rails-based controllers are designed for HTTP request/ > response. > The answer is to make your own controller that answers your agents'' > responses. > > Take advantage of Ruby here - take common code OUT of the controllers > and > put it into modules. Include the modules into your controllers, then > make > your own listener class that also mixes those models in. Use a daemon to > keep that listener going. Railscasts.com has a nice screencast on > daemons. > > How does that sound? > > On Tue, Oct 14, 2008 at 3:50 PM, Julien Genestoux <-- Posted via http://www.ruby-forum.com/. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group. To post to this group, send email to rubyonrails-talk-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org To unsubscribe from this group, send email to rubyonrails-talk+unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org For more options, visit this group at http://groups.google.com/group/rubyonrails-talk?hl=en -~----------~----~----~----~------~----~------~--~---