I have been using zfs boot with lzjb compression on since build 75, from time to time I had similar problem, not sure why. As best practise, I do snapshot the root filesystem frequently, so that I can rollback to the last working snapshot. Rgds, Andre W. Victor Latushkin wrote:>>> this seems quite easy to me.... but I don''t know how to "move around" to >>> actually implement/propose the required changes. >>> >>> >>> To make grub aware of gzip (as it already is of lzjb) the steps should be: >>> >>> >>> 1. create a new >>> >>> /onnv-gate/usr/src/grub/grub-0.95/stage2/zfs_gzip.c >>> >>> starting from >>> >>> /onnv-gate/usr/src/uts/common/fs/zfs/gzip.c >>> >>> and removing the gzip_compress funcion >>> > > Yes, but it is a little bit more complicated than that. gzip support in > in-kernel ZFS leverages in-kernel zlib implementation. There is support > for gzip decompression algorithm in grub (see gunzip.c), so one need to > figure out how to leverage that and replace z_uncompress() with proper > call. > > >>> 2. add gzip_decompress >>> >>> at the end of >>> >>> /onnv-gate/usr/src/grub/grub-0.95/stage2/fsys_zfs.h >>> >>> >>> 3. update the decomp_table function to link "gzip" and all "gzip-N" >>> (with N=1...9) to the gzip_decompress function in >>> >>> /onnv-gate/usr/src/grub/grub-0.95/stage2/fsys_zfs.c >>> > > This sounds reasonable. > > Also one need to make sure that resulting binary does not exceed size > requirements (if any), thoroughly test it to verify that it works on all > HW architectures with all compression algorithms (and even mix of them). > > This may be not an exhaustive list of things to do. > > >>> What should I do to go on with this changes? Should I start a "community >>> project"? >>> >>> > > >> These changes look simple enough so there is no point setting up >> community project imho. >> >> Just implement it, test it then ask for a sponsor and integrate it. >> > > As Robert points out, this indeed may be quite simple to bother setting > up community project, so it may be better to treat this just like > bite-size-rfe ;-) > > Wbr, > Victor > _______________________________________________ > zfs-discuss mailing list > zfs-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/zfs-discuss >
Hi, using VirtualBox I just tried to move an OpenSolaris 2008.05 boot environment (ZFS) on a gzip-9 compressed dataset, but I have the following error from grub: Error 16: Inconsistent filesystem structure Googling around I found the same error with ZFS boot and Xen in July 2007: http://mail.opensolaris.org/pipermail/xen-discuss/2007-July/000961.html http://bugs.opensolaris.org/bugdatabase/printableBug.do?bug_id=6584697 That was fixed.. Is mine another bug? BTW, using gzip-9 compression I got the whole OpenSolaris image in < 815MB... The only issue is that it is not booting anymore ;-) Rgrds, Danilo. Danilo Poccia Senior Systems Engineer Sun Microsystems Italia S.p.A. Via G. Romagnosi, 4 Roma 00196 ITALY Phone +39 06 36708 022 Mobile +39 335 6983999 Fax +39 06 3221969 Email Danilo.Poccia at Sun.COM Blog http://blogs.sun.com/danilop -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.opensolaris.org/pipermail/zfs-discuss/attachments/20080516/b2d9b893/attachment.html>
> Hi, > > using VirtualBox I just tried to move an OpenSolaris 2008.05 boot > environment (ZFS) on a gzip-9 compressed dataset, but I have the > following error from grub: > > Error 16: Inconsistent filesystem structure > > Googling around I found the same error with ZFS boot and Xen in July 2007: > > http://mail.opensolaris.org/pipermail/xen-discuss/2007-July/000961.html > http://bugs.opensolaris.org/bugdatabase/printableBug.do?bug_id=6584697 > > That was fixed.. Is mine another bug?This is because grub does not support booting from gzip-compressed datasets now. At this moment only LZJB algorithm is supported, please see decomp_table here: http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/grub/grub-0.95/stage2/fsys_zfs.c#65> BTW, using gzip-9 compression I got the whole OpenSolaris image in < > 815MB... The only issue is that it is not booting anymore ;-)Adding support for gzip may be a candidate for community project. Hth, Victor
Hi Victor, this seems quite easy to me.... but I don''t know how to "move around" to actually implement/propose the required changes. To make grub aware of gzip (as it already is of lzjb) the steps should be: 1. create a new /onnv-gate/usr/src/grub/grub-0.95/stage2/zfs_gzip.c starting from /onnv-gate/usr/src/uts/common/fs/zfs/gzip.c and removing the gzip_compress funcion 2. add gzip_decompress at the end of /onnv-gate/usr/src/grub/grub-0.95/stage2/fsys_zfs.h 3. update the decomp_table function to link "gzip" and all "gzip- N" (with N=1...9) to the gzip_decompress function in /onnv-gate/usr/src/grub/grub-0.95/stage2/fsys_zfs.c What should I do to go on with this changes? Should I start a "community project"? Thanks & Rgrds, Danilo. Il giorno 16/mag/08, alle ore 12:53, Victor Latushkin ha scritto:>> Hi, >> using VirtualBox I just tried to move an OpenSolaris 2008.05 boot >> environment (ZFS) on a gzip-9 compressed dataset, but I have the >> following error from grub: >> Error 16: Inconsistent filesystem structure >> Googling around I found the same error with ZFS boot and Xen in >> July 2007: >> http://mail.opensolaris.org/pipermail/xen-discuss/2007-July/000961.html >> http://bugs.opensolaris.org/bugdatabase/printableBug.do? >> bug_id=6584697 >> That was fixed.. Is mine another bug? > > This is because grub does not support booting from gzip-compressed > datasets now. At this moment only LZJB algorithm is supported, > please see decomp_table here: > > http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/grub/grub-0.95/stage2/fsys_zfs.c#65 > >> BTW, using gzip-9 compression I got the whole OpenSolaris image in >> < 815MB... The only issue is that it is not booting anymore ;-) > > Adding support for gzip may be a candidate for community project. > > Hth, > VictorDanilo Poccia Senior Systems Engineer Sun Microsystems Italia S.p.A. Via G. Romagnosi, 4 Roma 00196 ITALY Phone +39 06 36708 022 Mobile +39 335 6983999 Fax +39 06 3221969 Email Danilo.Poccia at Sun.COM Blog http://blogs.sun.com/danilop -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.opensolaris.org/pipermail/zfs-discuss/attachments/20080516/a6677802/attachment.html>
...just noticed there is a bug on that, but it seems there no activity even if it is in state "accepted": http://bugs.opensolaris.org/view_bug.do?bug_id=6538017 Should I send an email to request-sponsor AT opensolaris DOT org to propose my fix? Rgrds, Danilo. Il giorno 16/mag/08, alle ore 14:34, Danilo Poccia ha scritto:> Hi Victor, > > this seems quite easy to me.... but I don''t know how to "move > around" to actually implement/propose the required changes. > > To make grub aware of gzip (as it already is of lzjb) the steps > should be: > > 1. create a new > /onnv-gate/usr/src/grub/grub-0.95/stage2/zfs_gzip.c > starting from > /onnv-gate/usr/src/uts/common/fs/zfs/gzip.c > and removing the gzip_compress funcion > > 2. add gzip_decompress > at the end of > /onnv-gate/usr/src/grub/grub-0.95/stage2/fsys_zfs.h > > 3. update the decomp_table function to link "gzip" and all "gzip- > N" (with N=1...9) to the gzip_decompress function in > /onnv-gate/usr/src/grub/grub-0.95/stage2/fsys_zfs.c > > What should I do to go on with this changes? Should I start a > "community project"? > > Thanks & Rgrds, > Danilo. > > Il giorno 16/mag/08, alle ore 12:53, Victor Latushkin ha scritto: > >>> Hi, >>> using VirtualBox I just tried to move an OpenSolaris 2008.05 boot >>> environment (ZFS) on a gzip-9 compressed dataset, but I have the >>> following error from grub: >>> Error 16: Inconsistent filesystem structure >>> Googling around I found the same error with ZFS boot and Xen in >>> July 2007: >>> http://mail.opensolaris.org/pipermail/xen-discuss/2007-July/000961.html >>> http://bugs.opensolaris.org/bugdatabase/printableBug.do?bug_id=6584697 >>> That was fixed.. Is mine another bug? >> >> This is because grub does not support booting from gzip-compressed >> datasets now. At this moment only LZJB algorithm is supported, >> please see decomp_table here: >> >> http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/grub/grub-0.95/stage2/fsys_zfs.c#65 >> >>> BTW, using gzip-9 compression I got the whole OpenSolaris image in >>> < 815MB... The only issue is that it is not booting anymore ;-) >> >> Adding support for gzip may be a candidate for community project. >> >> Hth, >> Victor > > Danilo Poccia > Senior Systems Engineer > Sun Microsystems Italia S.p.A. > Via G. Romagnosi, 4 > Roma 00196 ITALY > Phone +39 06 36708 022 > Mobile +39 335 6983999 > Fax +39 06 3221969 > Email Danilo.Poccia at Sun.COM > Blog http://blogs.sun.com/danilop >Danilo Poccia Senior Systems Engineer Sun Microsystems Italia S.p.A. Via G. Romagnosi, 4 Roma 00196 ITALY Phone +39 06 36708 022 Mobile +39 335 6983999 Fax +39 06 3221969 Email Danilo.Poccia at Sun.COM Blog http://blogs.sun.com/danilop -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.opensolaris.org/pipermail/zfs-discuss/attachments/20080516/ea599e93/attachment.html>
Hello Danilo, Friday, May 16, 2008, 1:34:56 PM, you wrote: > Hi Victor, this seems quite easy to me.... but I don''t know how to "move around" to actually implement/propose the required changes. To make grub aware of gzip (as it already is of lzjb) the steps should be: 1. create a new /onnv-gate/usr/src/grub/grub-0.95/stage2/zfs_gzip.c starting from /onnv-gate/usr/src/uts/common/fs/zfs/gzip.c and removing the gzip_compress funcion 2. add gzip_decompress at the end of /onnv-gate/usr/src/grub/grub-0.95/stage2/fsys_zfs.h 3. update the decomp_table function to link "gzip" and all "gzip-N" (with N=1...9) to the gzip_decompress function in /onnv-gate/usr/src/grub/grub-0.95/stage2/fsys_zfs.c What should I do to go on with this changes? Should I start a "community project"? > These changes look simple enough so there is no point setting up community project imho. Just implement it, test it then ask for a sponsor and integrate it. -- Best regards, Robert mailto:milek@task.gda.pl http://milek.blogspot.com _______________________________________________ zfs-discuss mailing list zfs-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/zfs-discuss
>> this seems quite easy to me.... but I don''t know how to "move around" to >> actually implement/propose the required changes. >> >> >> To make grub aware of gzip (as it already is of lzjb) the steps should be: >> >> >> 1. create a new >> >> /onnv-gate/usr/src/grub/grub-0.95/stage2/zfs_gzip.c >> >> starting from >> >> /onnv-gate/usr/src/uts/common/fs/zfs/gzip.c >> >> and removing the gzip_compress funcionYes, but it is a little bit more complicated than that. gzip support in in-kernel ZFS leverages in-kernel zlib implementation. There is support for gzip decompression algorithm in grub (see gunzip.c), so one need to figure out how to leverage that and replace z_uncompress() with proper call.>> 2. add gzip_decompress >> >> at the end of >> >> /onnv-gate/usr/src/grub/grub-0.95/stage2/fsys_zfs.h >> >> >> 3. update the decomp_table function to link "gzip" and all "gzip-N" >> (with N=1...9) to the gzip_decompress function in >> >> /onnv-gate/usr/src/grub/grub-0.95/stage2/fsys_zfs.cThis sounds reasonable. Also one need to make sure that resulting binary does not exceed size requirements (if any), thoroughly test it to verify that it works on all HW architectures with all compression algorithms (and even mix of them). This may be not an exhaustive list of things to do.>> What should I do to go on with this changes? Should I start a "community >> project"? >>> These changes look simple enough so there is no point setting up > community project imho. > > Just implement it, test it then ask for a sponsor and integrate it.As Robert points out, this indeed may be quite simple to bother setting up community project, so it may be better to treat this just like bite-size-rfe ;-) Wbr, Victor
Hello Danilo, Friday, May 16, 2008, 2:00:42 PM, you wrote: > ...just noticed there is a bug on that, but it seems there no activity even if it is in state "accepted": http://bugs.opensolaris.org/view_bug.do?bug_id=6538017 Should I send an email to request-sponsor AT opensolaris DOT org to propose my fix? Send a request and without waiting for the response just start coding :) -- Best regards, Robert mailto:milek@task.gda.pl http://milek.blogspot.com _______________________________________________ zfs-discuss mailing list zfs-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/zfs-discuss