Guys: Could anybody tell me how to submit code changes for Xen? And, is there any way to know whether and when the code change will be integrated(accepted) Shunli Yi Protected by Websense Hosted Email Security -- www.websense.com _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Wed, Sep 16, 2009 at 12:01:30AM -0700, Yi, Shunli wrote:> Guys: > Could anybody tell me how to submit code changes for Xen? > > And, is there any way to know whether and when the code change will be integrated(accepted) >Just send the patch to xen-devel and most probably people will comment about it, or merge it. -- Pasi _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Thanks, I did. But, it's a little strange that I got nothing reply, I don't know whether my code is feasible and acceptable. I have to forget it after send out the patch, maybe it didn't reached at all. Is there a track system for all patches ? SHUNLI YI ESSENTIAL INFORMATION PROTECTION -----Original Message----- From: Pasi Kärkkäinen [mailto:pasik@iki.fi] Sent: 2009年9月16日 15:07 To: Yi, Shunli Cc: xen-devel@lists.xensource.com Subject: Re: [Xen-devel] How to submit code changes for Xen? On Wed, Sep 16, 2009 at 12:01:30AM -0700, Yi, Shunli wrote:> Guys: > Could anybody tell me how to submit code changes for Xen? > > And, is there any way to know whether and when the code change will be integrated(accepted) >Just send the patch to xen-devel and most probably people will comment about it, or merge it. -- Pasi Protected by Websense Hosted Email Security -- www.websense.com _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Oh, was yours the patch against Xen 3.3? That branch isn''t actively maintained any more. We really only directly accept patches against xen-unstable. -- Keir On 16/09/2009 08:36, "Yi, Shunli" <syi@websense.com> wrote:> Thanks, I did. > But, it''s a little strange that I got nothing reply, I don''t know whether my > code is feasible and acceptable. > I have to forget it after send out the patch, maybe it didn''t reached at all. > > Is there a track system for all patches ? > > SHUNLI YI > > ESSENTIAL INFORMATION PROTECTION > -----Original Message----- > From: Pasi Kärkkäinen [mailto:pasik@iki.fi] > Sent: 2009年9月16日 15:07 > To: Yi, Shunli > Cc: xen-devel@lists.xensource.com > Subject: Re: [Xen-devel] How to submit code changes for Xen? > > On Wed, Sep 16, 2009 at 12:01:30AM -0700, Yi, Shunli wrote: >> Guys: >> Could anybody tell me how to submit code changes for Xen? >> >> And, is there any way to know whether and when the code change will be >> integrated(accepted) >> > > Just send the patch to xen-devel and most probably people will comment > about it, or merge it. > > -- Pasi > >Protected by Websense Hosted Email Security -- www.websense.com _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Well, I will try again and send out the patch against the xen-unstable . But it's realy better if there is a system to track all the patches ( just like bugzilla.redhat.com). SHUNLI YI ESSENTIAL INFORMATION PROTECTION -----Original Message----- From: Keir Fraser [mailto:keir.fraser@eu.citrix.com] Sent: 2009年9月16日 16:18 To: Yi, Shunli; Pasi Kärkkäinen Cc: xen-devel@lists.xensource.com Subject: Re: [Xen-devel] How to submit code changes for Xen? Oh, was yours the patch against Xen 3.3? That branch isn't actively maintained any more. We really only directly accept patches against xen-unstable. -- Keir On 16/09/2009 08:36, "Yi, Shunli" <syi@websense.com> wrote:> Thanks, I did. > But, it's a little strange that I got nothing reply, I don't know whether my > code is feasible and acceptable. > I have to forget it after send out the patch, maybe it didn't reached at all. > > Is there a track system for all patches ? > > SHUNLI YI > > ESSENTIAL INFORMATION PROTECTION > -----Original Message----- > From: Pasi Kärkkäinen [mailto:pasik@iki.fi] > Sent: 2009年9月16日 15:07 > To: Yi, Shunli > Cc: xen-devel@lists.xensource.com > Subject: Re: [Xen-devel] How to submit code changes for Xen? > > On Wed, Sep 16, 2009 at 12:01:30AM -0700, Yi, Shunli wrote: >> Guys: >> Could anybody tell me how to submit code changes for Xen? >> >> And, is there any way to know whether and when the code change will be >> integrated(accepted) >> > > Just send the patch to xen-devel and most probably people will comment > about it, or merge it. > > -- Pasi > >Protected by Websense Hosted Email Security -- www.websense.com _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
I believe the accepted protocol is to re-send the patch after 2-4 weeks, with a comment to the effect that you didn''t get a response last time; perhaps with the [RESEND] in the subject line, to alert people that the last mail was dropped? Obviously it would be nice if everyone got a comment the first time, but that''s not always possible. This method may seem a little less friendly, but in fact it has several positive attributes: * It distributes the responsibility of keeping track of patches, rather than having a centralized location * It naturally filters out low-interest patches. If neither the submitter nor others on the list find it interesting, they naturally get dropped instead of piling up in a queue somewhere; whereas, if the submitter considers it interesting and important, he will persist until he gets a response. The main difficulty is letting new people know the policy: don''t take it hard if you don''t get a response, just re-send after a few weeks. Stephen, is there a "xen-devel guidelines" page up anywhere? It might be have something we can point people to, or that Google would turn up if someone searched for "submitting patches to Xen"... -George On Wed, Sep 16, 2009 at 9:35 AM, Yi, Shunli <syi@websense.com> wrote:> Well, I will try again and send out the patch against the xen-unstable . > But it''s realy better if there is a system to track all the patches ( just like bugzilla.redhat.com). > > SHUNLI YI > > ESSENTIAL INFORMATION PROTECTION > > -----Original Message----- > From: Keir Fraser [mailto:keir.fraser@eu.citrix.com] > Sent: 2009年9月16日 16:18 > To: Yi, Shunli; Pasi Kärkkäinen > Cc: xen-devel@lists.xensource.com > Subject: Re: [Xen-devel] How to submit code changes for Xen? > > Oh, was yours the patch against Xen 3.3? That branch isn''t actively > maintained any more. We really only directly accept patches against > xen-unstable. > > -- Keir > > On 16/09/2009 08:36, "Yi, Shunli" <syi@websense.com> wrote: > >> Thanks, I did. >> But, it''s a little strange that I got nothing reply, I don''t know whether my >> code is feasible and acceptable. >> I have to forget it after send out the patch, maybe it didn''t reached at all. >> >> Is there a track system for all patches ? >> >> SHUNLI YI >> >> ESSENTIAL INFORMATION PROTECTION >> -----Original Message----- >> From: Pasi Kärkkäinen [mailto:pasik@iki.fi] >> Sent: 2009年9月16日 15:07 >> To: Yi, Shunli >> Cc: xen-devel@lists.xensource.com >> Subject: Re: [Xen-devel] How to submit code changes for Xen? >> >> On Wed, Sep 16, 2009 at 12:01:30AM -0700, Yi, Shunli wrote: >>> Guys: >>> Could anybody tell me how to submit code changes for Xen? >>> >>> And, is there any way to know whether and when the code change will be >>> integrated(accepted) >>> >> >> Just send the patch to xen-devel and most probably people will comment >> about it, or merge it. >> >> -- Pasi >> >> > > Protected by Websense Hosted Email Security -- www.websense.com > > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
> Stephen, is there a "xen-devel guidelines" page up anywhere? It might > be have something we can point people to, or that Google would turn up > if someone searched for "submitting patches to Xen"...Team: I found a page in the Xen Wiki that details how to create a PATCH - http://wiki.xensource.com/xenwiki/SubmittingXenPatches?highlight=%28patch%29. I will add some text about PATCH process for review, etc as well as bring this page to the main Developer Wiki Page (http://wiki.xensource.com/xenwiki/XenDevHome) with a link for people to find it easier. I will also add a blog commentary on this issue as well. Thanks. Stephen Spector Xen.org Community Manager T: (772) 621-5062 | F: (772) 365-0338 | M: (954) 854-4257 stephen.spector@xen.org http://blog.xen.org | @xen_com_mgr _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel