Xen devel - Nov 2008 - [PATCH] Dom0-kernel: Fix buggy mask_base in saving/restoring MSI-X table during S3

Hi, Keir, Jan,

This patch is a bugfix pointed by Jan. Fix mask_base(actually MSI-X table base,
copy name from native) to be a virtual address rather than a physical address.
And remove wrong printk in pci_disable_msix.

Jan, the error message you saw is wrong output from kernel''s MSI code.
Really sorry for my dirty code there.

Could you please review the patch and give me feedback?

Best Regards
Haitao Shan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Sorry, I attache a wrong version of my patch.
Please use this patch instead.

Best Regards
Haitao Shan

Shan, Haitao wrote:
> Hi, Keir, Jan,
> 
> This patch is a bugfix pointed by Jan. Fix mask_base(actually MSI-X
> table base, copy name from native) to be a virtual address rather
> than a physical address. And remove wrong printk in pci_disable_msix.
> 
> Jan, the error message you saw is wrong output from kernel''s MSI
> code. Really sorry for my dirty code there. 
> 
> Could you please review the patch and give me feedback?
> 
> Best Regards
> Haitao Shan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

>>> "Shan, Haitao" <haitao.shan@intel.com> 28.11.08
05:37 >>>
> Could you please review the patch and give me feedback?
Looks a lot better this way. The only issue remaining is the missing error
handling if the ioremap_nocache() fails.

Thanks, Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Thanks! And updated.
OK for you?

Best Regards
Haitao Shan

Jan Beulich wrote:
>>>> "Shan, Haitao" <haitao.shan@intel.com> 28.11.08
05:37 >>>
>> Could you please review the patch and give me feedback?
> 
> Looks a lot better this way. The only issue remaining is the missing
> error handling if the ioremap_nocache() fails.
> 
> Thanks, Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

>>> "Shan, Haitao" <haitao.shan@intel.com> 28.11.08
09:14 >>>
>Thanks! And updated.
>OK for you?
Only half way: You shouldn''t really fail device initialization in that
case, all
that should not work is suspend/resume.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Any idea of how to fail suspend/resume?
For example, if we failed in ioremap_nocache, we just do nothing at
suspend/resume? Let the device to handle it?

Best Regards
Shan Haitao
-----Original Message-----
From: Jan Beulich [mailto:jbeulich@novell.com] 
Sent: 2008年11月28日 16:50
To: Shan, Haitao
Cc: 'Keir Fraser'; 'xen-devel@lists.xensource.com'
Subject: RE: [Xen-devel] [PATCH] Dom0-kernel: Fix buggy mask_base
insaving/restoring MSI-X table during S3
>>> "Shan, Haitao" <haitao.shan@intel.com> 28.11.08
09:14 >>>
>Thanks! And updated.
>OK for you?
Only half way: You shouldn't really fail device initialization in that case,
all
that should not work is suspend/resume.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Hi, Keir,

This is the most updated version of my patch. Thanks for Jan''s kind
comments. It looks better now.
Would you please apply the patch?

Best Regards
Haitao Shan

Shan, Haitao wrote:
> Any idea of how to fail suspend/resume?
> For example, if we failed in ioremap_nocache, we just do nothing at
> suspend/resume? Let the device to handle it?
> 
> Best Regards
> Shan Haitao
Jan Beulich wrote:
>>>> "Shan, Haitao" <haitao.shan@intel.com> 28.11.08
09:14 >>>
>> Thanks! And updated.
>> OK for you?
> 
> Only half way: You shouldn''t really fail device initialization in
> that case, all that should not work is suspend/resume.
> 
> Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel