Xen devel - Nov 2008 - [PATCH][IOEMU] fix invisibility of PCI Option ROM

If ''lspci -v'' command on Dom0 shows
''[virtual]'' as follows,
the option ROM can''t be read by the guest.

$ lspci -v -s 0:1
...
        [virtual] Expansion ROM at fdb00000 [disabled] [size=256K]

Signed-off-by: Kouya Shimura <kouya@jp.fujitsu.com>



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Hi, Shimura-san,

It is better to write OS reporting value to device in
"pt_bar_reg_init"
function, I think.

The reasons are followings.

- "pt_pci_write_config" and "pt_pci_read_config" are generic
function.
  It is not good to put register-specific code to them.

- We need to set rom base address to device, because we''d like device
  to respond to the access from guest software.

Thanks,
--
Yuji Shimada


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Hi Shimada-san,

Thanks for your comment.
I agree it''s not good to modify the generic function.
Let me think for a while since I''m newbie in passthrough. 

Thanks,
Kouya

Yuji Shimada writes:
> Hi, Shimura-san,
> 
> It is better to write OS reporting value to device in
"pt_bar_reg_init"
> function, I think.
> 
> The reasons are followings.
> 
> - "pt_pci_write_config" and "pt_pci_read_config" are
generic function.
>   It is not good to put register-specific code to them.
> 
> - We need to set rom base address to device, because we''d like
device
>   to respond to the access from guest software.
> 
> Thanks,
> --
> Yuji Shimada
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
Signed-off-by: Kouya Shimura <kouya@jp.fujitsu.com>



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Hi,

This is the revised patch with Shimada-san''s suggestions.

If ''lspci -v'' command on Dom0 shows
''[virtual]'' as follows,
the option ROM can''t be read by the guest.

$ lspci -v -s 0:1
...
        [virtual] Expansion ROM at fdb00000 [disabled] [size=256K]

Thanks,
Kouya

Signed-off-by: Kouya Shimura <kouya@jp.fujitsu.com>



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Hi Ian,

I hope his patch is applied into qemu.

With his patch, option ROM can be read by the guest.

Thanks,
--
Yuji Shimada

On Mon, 1 Dec 2008 16:59:13 +0900
Kouya Shimura <kouya@jp.fujitsu.com> wrote:
> Hi,
> 
> This is the revised patch with Shimada-san''s suggestions.
> 
> If ''lspci -v'' command on Dom0 shows
''[virtual]'' as follows,
> the option ROM can''t be read by the guest.
> 
> $ lspci -v -s 0:1
> ...
>         [virtual] Expansion ROM at fdb00000 [disabled] [size=256K]
> 
> Thanks,
> Kouya
> 
> Signed-off-by: Kouya Shimura <kouya@jp.fujitsu.com>
> 
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel