Cui, Dexuan
2006-Oct-30 07:02 UTC
RE: [Xen-devel] [Patch][RESEND] Add hardware CR8 acceleration for TPRaccessing
Any advice about the patch cr8-acceleration-3.patch? Hi Keir, could you give some comments? Thanks! -- Dexuan -----Original Message----- From: xen-devel-bounces@lists.xensource.com [mailto:xen-devel-bounces@lists.xensource.com] On Behalf Of Cui, Dexuan Sent: 2006年10月25日 11:12 To: Keir.Fraser@cl.cam.ac.uk Cc: xen-devel@lists.xensource.com Subject: [Xen-devel] [Patch][RESEND] Add hardware CR8 acceleration for TPRaccessing x64 Windows uses CR8 to access TPR very frequently. This patch enables TPR shadow and allows mov-from/to-CR8 to access it directly; tests indicates it can boost greatly the performance of x64 Windows 2003. Thanks -- Dexuan Signed-off-by: Eddie Dong <eddie.dong@intel.com> Signed-off-by: Yunhong Jiang <yunhong.jiang@intel.com> Signed-off-by: Dexuan Cui <dexuan.cui@intel.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2006-Oct-30 10:39 UTC
Re: [Xen-devel] [Patch][RESEND] Add hardware CR8 acceleration for TPRaccessing
Why set the TPR threshold to non-zero when current TPR is less than highest
IRR? The TPR is not gating injection of the interrupt, so why would we care
if its value becomes even smaller -- it''s already small enough?
Couldn''t we have
if (highest_irr == -1) || (highest_irr > tpr)
TPR_thresh=0
else
TPR_thresh = highest_irr>>4
-- Keir
On 30/10/06 07:02, "Cui, Dexuan" <dexuan.cui@intel.com> wrote:
> Any advice about the patch cr8-acceleration-3.patch?
> Hi Keir, could you give some comments? Thanks!
> -- Dexuan
>
> -----Original Message-----
> From: xen-devel-bounces@lists.xensource.com
> [mailto:xen-devel-bounces@lists.xensource.com] On Behalf Of Cui, Dexuan
> Sent: 2006年10月25日 11:12
> To: Keir.Fraser@cl.cam.ac.uk
> Cc: xen-devel@lists.xensource.com
> Subject: [Xen-devel] [Patch][RESEND] Add hardware CR8 acceleration for
> TPRaccessing
>
> x64 Windows uses CR8 to access TPR very frequently. This patch enables
> TPR shadow and allows mov-from/to-CR8 to access it directly; tests
> indicates it can boost greatly the performance of x64 Windows 2003.
>
> Thanks
> -- Dexuan
>
> Signed-off-by: Eddie Dong <eddie.dong@intel.com>
> Signed-off-by: Yunhong Jiang <yunhong.jiang@intel.com>
> Signed-off-by: Dexuan Cui <dexuan.cui@intel.com>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Apparently Analagous Threads
- RE: [Patch][RESEND] Add hardware CR8 acceleration for TPRaccessing
- RE: [Patch] Add hardware CR8 acceleration for TPRaccessing
- [PATCH]Add CR8 virtualization
- [PATCH] A fix for CR8 acceleration on 64bit guest
- [PATCH v2] x86/paravirt: Drop {read,write}_cr8() hooks