Xen devel - Oct 2006 - RE: [Patch] Add hardware CR8 acceleration for TPRaccessing

Thanks for your advice. 
I will re-organize the patch.

Thanks
 -- Dexuan

-----Original Message-----
From: Li, Xin B 
Sent: 2006年10月24日 18:08
To: Petersson, Mats; Cui, Dexuan; Betak, Travis
Cc: xen-devel@lists.xensource.com
Subject: RE: [Xen-devel] [Patch] Add hardware CR8 acceleration for TPRaccessing

 >> From: xen-devel-bounces@lists.xensource.com 
>> [mailto:xen-devel-bounces@lists.xensource.com] On Behalf Of 
>> Cui, Dexuan
>> Sent: 24 October 2006 10:35
>> To: Betak, Travis
>> Cc: xen-devel@lists.xensource.com
>> Subject: RE: [Xen-devel] [Patch] Add hardware CR8 
>> acceleration for TPR accessing
>> 
>> Hi, Travis,
>> Is there anything in SVM similar to TPP-threshold in VMX?
>> If no, I really need to find a better place for the 
>> vlapic_update_tpr_threshold().
>
>I don''t think that''s the question/statement: any code in
hvm
>directory should be guaranteed to be callable by both Intel 
>and AMD code. The code you''ve just added makes direct use of 
>the vmwrite instruction, which there isn''t a corresponding 
>instruction for in AMD processors. 
Sure, it''s a guideline.

>
>[Whether it makes sense to call it for an AMD processor is a 
>completely different question - it''s the principle that the 
>code in the hvm directory should be "architecture independent"]. 
>
>You may need to implement another function-pointer in the hvm 
>structure to be able to do this... 
I think the point here is, how much we can share the common code, if we can get
more common idea on this topic between VMX and SVM, the code could be cleaner
:-)

-Xin

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Tue, 24 Oct 2006, Cui, Dexuan wrote:
>Thanks for your advice.
>I will re-organize the patch.
thanks!
>>> Is there anything in SVM similar to TPP-threshold in VMX?
>>> If no, I really need to find a better place for the
>>> vlapic_update_tpr_threshold().
...and SVM doesn''t have anything related to your tpr_threshold field.
We do have a field called v_tpr that is essentially the guest''s TPR/CR8
register but I think that''s as close as we come to VT.

  --travis



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel