This patch enhances how gdb handles assembler and has no performance issues and no size issues after striping. Signed-off-by: Jimi Xenidis <jimix@watson.ibm.com> --- diff -r 8a8361994904 xen/Rules.mk --- a/xen/Rules.mk Fri Mar 31 00:26:07 2006 +0100 +++ b/xen/Rules.mk Thu Mar 30 20:48:52 2006 -0500 @@ -55,7 +55,7 @@ CFLAGS-y += -DMAX_PHYS_CPU CFLAGS-y += -DMAX_PHYS_CPUS=$(max_phys_cpus) endif -AFLAGS-y += -D__ASSEMBLY__ +AFLAGS-y += -D__ASSEMBLY__ -Wa,-gdwarf2 ALL_OBJS := $(ALL_OBJS-y) CFLAGS := $(strip $(CFLAGS) $(CFLAGS-y)) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 31 Mar 2006, at 03:56, Jimi Xenidis wrote:> This patch enhances how gdb handles assembler and has no performance > issues and no size issues after striping. > Signed-off-by: Jimi Xenidis <jimix@watson.ibm.com>Does gcc not pass ''-g'' through to the assembler backend? When I added -Wa,-gdwarf-2 I saw no change in file sizes. If not, then still would -Wa,-g not be better? It should use the best debug format for the target system, just as -g does for gcc. Otherwise I would think we should be using -gdwarf-2 for C files as well. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Mar 31, 2006, at 4:21 AM, Keir Fraser wrote:> > On 31 Mar 2006, at 03:56, Jimi Xenidis wrote: > >> This patch enhances how gdb handles assembler and has no >> performance issues and no size issues after striping. >> Signed-off-by: Jimi Xenidis <jimix@watson.ibm.com> > > Does gcc not pass ''-g'' through to the assembler backend? When I > added -Wa,-gdwarf-2 I saw no change in file sizes.In the gcc-2.x and 3.[01] days we had to manually add this for the ppc and mips compilers, so I did it out of habbit. Seems it is not longer necessary with the newer gcc''s [snipped] (cd arch/x86 ;gcc -... -g -D__XEN__ -D__ASSEMBLY__ -v -c trampoline.S -o trampoline.o) gcc version 3.3.6 (Debian 1:3.3.6-10) /usr/lib/gcc-lib/i486-linux-gnu/3.3.6/cc1 -E ... -o - | as --gdwarf2 -V -Qy -o trampoline.o -> > If not, then still would -Wa,-g not be better? It should use the > best debug format for the target system, just as -g does for gcc. > Otherwise I would think we should be using -gdwarf-2 for C files as > well.-JX _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel