Xen devel - Nov 2005 - [PATCH] dom0_ops -EPERM not -EACCES?

Hi all,

	dom0_ops return -EACCES when the interface version in wrong.  I think
that an acm failure is closer to being non-priv''ed, which returns
-EPERM.  Wouldn''t want dom0 tools to report they were the wrong version
just because ACM limited some operation, surely?

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (authored)

diff -r e2d1c88d50f7 xen/common/dom0_ops.c
--- a/xen/common/dom0_ops.c	Thu Nov 24 00:55:37 2005
+++ b/xen/common/dom0_ops.c	Thu Nov 24 12:31:37 2005
@@ -102,7 +102,7 @@
         return -EACCES;
 
     if ( acm_pre_dom0_op(op, &ssid) )
-        return -EACCES;
+        return -EPERM;
 
     spin_lock(&dom0_lock);
 

-- 
A bad analogy is like a leaky screwdriver -- Richard Braakman


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

> Message: 2
> Date: Thu, 24 Nov 2005 12:35:42 +1100
> From: Rusty Russell <rusty@rustcorp.com.au>
> Subject: [Xen-devel] [PATCH] dom0_ops -EPERM not -EACCES?
> To: xense-devel@lists.xensource.com
> Cc: Xen Mailing List <xen-devel@lists.xensource.com>
> Message-ID: <1132796142.25612.8.camel@localhost.localdomain>
> Content-Type: text/plain
> 
> Hi all,
> 
>    dom0_ops return -EACCES when the interface version in wrong.  I think
> that an acm failure is closer to being non-priv''ed, which returns
> -EPERM.  Wouldn''t want dom0 tools to report they were the wrong
version
> just because ACM limited some operation, surely?
yes, -EPERM is the better return value here.

Reiner


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel