Scott Parish
2005-Feb-25 19:08 UTC
[Xen-devel] [PATCH] warn when iproute2 or bridge-utils are missing
The attached patch checks for "ip" and "brctl" in the path, and warns the user if they are not found. sRp -- Scott Parish
Matt Ayres
2005-Feb-25 20:22 UTC
Re: [Xen-devel] [PATCH] warn when iproute2 or bridge-utils are missing
On Fri, 2005-02-25 at 19:08 +0000, Scott Parish wrote:> The attached patch checks for "ip" and "brctl" in the path, and warns > the user if they are not found. >Now that the routed setup is included (and IMHO works a whole lot better) shouldn''t the brctl check be optional somehow? ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ Xen-devel mailing list Xen-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xen-devel
Scott Parish
2005-Feb-25 21:21 UTC
Re: [Xen-devel] [PATCH] warn when iproute2 or bridge-utils are missing
On Fri, Feb 25, 2005 at 03:22:58PM -0500, Matt Ayres wrote:> On Fri, 2005-02-25 at 19:08 +0000, Scott Parish wrote: > > The attached patch checks for "ip" and "brctl" in the path, and warns > > the user if they are not found. > > > > Now that the routed setup is included (and IMHO works a whole lot > better) shouldn''t the brctl check be optional somehow?Maybe what i started to do would be better then: make sure that output from the scripts gets sent to the console in addition to getting buried in the log file. Then have the scripts check that the programs that they need are available (before fiddling with the network and putting it in a half way state). sRp -- Scott Parish ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ Xen-devel mailing list Xen-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xen-devel
Anthony Liguori
2005-Feb-25 21:48 UTC
Re: [Xen-devel] [PATCH] warn when iproute2 or bridge-utils are missing
Isn''t it more appropriate to have these be install-time checks? It seems wasteful to check for an installed program every time a script is run. I submitted check scripts for iproute2 and iptables a while ago. All you have to do is add a check_iproute2 script to the tools/check directory that basically looks like: #!/bin/sh which ip || (echo "Check for iproute2 failed && exit 1) Regards, Anthony Liguori Scott Parish wrote:>On Fri, Feb 25, 2005 at 03:22:58PM -0500, Matt Ayres wrote: > > > >>On Fri, 2005-02-25 at 19:08 +0000, Scott Parish wrote: >> >> >>>The attached patch checks for "ip" and "brctl" in the path, and warns >>>the user if they are not found. >>> >>> >>> >>Now that the routed setup is included (and IMHO works a whole lot >>better) shouldn''t the brctl check be optional somehow? >> >> > >Maybe what i started to do would be better then: make sure that output >from the scripts gets sent to the console in addition to getting buried >in the log file. Then have the scripts check that the programs that they >need are available (before fiddling with the network and putting it in a >half way state). > >sRp > > >------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ Xen-devel mailing list Xen-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xen-devel