Jared Rhine
2005-Feb-04 23:44 UTC
[Xen-devel] [Xen-changelog] 1. Deleted slab.c, added xmalloc.c. Do not rename header or remove
[BitKeeper == Xen on Fri, 04 Feb 2005 22:47:58 +0000]
BitKeeper> ChangeSet 1.1768.1.1, 2005/02/04 22:47:58+00:00,
BitKeeper> iap10@labyrinth.cl.cam.ac.uk
BitKeeper> 1. Deleted slab.c, added xmalloc.c. Do not rename header
BitKeeper> or remove unnecessary includes (yet).
BitKeeper> 2. Add explicit align arg, although current
BitKeeper> implementation over-aligns.
BitKeeper> 3. Add list_for_each_entry_safe().
BitKeeper> 4. Make xmalloc_array use _xmalloc_array, to avoid
BitKeeper> duplicate eval of "num" arg.
BitKeeper> 5. Rearrange slab.h a little to show the exposed
BitKeeper> functions/macros first.
This patch broke my build on a fresh checkout.
gcc -nostdinc -fno-builtin -fno-common -fno-strict-aliasing
-iwithprefix include -Wall -Werror -Wno-format -pipe
-I/usr/local/src/xen/xen/include -Wno-pointer-arith -Wredundant-dec\ls
-O3 -fomit-frame-pointer -msoft-float -m32 -march=i686 -DNDEBUG -c
slab.c -o slab.o
slab.c:191: error: parse error before "xmem_cache_t"
slab.c:191: warning: no semicolon at end of struct or union
slab.c:196: error: parse error before "xmem_cache_t"
slab.c:199: error: parse error before "xmem_cache_t"
slab.c:224: error: parse error before ''}'' token
Investigating further, but hopefully this quick notice is valuable.
-- jared@wordzoo.com
"One cannot mark the point without marking the path."
-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xen-devel
Alex Ho
2005-Feb-04 23:55 UTC
Re: [Xen-devel] [Xen-changelog] 1. Deleted slab.c, added xmalloc.c. Do not rename header or remove
just delete xen/common/slab.c .a On Fri, 04 Feb 2005 15:44:33 -0800 Jared Rhine <jared@wordzoo.com> wrote:> [BitKeeper == Xen on Fri, 04 Feb 2005 22:47:58 +0000] > > BitKeeper> ChangeSet 1.1768.1.1, 2005/02/04 22:47:58+00:00, > BitKeeper> iap10@labyrinth.cl.cam.ac.uk > BitKeeper> 1. Deleted slab.c, added xmalloc.c. Do not rename header > BitKeeper> or remove unnecessary includes (yet). > BitKeeper> 2. Add explicit align arg, although current > BitKeeper> implementation over-aligns. > BitKeeper> 3. Add list_for_each_entry_safe(). > BitKeeper> 4. Make xmalloc_array use _xmalloc_array, to avoid > BitKeeper> duplicate eval of "num" arg. > BitKeeper> 5. Rearrange slab.h a little to show the exposed > BitKeeper> functions/macros first. > > This patch broke my build on a fresh checkout. > > gcc -nostdinc -fno-builtin -fno-common -fno-strict-aliasing > -iwithprefix include -Wall -Werror -Wno-format -pipe > -I/usr/local/src/xen/xen/include -Wno-pointer-arith -Wredundant-dec\ls > -O3 -fomit-frame-pointer -msoft-float -m32 -march=i686 -DNDEBUG -c > slab.c -o slab.o > slab.c:191: error: parse error before "xmem_cache_t" > slab.c:191: warning: no semicolon at end of struct or union > slab.c:196: error: parse error before "xmem_cache_t" > slab.c:199: error: parse error before "xmem_cache_t" > slab.c:224: error: parse error before ''}'' token > > Investigating further, but hopefully this quick notice is valuable. > > -- jared@wordzoo.com > > "One cannot mark the point without marking the path." > > > ------------------------------------------------------- > This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting > Tool for open source databases. Create drag-&-drop reports. Save time > by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc. > Download a FREE copy at http://www.intelliview.com/go/osdn_nl > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/xen-devel------------------------------------------------------- This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting Tool for open source databases. Create drag-&-drop reports. Save time by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc. Download a FREE copy at http://www.intelliview.com/go/osdn_nl _______________________________________________ Xen-devel mailing list Xen-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xen-devel
Jacob Gorm Hansen
2005-Feb-05 00:45 UTC
Re: [Xen-devel] [Xen-changelog] 1. Deleted slab.c, added xmalloc.c. Do not rename header or remove
Alex Ho wrote:> just delete xen/common/slab.c > .aI am getting a bunch of linker errors with the latest bkbits version: ld -m elf_i386 -T x86_32/xen.lds -N \ boot/x86_32.o /mnt/hda3/home/jacobg/xeno-unstable.bk/xen/common/common.o /mnt/hda3/home/jacobg/xeno-unstable.bk/xen/drivers/char/driver.o /mnt/hda3/home/jacobg/xeno-unstable.bk/xen/drivers/acpi/driver.o /mnt/hda3/home/jacobg/xeno-unstable.bk/xen/drivers/pci/driver.o /mnt/hda3/home/jacobg/xeno-unstable.bk/xen/arch/x86/arch.o -o /mnt/hda3/home/jacobg/xeno-unstable.bk/xen/xen-syms /mnt/hda3/home/jacobg/xeno-unstable.bk/xen/common/common.o(.text+0x15a2): In function `alloc_dom_mem'': : undefined reference to `hypercall_create_continuation'' /mnt/hda3/home/jacobg/xeno-unstable.bk/xen/common/common.o(.text+0x17db): In function `free_dom_mem'': : undefined reference to `hypercall_create_continuation'' /mnt/hda3/home/jacobg/xeno-unstable.bk/xen/common/common.o(.text+0x18f4): In function `do_createdomain'': : undefined reference to `arch_do_createdomain'' /mnt/hda3/home/jacobg/xeno-unstable.bk/xen/common/common.o(.text+0x1a2e): In function `domain_destruct'': : undefined reference to `free_perdomain_pt'' /mnt/hda3/home/jacobg/xeno-unstable.bk/xen/common/common.o(.text+0x1b9c): In function `do_boot_vcpu'': : undefined reference to `arch_final_setup_guestos'' /mnt/hda3/home/jacobg/xeno-unstable.bk/xen/common/common.o(.text+0x1c15): In function `do_boot_vcpu'': : undefined reference to `arch_free_exec_domain_struct'' /mnt/hda3/home/jacobg/xeno-unstable.bk/xen/common/common.o(.text+0x1d73): In function `domain_kill'': : undefined reference to `domain_relinquish_memory'' /mnt/hda3/home/jacobg/xeno-unstable.bk/xen/common/common.o(.text+0x1e79): In function `domain_shutdown'': : undefined reference to `machine_halt'' /mnt/hda3/home/jacobg/xeno-unstable.bk/xen/common/common.o(.text+0x1ed4): In function `domain_shutdown'': : undefined reference to `machine_restart'' /mnt/hda3/home/jacobg/xeno-unstable.bk/xen/common/common.o(.text+0x1f3a): In function `alloc_new_dom_mem'': : undefined reference to `domain_relinquish_memory'' /mnt/hda3/home/jacobg/xeno-unstable.bk/xen/common/common.o(.text+0x1fc5): In function `final_setup_guestos'': : undefined reference to `arch_final_setup_guestos'' /mnt/hda3/home/jacobg/xeno-unstable.bk/xen/common/common.o(.text+0x3b79): In function `do_task_queues'': : undefined reference to `dump_pageframe_info'' /mnt/hda3/home/jacobg/xeno-unstable.bk/xen/common/common.o(.text+0x3fd2): In function `halt_machine'': : undefined reference to `machine_restart'' /mnt/hda3/home/jacobg/xeno-unstable.bk/xen/common/common.o(.text+0x4930): In function `do_multicall'': : undefined reference to `hypercall_create_continuation'' /mnt/hda3/home/jacobg/xeno-unstable.bk/xen/common/common.o(.text+0x7770): In function `alloc_exec_domain_struct'': : undefined reference to `arch_alloc_exec_domain_struct'' /mnt/hda3/home/jacobg/xeno-unstable.bk/xen/common/common.o(.text+0x7838): In function `alloc_exec_domain_struct'': : undefined reference to `arch_free_exec_domain_struct'' /mnt/hda3/home/jacobg/xeno-unstable.bk/xen/common/common.o(.text+0x79e0): In function `__enter_scheduler'': : undefined reference to `switch_to'' /mnt/hda3/home/jacobg/xeno-unstable.bk/xen/common/common.o(.text+0x7bb4): In function `free_domain_struct'': : undefined reference to `arch_free_exec_domain_struct'' /mnt/hda3/home/jacobg/xeno-unstable.bk/xen/common/common.o(.text+0x7bec): In function `alloc_domain_struct'': : undefined reference to `arch_alloc_domain_struct'' /mnt/hda3/home/jacobg/xeno-unstable.bk/xen/common/common.o(.text+0x7c29): In function `alloc_domain_struct'': : undefined reference to `arch_free_domain_struct'' /mnt/hda3/home/jacobg/xeno-unstable.bk/xen/common/common.o(.text+0x7bc7): In function `free_domain_struct'': : undefined reference to `arch_free_domain_struct'' /mnt/hda3/home/jacobg/xeno-unstable.bk/xen/drivers/char/driver.o(.text+0x100a): In function `panic'': : undefined reference to `machine_restart'' /mnt/hda3/home/jacobg/xeno-unstable.bk/xen/arch/x86/arch.o(.text+0x761): In function `arch_do_dom0_op'': : undefined reference to `do_iopl'' /mnt/hda3/home/jacobg/xeno-unstable.bk/xen/arch/x86/arch.o(.text+0x5958): In function `do_mmu_update'': : undefined reference to `hypercall_create_continuation'' /mnt/hda3/home/jacobg/xeno-unstable.bk/xen/arch/x86/arch.o(.text+0xe60b): In function `do_set_trap_table'': : undefined reference to `hypercall_create_continuation'' /mnt/hda3/home/jacobg/xeno-unstable.bk/xen/arch/x86/arch.o(.text+0x10341): In function `vmx_do_page_fault'': : undefined reference to `handle_mmio'' /mnt/hda3/home/jacobg/xeno-unstable.bk/xen/arch/x86/arch.o(.text+0x11d02): In function `vmx_do_launch'': : undefined reference to `arch_vmx_do_resume'' /mnt/hda3/home/jacobg/xeno-unstable.bk/xen/arch/x86/arch.o(.text+0x13166): In function `construct_dom0'': : undefined reference to `new_thread'' /mnt/hda3/home/jacobg/xeno-unstable.bk/xen/arch/x86/arch.o(.text.init+0x64e5): In function `__start_xen'': : undefined reference to `startup_cpu_idle_loop'' /mnt/hda3/home/jacobg/xeno-unstable.bk/xen/arch/x86/arch.o(.text.init+0x6967): In function `start_of_day'': : undefined reference to `arch_do_createdomain'' /mnt/hda3/home/jacobg/xeno-unstable.bk/xen/arch/x86/arch.o(.text.init+0x71a3): In function `start_secondary'': : undefined reference to `startup_cpu_idle_loop'' make[1]: *** [/mnt/hda3/home/jacobg/xeno-unstable.bk/xen/xen-syms] Error 1 make[1]: Leaving directory `/mnt/hda3/home/jacobg/xeno-unstable.bk/xen/arch/x86'' make: *** [/mnt/hda3/home/jacobg/xeno-unstable.bk/xen/xen] Error 2 /Jacob ------------------------------------------------------- This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting Tool for open source databases. Create drag-&-drop reports. Save time by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc. Download a FREE copy at http://www.intelliview.com/go/osdn_nl _______________________________________________ Xen-devel mailing list Xen-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xen-devel
Jacob Gorm Hansen
2005-Feb-05 02:18 UTC
Re: [Xen-devel] [Xen-changelog] 1. Deleted slab.c, added xmalloc.c. Do not rename header or remove
Jacob Gorm Hansen wrote:> Alex Ho wrote: > >> just delete xen/common/slab.c >> .a > > > I am getting a bunch of linker errors with the latest bkbits version: >never mind, a couple of rounds of unpull & pulls and a few make cleans sorted it. Jacob ------------------------------------------------------- This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting Tool for open source databases. Create drag-&-drop reports. Save time by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc. Download a FREE copy at http://www.intelliview.com/go/osdn_nl _______________________________________________ Xen-devel mailing list Xen-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xen-devel