Xen devel - Dec 2004 - PATCH: fix compiler warning on noirqdebug_setup

CC      arch/xen/i386/kernel/irq.o
arch/xen/i386/kernel/irq.c:276: warning: static declaration of
''noirqdebug_setup'' follows non-static declaration
include/asm/irq.h:64: warning: previous declaration of
''noirqdebug_setup'' was here

Apparently this function might even be called from drivers/pci/quirks.c.

--- linux-2.6.9/arch/xen/i386/kernel/irq.c.warn	2004-12-08 12:49:19.104521386
-0500
+++ linux-2.6.9/arch/xen/i386/kernel/irq.c	2004-12-08 12:49:29.115934054 -0500
@@ -272,7 +272,7 @@

  static int noirqdebug;

-static int __init noirqdebug_setup(char *str)
+int __init noirqdebug_setup(char *str)
  {
  	noirqdebug = 1;
  	printk("IRQ lockup detection disabled\n");


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xen-devel

On Wed, Dec 08, 2004 at 12:52:37PM -0500, Rik van Riel
wrote:
>   CC      arch/xen/i386/kernel/irq.o
> arch/xen/i386/kernel/irq.c:276: warning: static declaration of 
> ''noirqdebug_setup'' follows non-static declaration
> include/asm/irq.h:64: warning: previous declaration of
''noirqdebug_setup''
> was here
I don''t see this warning when building from a clean xen-2.0 tree,
there is no prototype for noirqdebug_setup in include/asm/irq.h.

    christian



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xen-devel

On Wed, 8 Dec 2004, Christian Limpach wrote:
> On Wed, Dec 08, 2004 at 12:52:37PM -0500, Rik van Riel wrote:
>>   CC      arch/xen/i386/kernel/irq.o
>> arch/xen/i386/kernel/irq.c:276: warning: static declaration of
>> ''noirqdebug_setup'' follows non-static declaration
>> include/asm/irq.h:64: warning: previous declaration of
''noirqdebug_setup''
>> was here
>
> I don''t see this warning when building from a clean xen-2.0 tree,
> there is no prototype for noirqdebug_setup in include/asm/irq.h.
Arghhh.  I forgot about linux-2.6.9-irqaffinity-disable-E7xxx.patch
in rawhide.  Never mind me...

-- 
"Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it." - Brian W. Kernighan


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xen-devel