search for: nouveau_bio

...ected directly to any outputs. Reporting an error in this scenario is too harsh. Accordingly, change the error message to an info message. By default the error message also causes a boot flicker for these sytems. Signed-off-by: Rhys Kidd <rhyskidd at gmail.com> --- drivers/gpu/drm/nouveau/nouveau_bios.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c index 66bf2aff4a3e..bdfadc63204a 100644 --- a/drivers/gpu/drm/nouveau/nouveau_bios.c +++ b/drivers/gpu/drm/nouveau/nouveau_bios.c @@ -935,7 +935,7 @...

...age (NVD7, for example) This commit changes the warning into an informational message. The return value of the function is not used, so I left it at -EINVAL. Signed-off-by: Albert Pool <albertpool at solcon.nl> Cc: Emil Velikov <emil.l.velikov at gmail.com> --- drivers/gpu/drm/nouveau/nouveau_bios.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c index 3e72876..7681b01 100644 --- a/drivers/gpu/drm/nouveau/nouveau_bios.c +++ b/drivers/gpu/drm/nouveau/nouveau_bios.c @@ -936,7 +936,8 @@ sta...

...ch shows that this error is prevalent with mobile Nvidia GPUs. Since we can assume mobile parts have no fp table, demote the error to desktop cards. Also reword the comment since the error is not restricted to Apple hardware. Signed-off by: Rosen Penev <rosenp at gmail.com> --- drm/nouveau/nouveau_bios.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drm/nouveau/nouveau_bios.c b/drm/nouveau/nouveau_bios.c index b998c33a..7c17878d 100644 --- a/drm/nouveau/nouveau_bios.c +++ b/drm/nouveau/nouveau_bios.c @@ -351,11 +351,11 @@ static int parse_fp_mode_table(struct drm...

Hi, questions will follow. --- diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c index 99f7bd4..13b3fb1 100644 --- a/drivers/gpu/drm/nouveau/nouveau_bios.c +++ b/drivers/gpu/drm/nouveau/nouveau_bios.c @@ -40,8 +40,6 @@ #define BIOSLOG(sip, fmt, arg...) NV_DEBUG(sip->dev, fmt, ##arg) #define LOG_OLD_VALUE(x) //x -#define BIOS_US...

...l > > * Doing dma on the stack > http://lkml.indiana.edu/hypermail/linux/kernel/1001.3/01231.html > > * Dereferencing variables before verifying they are not null > http://lkml.indiana.edu/hypermail/linux/kernel/1001.3/01980.html > > (...) > drivers/gpu/drm/nouveau/nouveau_bios.c +770 get_tmds_index_reg(36) error: buffer overflow 'pramdac_table' 4 <= 4 > (...) --- From: Marcin Slusarz <marcin.slusarz at gmail.com> Subject: [PATCH] drm/nouveau: fix pramdac_table range checking get_tmds_index_reg reads some value from stack when mlv happens to be equa...

The nv31m in bug 23212 claims its TV-out and LVDS are in the same connector. Ignore it completely as it's otherwise useless. Signed-off-by: Francisco Jerez <currojerez at riseup.net> --- drivers/gpu/drm/nouveau/nouveau_bios.c | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c index 195ecb3..01ef97e 100644 --- a/drivers/gpu/drm/nouveau/nouveau_bios.c +++ b/drivers/gpu/drm/nouveau/nouveau_bios.c @@ -5259,6 +...

It looks like Ryan's Nouveau patch [1,2] to get the I2C working for EDID (thus modelines) is crucial for avoiding the Nvidia binary drivers on MacbookPro 2012s. Any plans/chance for it to be upstreamed to eg 3.6-rc3? Many thanks, Daniel --- [1] diff -urNp a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c --- a/drivers/gpu/drm/nouveau/nouveau_bios.c 2012-07-08 22:48:05.589828510 -0500 +++ b/drivers/gpu/drm/nouveau/nouveau_bios.c 2012-07-15 00:28:18.578864693 -0500 @@ -6461,6 +6461,9 @@ nouveau_run_vbios_init(struct drm_device } } + if (!bios->exec...

The nouveau driver makes a number of unaligned accesses via the ROM16(), ROM32() and ROM64() macros which fault on SPARC (but would be transparently handled by x86 hardware). Making use of get_unaligned() macro fixes the problem for me. diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.h b/drivers/gpu/drm/nouveau/nouveau_bios.h index 7ccd28f..92031f6 100644 --- a/drivers/gpu/drm/nouveau/nouveau_bios.h +++ b/drivers/gpu/drm/nouveau/nouveau_bios.h @@ -26,6 +26,8 @@ #include "nvreg.h" +#include <asm/unaligned.h> + #define DCB_MAX_NUM_ENTRIES 16 #define DCB_MAX_...

...om: Colin Ian King <colin.king at canonical.com> Don't populate arrays hwsq_signature and edid_sig on the stack but instead make them static. Makes the object code smaller by over 190 bytes: Before: text data bss dec hex filename 35676 3312 64 39052 988c nouveau_bios.o After: text data bss dec hex filename 35319 3472 64 38855 97c7 nouveau_bios.o (gcc version 7.2.0 x86_64) Signed-off-by: Colin Ian King <colin.king at canonical.com> --- drivers/gpu/drm/nouveau/nouveau_bios.c | 4 ++-- 1 file changed, 2 insertions(+), 2...

http://bugs.freedesktop.org/show_bug.cgi?id=25938 Summary: black screen on the iMac powerpc using nouveau Product: xorg Version: unspecified Platform: PowerPC OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: Driver/nouveau AssignedTo: nouveau at lists.freedesktop.org

...ays number 2 in the list on <g80 - I'm not sure about later cards yet. There's still a lot of work to be done in parsing the temperature tables, so if anyone's got any hints there, that'd be great. --- drivers/gpu/drm/nouveau/Makefile | 1 + drivers/gpu/drm/nouveau/nouveau_bios.c | 64 +++++++++- drivers/gpu/drm/nouveau/nouveau_bios.h | 10 ++ drivers/gpu/drm/nouveau/nouveau_drv.h | 3 + drivers/gpu/drm/nouveau/nouveau_reg.h | 1 + drivers/gpu/drm/nouveau/nouveau_state.c | 9 +- drivers/gpu/drm/nouveau/nouveau_thermal.c | 218 +++++++++++++++...

...82] nouveau 0000:00:0d.0: DRM: DCB outp 00: 01000310 00000023 [ 8.015385] nouveau 0000:00:0d.0: DRM: DCB outp 01: 00110204 98830003 [ 8.015386] ================================================================================ [ 8.015423] UBSAN: Undefined behaviour in drivers/gpu/drm/nouveau/nouveau_bios.c:1528:8 [ 8.015455] shift exponent -1 is negative [ 8.015482] CPU: 1 PID: 148 Comm: systemd-udevd Not tainted 4.16.0-rc3-00167-g97ace515f014 #1 [ 8.015483] Hardware name: HP-Pavilion RT589AA-ABU t3709.uk/Nance, BIOS 5.02 11/26/2006 [ 8.015485] Call Trace: [ 8.015496] dump_stack+0x...

...+++++++----- > drivers/gpu/drm/nouveau/dispnv04/disp.h | 14 ++++++++------ > drivers/gpu/drm/nouveau/dispnv04/hw.c | 10 ++++++---- > drivers/gpu/drm/nouveau/nouveau_abi16.c | 7 ++++--- > drivers/gpu/drm/nouveau/nouveau_acpi.c | 2 +- > drivers/gpu/drm/nouveau/nouveau_bios.c | 11 ++++++++--- > drivers/gpu/drm/nouveau/nouveau_connector.c | 10 ++++++---- > drivers/gpu/drm/nouveau/nouveau_drm.c | 5 ++--- > drivers/gpu/drm/nouveau/nouveau_fbcon.c | 6 ++++-- > drivers/gpu/drm/nouveau/nouveau_vga.c | 20 ++++++++++++-------- > 10...

Remove unused vairable, return 0 explicitly. Signed-off-by: Muhammad Falak R Wani <falakreyaz at gmail.com> --- drivers/gpu/drm/nouveau/nouveau_bios.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c index 4dca65a..5449838 100644 --- a/drivers/gpu/drm/nouveau/nouveau_bios.c +++ b/drivers/gpu/drm/nouveau/nouveau_bios.c @@ -2039,7 +2039,6 @@ nouv...

This can show up on SPARC or other architectures that don't handle unaligned accesses. The kernel normally fixes these up, but it shouldn't have to. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96836 Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu> --- drm/nouveau/nouveau_bios.h | 6 ++---- drm/nouveau/nvkm/subdev/mxm/mxms.c | 4 ++-- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drm/nouveau/nouveau_bios.h b/drm/nouveau/nouveau_bios.h index 0067586..18eb061 100644 --- a/drm/nouveau/nouveau_bios.h +++ b/drm/nouveau/nouveau_bios.h @@ -31,10 +31,8...

The Lenono P70's HDMI connector is listed twice, both as DP and as DVI connector. Ignore the DVI entry, making all ports show up as DP ports, like on the non-broken P50 model. Signed-off-by: Hans de Goede <hdegoede at redhat.com> --- drivers/gpu/drm/nouveau/nouveau_bios.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c index 23ffe85..ef2e6fd 100644 --- a/drivers/gpu/drm/nouveau/nouveau_bios.c +++ b/drivers/gpu/drm/nouveau/nouveau_bios.c @@ -1746,6 +1746,17 @@ apply_dc...

This warning seems to pop up mainly in laptop cards. Silence it as it is expected behavior. Signed-off by: Rosen Penev <rosenp at gmail.com> --- drm/nouveau/nouveau_bios.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drm/nouveau/nouveau_bios.c b/drm/nouveau/nouveau_bios.c index b998c33a..dd6fba55 100644 --- a/drm/nouveau/nouveau_bios.c +++ b/drm/nouveau/nouveau_bios.c @@ -351,11 +351,8 @@ static int parse_fp_mode_table(struct drm_devi...

...already done in dcb.c inside nvkm, but the other parser did not get the update. Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu> --- Entirely untested. Why do we have two DCB parsers again? Also the other one sets link_bw to a totally different set of units for link_bw... drm/nouveau/nouveau_bios.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drm/nouveau/nouveau_bios.c b/drm/nouveau/nouveau_bios.c index dd6fba55..c4ef3a0a 100644 --- a/drm/nouveau/nouveau_bios.c +++ b/drm/nouveau/nouveau_bios.c @@ -1478,9 +1478,13 @@ parse_dcb20_entry(struct drm_device *dev, stru...

This function doesn't exist Signed-off-by: Lyude Paul <lyude at redhat.com> --- drivers/gpu/drm/nouveau/nouveau_bios.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.h b/drivers/gpu/drm/nouveau/nouveau_bios.h index 18eb061ccafb..5495f004a297 100644 --- a/drivers/gpu/drm/nouveau/nouveau_bios.h +++ b/drivers/gpu/drm/nouveau/nouveau_bios.h @@ -163,8 +163,6 @@ u8 *olddcb_co...

...ubsequent MMIO writes and eventually end with a lockup. Note that all the BIOSes I've seen do the same as we did (it works for them because they don't use MMIO), OTOH the blob leaves FW untouched. Signed-off-by: Francisco Jerez <currojerez at riseup.net> --- drivers/gpu/drm/nouveau/nouveau_bios.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c index ee36f8f..903e72b 100644 --- a/drivers/gpu/drm/nouveau/nouveau_bios.c +++ b/drivers/gpu/drm/nouveau/nouveau_bios.c @@ -2126,7 +2126,8 @@...