Nouveau - Jul 2017 - [PATCH] bios: Restrict missing fp table message to desktop cards.

A 2 minute google search shows that this error is prevalent with mobile Nvidia
GPUs. Since we can assume mobile parts have no fp table, demote the error to
desktop cards.

Also reword the comment since the error is not restricted to Apple hardware.

Signed-off by: Rosen Penev <rosenp at gmail.com>
---
 drm/nouveau/nouveau_bios.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drm/nouveau/nouveau_bios.c b/drm/nouveau/nouveau_bios.c
index b998c33a..7c17878d 100644
--- a/drm/nouveau/nouveau_bios.c
+++ b/drm/nouveau/nouveau_bios.c
@@ -351,11 +351,11 @@ static int parse_fp_mode_table(struct drm_device *dev,
struct nvbios *bios)
 	struct lvdstableheader lth;
 
 	if (bios->fp.fptablepointer == 0x0) {
-		/* Apple cards don't have the fp table; the laptops use DDC */
-		/* The table is also missing on some x86 IGPs */
-#ifndef __powerpc__
-		NV_ERROR(drm, "Pointer to flat panel table invalid\n");
-#endif
+		if (!bios->is_mobile) {
+			/* Most laptop cards lack an fp table. They use DDC.*/
+			NV_ERROR(drm, "Pointer to flat panel table invalid\n");
+		}
+
 		bios->digital_min_front_porch = 0x4b;
 		return 0;
 	}
-- 
2.13.3

On 07/25/2017 12:39 PM, Rosen Penev wrote:
> A 2 minute google search shows that this error is prevalent with mobile
Nvidia
> GPUs. Since we can assume mobile parts have no fp table, demote the error
to
> desktop cards.
> 
> Also reword the comment since the error is not restricted to Apple
hardware.
Thanks for the patch.  Dealing with this is something that I've thought
about on and off for a while, but never done.

Instead of making it conditional, I'd suggest instead just removing it
completely, or silencing it with NV_DEBUG instead of NV_ERROR.

Ben.
> 
> Signed-off by: Rosen Penev <rosenp at gmail.com>
> ---
>  drm/nouveau/nouveau_bios.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drm/nouveau/nouveau_bios.c b/drm/nouveau/nouveau_bios.c
> index b998c33a..7c17878d 100644
> --- a/drm/nouveau/nouveau_bios.c
> +++ b/drm/nouveau/nouveau_bios.c
> @@ -351,11 +351,11 @@ static int parse_fp_mode_table(struct drm_device
*dev, struct nvbios *bios)
>  	struct lvdstableheader lth;
>  
>  	if (bios->fp.fptablepointer == 0x0) {
> -		/* Apple cards don't have the fp table; the laptops use DDC */
> -		/* The table is also missing on some x86 IGPs */
> -#ifndef __powerpc__
> -		NV_ERROR(drm, "Pointer to flat panel table invalid\n");
> -#endif
> +		if (!bios->is_mobile) {
> +			/* Most laptop cards lack an fp table. They use DDC.*/
> +			NV_ERROR(drm, "Pointer to flat panel table invalid\n");
> +		}
> +
>  		bios->digital_min_front_porch = 0x4b;
>  		return 0;
>  	}
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20170725/e7f51de8/attachment.sig>