Nouveau - Jan 2010 - [Bug 25938] New: black screen on the iMac powerpc using nouveau

http://bugs.freedesktop.org/show_bug.cgi?id=25938

           Summary: black screen on the iMac powerpc using nouveau
           Product: xorg
           Version: unspecified
          Platform: PowerPC
        OS/Version: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Driver/nouveau
        AssignedTo: nouveau at lists.freedesktop.org
        ReportedBy: tacconet at libero.it
         QAContact: xorg-team at lists.x.org


Created an attachment (id=32501)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=32501)
some logs from xorg and dmesg

The screen remains black when nouveau drivers are enabled, both the X server
and console.
Wrong TV-out detection, there is no cable attached but is recognized TV output.
On my Imac there is only mini-VGA connector that can function as a VGA output
or TV output.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=25938





--- Comment #1 from Andrea Tacconi <tacconet at libero.it>  2010-01-13
02:45:19 PST ---
Created an attachment (id=32608)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=32608)
dmesg TV-1 on

dmesg TV-1 on.
Wrong load detection and framebuffer console resolution switch to 720x576


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=25938





--- Comment #2 from Andrea Tacconi <tacconet at libero.it>  2010-01-13
02:46:49 PST ---
the problem of black screen seems to be resolved adding the following patch:
Adding nv18 card identifier to Powerbook specific quirks
in nouveau kernel module:
diff nouveau_bios.c.old nouveau_bios.c
3199c3199
<       if (script == LVDS_RESET && ((dev->pci_device &
0xffff) == 0x0179 ||
(dev->pci_device & 0xffff) == 0x0329))
---
> 	if (script == LVDS_RESET && ((dev->pci_device & 0xffff) ==
0x0179 ||(dev->pci_device & 0xffff) == 0x0189 || (dev->pci_device
& 0xffff) == 0x0329))
same as in xorg driver:

diff nv_bios.c.old nv_bios.c
2592c2592
<       if (script == LVDS_RESET && ((pNv->Chipset & 0xffff)
== 0x0179 ||
(pNv->Chipset & 0xffff) == 0x0329))
---
> 	if (script == LVDS_RESET && ((pNv->Chipset & 0xffff) ==
0x0179 ||(pNv->Chipset & 0xffff) == 0x0189 || (pNv->Chipset &
0xffff) == 0x0329))
Now both framebuffer console and Xorg work.

But there is another problem with TV-out:
When turned on the TV output is in contrast with the LVDS output and set the
screen resolution of 720x576 on the console framebuffer.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=25938





--- Comment #3 from Andrea Tacconi <tacconet at libero.it>  2010-01-13
02:50:54 PST ---
Created an attachment (id=32609)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=32609)
dmesg tv1 off

When TV-1 output was off, the screen resolution of framebuffer console was
1024x768 an the system works fine


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=25938





--- Comment #4 from Andrea Tacconi <tacconet at libero.it>  2010-01-13
03:05:55 PST ---

http://bugs.freedesktop.org/show_bug.cgi?id=25938





--- Comment #5 from Francisco Jerez <currojerez at riseup.net>  2010-01-13
06:50:31 PST ---
(In reply to comment #2)
> the problem of black screen seems to be resolved adding the following
patch:
> Adding nv18 card identifier to Powerbook specific quirks
> in nouveau kernel module:
> diff nouveau_bios.c.old nouveau_bios.c
> 3199c3199
> <       if (script == LVDS_RESET && ((dev->pci_device &
0xffff) == 0x0179 ||
> (dev->pci_device & 0xffff) == 0x0329))
> ---
> >       if (script == LVDS_RESET && ((dev->pci_device &
0xffff) == 0x0179 ||(dev->pci_device & 0xffff) == 0x0189 ||
(dev->pci_device & 0xffff) == 0x0329))
> 
Would you mind sending a properly formatted, Signed-off-by patch with this to
the ML? (You might want to read Documentation/SubmittingPatches in the kernel
tree first).
> same as in xorg driver:
> 
> diff nv_bios.c.old nv_bios.c
> 2592c2592
> <       if (script == LVDS_RESET && ((pNv->Chipset &
0xffff) == 0x0179 ||
> (pNv->Chipset & 0xffff) == 0x0329))
> ---
> >       if (script == LVDS_RESET && ((pNv->Chipset &
0xffff) == 0x0179 ||(pNv->Chipset & 0xffff) == 0x0189 || (pNv->Chipset
& 0xffff) == 0x0329))
> 
No need to do this anymore, this code has just been nuked.
> Now both framebuffer console and Xorg work.
> 
> But there is another problem with TV-out:
> When turned on the TV output is in contrast with the LVDS output and set
the
> screen resolution of 720x576 on the console framebuffer.
> 
These integrated apple connectors aren't really supported yet, an mmiotrace
from the blob would be useful (See [1] or the docs in the kernel tree for
instructions).

[1] http://nouveau.freedesktop.org/wiki/MmioTrace


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=25938





--- Comment #6 from Andrea Tacconi <tacconet at libero.it>  2010-01-14
01:51:42 PST ---
From: Andrea Tacconi <tacconet at libero.it>

Subject: [PATCH] drm/nouveau: add NV18 device id to
call_lvds_manufacturer_script 

This fixes imac black screen (NV18 card)  

Signed-off-by: Andrea Tacconi <tacconet at libero.it>
---
diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c
b/drivers/gpu/drm/nouveau/nouveau_bios.c
index ba14397..e24f2a8 100644
--- a/drivers/gpu/drm/nouveau/nouveau_bios.c
+++ b/drivers/gpu/drm/nouveau/nouveau_bios.c
@@ -3196,7 +3196,7 @@ static int call_lvds_manufacturer_script(struct
drm_device *dev, struct dcb_entr
        }
 #ifdef __powerpc__
        /* Powerbook specific quirks */
-       if (script == LVDS_RESET && ((dev->pci_device & 0xffff)
== 0x0179 ||
(dev->pci_device & 0xffff) == 0x0329))
+       if (script == LVDS_RESET && ((dev->pci_device & 0xffff)
== 0x0179 ||
(dev->pci_device & 0xffff) == 0x0189 || (dev->pci_device & 0xffff)
== 0x0329))
                nv_write_tmds(dev, dcbent->or, 0, 0x02, 0x72);
        if ((dev->pci_device & 0xffff) == 0x0179 || (dev->pci_device
& 0xffff)
== 0x0189 || (dev->pci_device & 0xffff) == 0x0329) {
                if (script == LVDS_PANEL_ON) {


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=25938





--- Comment #7 from Francisco Jerez <currojerez at riseup.net>  2010-01-14
06:13:11 PST ---
(In reply to comment #6)
> From: Andrea Tacconi <tacconet at libero.it>
> 
> Subject: [PATCH] drm/nouveau: add NV18 device id to
> call_lvds_manufacturer_script 
> 
> This fixes imac black screen (NV18 card)  
> 
> Signed-off-by: Andrea Tacconi <tacconet at libero.it>
> ---
> diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c
> b/drivers/gpu/drm/nouveau/nouveau_bios.c
> index ba14397..e24f2a8 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_bios.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_bios.c
> @@ -3196,7 +3196,7 @@ static int call_lvds_manufacturer_script(struct
> drm_device *dev, struct dcb_entr
>         }
>  #ifdef __powerpc__
>         /* Powerbook specific quirks */
> -       if (script == LVDS_RESET && ((dev->pci_device &
0xffff) == 0x0179 ||
> (dev->pci_device & 0xffff) == 0x0329))
> +       if (script == LVDS_RESET && ((dev->pci_device &
0xffff) == 0x0179 ||
> (dev->pci_device & 0xffff) == 0x0189 || (dev->pci_device &
0xffff) == 0x0329))
>                 nv_write_tmds(dev, dcbent->or, 0, 0x02, 0x72);
>         if ((dev->pci_device & 0xffff) == 0x0179 ||
(dev->pci_device & 0xffff)
> == 0x0189 || (dev->pci_device & 0xffff) == 0x0329) {
>                 if (script == LVDS_PANEL_ON) {
> 
Thanks, pushed, but please, next time you send a patch use the mailing list,
bugzilla adds some gratuitous line breaks and I had to do it manually.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=25938





--- Comment #8 from Andrea Tacconi <tacconet at libero.it>  2010-01-15
00:55:14 PST ---
Created an attachment (id=32652)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=32652)
patch bzip2

(In reply to comment #7)
> 
> Thanks, pushed, but please, next time you send a patch use the mailing
list,
> bugzilla adds some gratuitous line breaks and I had to do it manually.
> 
I'm Sorry but I didn't know this.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=25938


Andrea Tacconi <tacconet at libero.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32652|0                           |1
        is obsolete|                            |




--- Comment #9 from Andrea Tacconi <tacconet at libero.it>  2010-01-15
00:58:36 PST ---
Created an attachment (id=32653)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=32653)
patch bzip2

damn another mistake...


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=25938

Marcin Slusarz <marcin.slusarz at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #10 from Marcin Slusarz <marcin.slusarz at gmail.com>
2011-03-07 10:48:17 PST ---
Patch was commited, so I'm closing this bug report as FIXED.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.