samba - Jun 2024 - missing msdfs referrals from samba directory listing: wrong order in smbd_dirptr_get_entry()?

07.06.2024 07:54, Jeremy Allison wrote:
>> msdfs is broken in 4.19.? It worked fine in 4.18.
This is not entirely true.
>> Is no one using msdfs?? I wonder why I was the first to discover this?
> 
> There must not be a test for your specific use-case.
> 
> MSDFS is tested in the autobuild test suite. Can
> you articulate the problem well enough we can
> build a regression test for it, and then we
> can ensure it never gets broken for this case
> again.
I hoped this is obvious even from the subject line :)

with 4.19, msdfs reparse points are missing from the directory *listing*
from samba.  When specifying the msdfs name directly, samba uses it fine -
and this is covered by the tests.  But there's no test which checks the
msdfs entry in the file *listing* generated by samba.

With my question above - "is no one using msdfs?" - I'm not sure
it is
worth the effort to actually fix this for 4.19.  Maybe it is if the fix
would be simple.

Thanks,

/mjt
-- 
GPG Key transition (from rsa2048 to rsa4096) since 2024-04-24.
New key: rsa4096/61AD3D98ECDF2C8E  9D8B E14E 3F2A 9DD7 9199  28F1 61AD 3D98 ECDF
2C8E
Old key: rsa2048/457CE0A0804465C5  6EE1 95D1 886E 8FFB 810D  4324 457C E0A0 8044
65C5
Transition statement: http://www.corpit.ru/mjt/gpg-transition-2024.txt

07.06.2024 07:59, Michael Tokarev wrote:
> 07.06.2024 07:54, Jeremy Allison wrote:
>>> msdfs is broken in 4.19.? It worked fine in 4.18.
> 
> This is not entirely true.
Nope. Things are more interesting than that.

I've a 4.19 installation where msdfs links works both in listing
and when specified directly. There are 2 other installations of 4.19
where msdfs links doesn't work neither in listing nor when used directly.
And there was another install of 4.19 where msdfs isn't shown in dir
listing but works when specified directly - I upgraded this one to
4.20 today which fixed the issue there.  When direct access to msdfs
link doesn't work, windows report "file does not exist" error.

I can't see what's the actual difference, trying to debug it further.
At least 2 of these installs are identically configured member servers
of the same domain - one which I upgraded to 4.20 and another where
msdfs links doesn't work neither in listing nor directly (yesterday
it was both 4.19 but on one of them, direct access to msdfs links
worked while on another, reported as non-existing file).

Thanks,

/mjt--
GPG Key transition (from rsa2048 to rsa4096) since 2024-04-24.
New key: rsa4096/61AD3D98ECDF2C8E  9D8B E14E 3F2A 9DD7 9199  28F1 61AD 3D98 ECDF
2C8E
Old key: rsa2048/457CE0A0804465C5  6EE1 95D1 886E 8FFB 810D  4324 457C E0A0 8044
65C5
Transition statement: http://www.corpit.ru/mjt/gpg-transition-2024.txt

On 07-06-2024 06:59, Michael Tokarev via samba wrote:
> 07.06.2024 07:54, Jeremy Allison wrote:
>>> msdfs is broken in 4.19.? It worked fine in 4.18.
>
> This is not entirely true.
>
>>> Is no one using msdfs?? I wonder why I was the first to discover
this?
>>
>> There must not be a test for your specific use-case.
>>
>> MSDFS is tested in the autobuild test suite. Can
>> you articulate the problem well enough we can
>> build a regression test for it, and then we
>> can ensure it never gets broken for this case
>> again.
>
> I hoped this is obvious even from the subject line :)
>
> with 4.19, msdfs reparse points are missing from the directory *listing*
> from samba.? When specifying the msdfs name directly, samba uses it 
> fine -
> and this is covered by the tests.? But there's no test which checks the
> msdfs entry in the file *listing* generated by samba.
>
> With my question above - "is no one using msdfs?" - I'm not
sure it is
> worth the effort to actually fix this for 4.19.? Maybe it is if the fix
> would be simple.
I am using msdfs, but I haven't run into issues (or I did not notice 
them yet) with 4.19.

There is a little difference with your config: I am not using symlinks 
in the filesystem but 'msdfs proxy' in smb.conf.? Not sure if that can 
be related to your finding?

- Kees.
>
> Thanks,
>
> /mjt