samba - Jun 2024 - missing msdfs referrals from samba directory listing: wrong order in smbd_dirptr_get_entry()?

On Fri, Jun 07, 2024 at 07:16:06AM +0300, Michael Tokarev via samba
wrote:
>06.06.2024 19:33, Michael Tokarev via samba wrote:
>
>>For quite some time I'm trying to find what's going on with
MSDFS referrals.
>>Samba version is 4.19.6.
>..
>>However, when opening the directory in question from client, this name
is not
>>shown in the listing.? Samba skips this name from the listing when
looping over
>>readdir entries:
>
>So, the same config just works in samba-4.20.  There has been a quite few
changes in
>this area in 4.20, but the order of checks in smbd_dirptr_get_entry()
didn't actually
>change (but the code is different), -- looks like the change happened in
smbd_dirptr_get_entry
>itself.
>
>msdfs is broken in 4.19.  It worked fine in 4.18.
>
>Is no one using msdfs?  I wonder why I was the first to discover this?
There must not be a test for your specific use-case.

MSDFS is tested in the autobuild test suite. Can
you articulate the problem well enough we can
build a regression test for it, and then we
can ensure it never gets broken for this case
again.

Sorry for the trouble.

Jeremy.

07.06.2024 07:54, Jeremy Allison wrote:
>> msdfs is broken in 4.19.? It worked fine in 4.18.
This is not entirely true.
>> Is no one using msdfs?? I wonder why I was the first to discover this?
> 
> There must not be a test for your specific use-case.
> 
> MSDFS is tested in the autobuild test suite. Can
> you articulate the problem well enough we can
> build a regression test for it, and then we
> can ensure it never gets broken for this case
> again.
I hoped this is obvious even from the subject line :)

with 4.19, msdfs reparse points are missing from the directory *listing*
from samba.  When specifying the msdfs name directly, samba uses it fine -
and this is covered by the tests.  But there's no test which checks the
msdfs entry in the file *listing* generated by samba.

With my question above - "is no one using msdfs?" - I'm not sure
it is
worth the effort to actually fix this for 4.19.  Maybe it is if the fix
would be simple.

Thanks,

/mjt
-- 
GPG Key transition (from rsa2048 to rsa4096) since 2024-04-24.
New key: rsa4096/61AD3D98ECDF2C8E  9D8B E14E 3F2A 9DD7 9199  28F1 61AD 3D98 ECDF
2C8E
Old key: rsa2048/457CE0A0804465C5  6EE1 95D1 886E 8FFB 810D  4324 457C E0A0 8044
65C5
Transition statement: http://www.corpit.ru/mjt/gpg-transition-2024.txt