On 7/28/2016 3:44 PM, Marc Muehlfeld wrote:> Am 28.07.2016 um 20:44 schrieb Marc Muehlfeld: >> Am 28.07.2016 um 17:32 schrieb Marc Muehlfeld: >>> * Download the patch from the Bugzilla: >>> # wget -O /tmp/BZ11520.patch >>> https://bugzilla.samba.org/attachment.cgi?id=1219 >>> >>> * Change into the root of your Samba sources directory: >>> # cd /usr/src/samba-4.4.4/ >>> >>> * Apply the patch to the sources: >>> # patch -p 1 < /tmp/BZ11520.patch >>> >>> * And the rest as usual: >>> # ./configure && make && make install >> >> >> I've added the steps to the Wiki: >> https://wiki.samba.org/index.php/Build_Samba_from_source#Upgrading_a_Self-compiled_Samba_Installation > > Ups, wrong link. :-) > > https://wiki.samba.org/index.php/Build_Samba_from_source#Applying_a_PatchMarc, I have additional questions on patches if you don't mind. Once a patch has been applied, is it necessary to reapply a patch when updating Samba? How does one confirm on know when a patch has been officially applied to a tar release, if not noted in the release notes? Thanks again. -- -James
Hi, Am 22.08.2016 um 15:23 schrieb lingpanda101--- via samba:> I have additional questions on patches if you don't mind. Once a > patch has been applied, is it necessary to reapply a patch when updating > Samba?This depents. If the patch is part of the next release, you download the tarball from the next release and that's it. Was the patch for some reason not included in the new release, you have to apply it to the sources of the new version again. However it can happen that it won't apply cleanly any more if the source code changed to much in the meantime.> How does one confirm on know when a patch has been officially > applied to a tar release, if not noted in the release notes? Thanks again.You can check the locations in the source code, the patch changes. If you look at the patch file, it tells you the name of the file(s) it changes and which lines are removed (-) or added (+). Are you asking because of a patch you're missing in a release? Regards, Marc
On 8/22/2016 9:55 AM, Marc Muehlfeld wrote:> > > Are you asking because of a patch you're missing in a release? > > > > Regards, > MarcNo. This is the first time I have applied a patch to Samba. Seeing as how I find this particular patch as critical for my environment, I didn't want to inadvertently break DNS updates on my next Samba update. This patch shows two attachments. One for 4.3 and one for 4.4 cherry picked from master. I take this as anytime someone updates 4.3 to a new revision, they must apply this patch unless it's stated in a release note. With respect to 4.4 cherry picked from master. I take this as any revision update to 4.4, one must apply this patch unless stated in the release notes. Going forward with 4.5 this patch is already included. A bit confusing for me and wanted clarity for my sake. Thanks. -- -James