samba - Feb 2013 - Upgrade from 4.0.0 to 4.0.3 creates unfixable errors with dbcheck

Hello,

Today I tried to upgrade from samba 4.0.0 to 4.0.3 on my test environment.

I patched the source with the diffs patch-4.0.0-4.0.1.diffs, 
patch-4.0.1-4.0.2.diffs, patch-4.0.2-4.0.3.diffs , then make, make install.

# samba-tool dbcheck
Checking 807 objects

Not fixing nTSecurityDescriptor on CN=Performance Monitor 
Users,CN=Builtin,DC=inview,DC=local              <--- all errors were 
same for each object


Checked 807 objects (805 errors)

Tried

# samba-tool dbcheck --fix

  (fix all.)

Checked 807 objects (763 errors)

now

# samba-tool dbcheck

Not fixing nTSecurityDescriptor on CN=Performance Monitor 
Users,CN=Builtin,DC=inview,DC=local              <--- all errors were 
same for each object

Checked 807 objects (650 errors)

Fixing again has no further effect on the number of errors.

It should be noted that before the upgrade dbcheck found no errors


So what has changed between the versions  to cause this and how can I 
fix these errors?

Cheers

Chris

On Thu, 2013-02-21 at 13:11 +0000, Chris Lewis wrote:
> Hello,
> 
> Today I tried to upgrade from samba 4.0.0 to 4.0.3 on my test environment.
> 
> I patched the source with the diffs patch-4.0.0-4.0.1.diffs, 
> patch-4.0.1-4.0.2.diffs, patch-4.0.2-4.0.3.diffs , then make, make install.
> 
> # samba-tool dbcheck
> Checking 807 objects
> 
> Not fixing nTSecurityDescriptor on CN=Performance Monitor 
> Users,CN=Builtin,DC=inview,DC=local              <--- all errors were 
> same for each object
> 
> 
> Checked 807 objects (805 errors)
> 
> Tried
> 
> # samba-tool dbcheck --fix
> 
>   (fix all.)
> 
> Checked 807 objects (763 errors)
> 
> now
> 
> # samba-tool dbcheck
> 
> Not fixing nTSecurityDescriptor on CN=Performance Monitor 
> Users,CN=Builtin,DC=inview,DC=local              <--- all errors were 
> same for each object
> 
> Checked 807 objects (650 errors)
> 
> Fixing again has no further effect on the number of errors.
> 
> It should be noted that before the upgrade dbcheck found no errors
> 
> 
> So what has changed between the versions  to cause this and how can I 
> fix these errors?
Please file a bug.  Clearly our heuristic to detect when we need to
rewrite these is faulty. 

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org

On Thu, Feb 21, 2013 at 8:11 AM, Chris Lewis <clewis at inview.co.uk>
wrote:
> Hello,
>
> Today I tried to upgrade from samba 4.0.0 to 4.0.3 on my test environment.
>
> I patched the source with the diffs patch-4.0.0-4.0.1.diffs,
> patch-4.0.1-4.0.2.diffs, patch-4.0.2-4.0.3.diffs , then make, make install.
I don't see a "make clean" in there, and it doesn't seem to be
available anymore with the new Python based build system.

Rather than compiling on top of your old code, which may not
completely detect dependencies on altered include files and force
rebuilding of new binaries, why don't you work from a fresh source
tree and build from scratch? This is especially important when the
build components themselves, such as that Python "waf" build tools,
may be modified by the udpates.