Jeff Layton
2012-May-30 10:37 UTC
[Samba] ANNOUNCE: cifs-utils release 5.5 is ready for download
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Nothing terribly earth-shattering in this release. We had a number of
reports of build-breaking problems in version 5.4, mostly due to the
fact that we now turn on -Werror by default, and a number of patches to
fix them.
I'm starting to have doubts as to whether it's a good idea to keep
- -Werror in the default CFLAGS. This is built in a large range of
environments and with a large range of different tool versions.
Catching all of the warnings can be difficult.
I've left that flag in place for now, but if it's causing significant
pain for anyone then please speak up, and we might remove it in a later
release.
Highlights:
* a bunch of fixes for compile time warnings and build breaks
* some fixes in the libcap capabilities dropping code
* remove unneeded mount.smb2 multicall code and other prep work for
smb2 support
* manpage updates for kernel-level behavior changes
webpage: https://wiki.samba.org/index.php/LinuxCIFS_utils
tarball: ftp://ftp.samba.org/pub/linux-cifs/cifs-utils/
git: git://git.samba.org/cifs-utils.git
gitweb: http://git.samba.org/?p=cifs-utils.git;a=summary
Detailed list of changes since 5.4:
commit 676f0386df51b36df42d8b6b815b7d9d8b6934dc
Author: Jeff Layton <jlayton at samba.org>
Date: Thu Apr 19 07:29:33 2012 -0400
autoconf: set version to 5.4.1 for interim builds
Signed-off-by: Jeff Layton <jlayton at samba.org>
commit 8c6268cbbd4202631e5c4b30297adc0088a1d568
Author: Jeff Layton <jlayton at samba.org>
Date: Thu Apr 19 07:29:46 2012 -0400
mount.cifs: fix up some -D_FORTIFY_SOURCE=2 warnings
...and add -D_FORTIFY_SOURCE=2 to the default $CFLAGS.
Acked-by: Acked-by: Suresh Jayaraman <sjayaraman at suse.com>
Signed-off-by: Jeff Layton <jlayton at samba.org>
commit be5b954e35858c09dfaeee33bf06bb0dc76a86f9
Author: Lars Mueller <lmuelle at suse.com>
Date: Fri Apr 20 07:58:54 2012 -0400
mount.cifs: uninitialized variables in mount.cifs
older gcc versions (4.3 in the case of SUSE Linux Enterprise 11 SP 1 and
SP 2) complain about uninitialized variables in the recent 5.4 release.
The attached patch makes the build process a bit quieter.
Acked-by: Suresh Jayaraman <sjayaraman at suse.com>
Signed-off-by: Lars Mueller <lmuelle at suse.com>
commit e5f124c10fa8e582c5df61017d6f6c2b10c397dc
Author: Lars Mueller <lmuelle at suse.com>
Date: Fri Apr 20 07:59:06 2012 -0400
cifs.upcall: missing prototype for krb5_auth_con_set_req_cksumtype in MIT
krb5 < 1.7
products coming with MIT krb5 < 1.7 (like SUSE Linux Enterprise 11 SP 1
or SP 2) suffer from the same issue as described by
https://bugzilla.samba.org/show_bug.cgi?id=6918
The declaration of krb5_auth_con_set_req_cksumtype is missing.
Inspiration: https://bugzilla.samba.org/show_bug.cgi?id=6918
Acked-by: Suresh Jayaraman <sjayaraman at suse.com>
Signed-off-by: Lars Mueller <lmuelle at suse.com>
commit 0aa12de5c1565d56a240d7b0dd814316f4ea81f3
Author: Lars Mueller <lmuelle at suse.com>
Date: Fri Apr 20 07:59:15 2012 -0400
mount.cifs: toggle_dac_capability() stores return code
the build process of the cifs-utils for Mandriva 2011 made me notice of
the unused variable rc in toggle_dac_capability() of mount.cifs.c.
A bit up in the code we store the return value and do not make use of it
while calling return.
The attached patch intends to fix this.
The failing build result is still visible at
https://build.opensuse.org/package/live_build_log?arch=x86_64&package=cifs-utils&project=network%3Asamba%3ASTABLE&repository=Mandriva_2011
Acked-by: Suresh Jayaraman <sjayaraman at suse.com>
Signed-off-by: Lars Mueller <lmuelle at suse.com>
commit a91fb0671273e4ef9079ee7860574c460aa94a51
Author: Jeff Layton <jlayton at samba.org>
Date: Fri Apr 20 07:59:17 2012 -0400
mount.cifs: remove unnecessary getuid() check in libcap version of
toggle_dac_capability
I'm not sure what I was thinking when I added that check in, but
it's
been there since the inception. We shouldn't care at all what the
real uid is when we call toggle_dac_capability and indeed we don't
care with the libcap-ng version. Remove that check.
Signed-off-by: Jeff Layton <jlayton at samba.org>
commit bab572a89bd0d989bd761e8cea926dfcf48b938d
Author: Jeff Layton <jlayton at samba.org>
Date: Wed May 2 14:25:28 2012 -0400
mount.cifs: don't pass credentials= option to the kernel
We handle this option in userspace, so there's little value in also
passing it to the kernel.
Also fix minor double-comma nit in the options string.
Reported-by: Ronald <ronald645 at gmail.com>
Signed-off-by: Jeff Layton <jlayton at samba.org>
commit 9410c776a3bd69a8434e5f01174bc59f08e7e62a
Author: Jeff Layton <jlayton at samba.org>
Date: Mon May 14 06:41:29 2012 -0400
doc: update mailing list
Signed-off-by: Luk Claes <luk at debian.org>
commit 9e3c3c4b4ae4c3e9eb2eb6297c31c50337b2fd07
Author: Jeff Layton <jlayton at samba.org>
Date: Thu May 17 06:46:38 2012 -0400
mount.cifs: don't send a mandatory ver= option to the kernel
Traditionally, this ver= option was used to specify the "options
version" that we're passing in. It has always been set to
'1' though
and we have never changed that.
Eventually we want to have a ver= (or vers=) option that allows users
to specify the SMB version that they want to use to talk to the server.
At that point, this option will just get in the way. Let's go ahead
and remove it now in preparation for that day.
Signed-off-by: Jeff Layton <jlayton at samba.org>
commit f161532355c1b410a308bd165c60c2b1e6d6691c
Author: Jeff Layton <jlayton at samba.org>
Date: Thu May 17 06:46:38 2012 -0400
mount.cifs: remove smb2 multicall binary code
This was added when it was thought that smb2 would be a different fstype
altogether. Now that we are not adding a separate fstype, this code is
no longer needed since nothing will ever call /sbin/mount.smb2.
Cc: Steve French <smfrench at gmail.com>
Signed-off-by: Jeff Layton <jlayton at samba.org>
commit 24ab7b063624340c0f0a3d5781522c203d8265f9
Author: Jeff Layton <jlayton at samba.org>
Date: Thu May 17 06:46:38 2012 -0400
doc: remove old XML sources for mount.cifs.8 and cifs.upcall.8
These files were added when I originally split these tools off from the
samba sources, but we haven't ever used them to build the actual
manpages and they haven't been maintained. Remove them.
Signed-off-by: Jeff Layton <jlayton at samba.org>
commit cb8d28e9550baf674e20fbbe162c0a4bcf20be6b
Author: Luk Claes <luk at debian.org>
Date: Sat May 19 06:37:21 2012 -0400
mount.cifs: unused variables
commit 957a94838a779a106e5c09806678eaecb8fcb242
Author: Jeff Layton <jlayton at samba.org>
Date: Mon May 21 09:14:17 2012 -0400
manpage: document the cache= option and mark strictcache and directio as
being deprecated
...also add a CACHE COHERENCY section so that we can explain cifs'
behavior
in detail.
Signed-off-by: Jeff Layton <jlayton at samba.org>
commit e52b72af2fc54177ecf11022a2aebbaa5a71b76b
Author: Jeff Layton <jlayton at samba.org>
Date: Wed May 30 06:12:16 2012 -0400
autoconf: set version to 5.5
Signed-off-by: Jeff Layton <jlayton at samba.org>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (GNU/Linux)
iQIcBAEBAgAGBQJPxfhfAAoJEAAOaEEZVoIVY50QAMSEUuQf/RTPydvMyV2V7Ppg
Wg19rEmjP/1dw+vklT0DsvoULqd2qpQwtEkCGkVQLUM6bTGnQU/90rjeJMCY7HBI
5xeuMNAp3wkSEb/yG75SX1EWyKKdTMn37lYGP0G9mXW4uEuux9ziGXVmBjnuU6ip
wjnfX7k8WqdKnTN56rj0lbSAAW9ig2W2Gskq1RlTjHWF6z+oq7ykM5b7tqDCIUjP
g5K1fbw7DiWWPzX+dWb/Bj+FQl6eu3hvzg3XM6QlH2NROaHzk4WmqSzxBCdvJLx6
yZZ8MmjiS4XL5TmW9CZOlA0z0NWVHMZN5Q3Aj0jKFtkzVki+fD9psgnmihVweah/
MyZGnQNAc3BjFrLauONp2pGd70X0ReHt2OWqgLdaCWYQGCBx41iipn8UYybf7mwO
6z/lv5rBjiUfbEWnqL5TCZkcKS+xpX2uuV6lnJQYkHtFNq5iwSIEIUiEY3/XlM79
RXdaRatVyd/9TvkbzTk1u2IvNc8fIN0V0I8ZzYKU/yWFkNk19c9PUEbda3Gxyyq2
eRwML10dcYG0Mr0qmiFm+QAA+9xYpVF9OTee3AFIPHnzY/7Jf9TYC5yJfNY+psae
XCMnyEPpJXmSrGl+rlHYEel1aORHUFRBYFsDuXF2+jbToIg1GWNeV8qVNkCeWYqM
1R2JuQLpJt961dFt8Kus
=i+H8
-----END PGP SIGNATURE-----
Suresh Jayaraman
2012-May-31 05:49 UTC
[Samba] ANNOUNCE: cifs-utils release 5.5 is ready for download
On 05/30/2012 04:07 PM, Jeff Layton wrote:> -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1> > I'm starting to have doubts as to whether it's a good idea to keep > - -Werror in the default CFLAGS. This is built in a large range of > environments and with a large range of different tool versions. > Catching all of the warnings can be difficult.Yeah, I'm having my doubts too, now.> I've left that flag in place for now, but if it's causing significant > pain for anyone then please speak up, and we might remove it in a later > release. >There is no significant pain for me, but I'm little worried about cifs-utils not being to able to build successfully in different environments (due to -Werror being default) which we won't be able to test and verify anyway. Perhaps, we can decide not to keep -Werror as the default flag but ensure that we (maintainers/developers) run with this enabled from time-to-time to ensure that real problems are not sneaking in. Another way to approach is to leave the flag as-is for a while so that we can catch all of these as they will probably be reported anyway. The former sounds more user friendly than the latter. But, I don't have any strong opinions on either. Thanks Suresh
Reasonably Related Threads
- ANNOUNCE: cifs-utils release 5.6 is ready for download
- ANNOUNCE: cifs-utils release 4.6 available for download
- ANNOUNCE: cifs-utils release 5.2 available for download
- ANNOUNCE: cifs-utils release 4.8 available for download
- ANNOUNCE: cifs-utils release 4.7 available for download