samba - Aug 2008 - Printing XP -> 3.2 Now really slow (just like the old days)

Guys,

	My wife needed to print something this evening to our normal HP 4 attached to 
our cups server running samba-3.2.1-0.1.126. Nothing has changed in the last 
two months going from 3.0.28a to the 3.2.x flavor of samba. However, something 
has brought printing to its knees.

	I pulled out all the old tricks, hacked the registry to delete any entries in 
HKCU\Printers\DevModes and DevModes2 of the type \\server\printer. Removal of 
the entries didn't change a thing. I captured an ethereal/wireshark trace
and I
have that available to anyone if interested.

	Have there been any changes in 3.2.x that would effect printing? It does seem 
to print once every conceivable timer in window times out, but were talking 
120-150 seconds. Any Ideas?

-- 
David C. Rankin, J.D., P.E.
Rankin Law Firm, PLLC
510 Ochiltree Street
Nacogdoches, Texas 75961
Telephone: (936) 715-9333
Facsimile: (936) 715-9339
www.rankinlawfirm.com

David C. Rankin wrote:
> Guys,
> 
>     Have there been any changes in 3.2.x that would effect printing? It 
> does seem to print once every conceivable timer in window times out, but 
> were talking 120-150 seconds. Any Ideas?
> 
Guys,

	I can confirm, this seems to be an XP only issue. Vista prints just fine to 
the same server. I have also confirmed the XP behavior on 2 other boxes. In all 
regards, the behavior is identical, printing basically freezes the application 
and printer dialog (if open) for about 2.5 minutes until everything in XP times 
out, then the documents will actually print, but not before you get the grayed 
boxes and "application not responding" messages.

	What can I send you that would help solve this atavistic printing conundrum? 
Just let me know and I'll be glad to help. Anything so my wife can print.
When
she needs to print, it seems to be an "immediate" thing, every time...

-- 
David C. Rankin, J.D., P.E.
Rankin Law Firm, PLLC
510 Ochiltree Street
Nacogdoches, Texas 75961
Telephone: (936) 715-9333
Facsimile: (936) 715-9339
www.rankinlawfirm.com

On Thu, Aug 14, 2008 at 02:01:26AM -0500, David C. Rankin
wrote:
> Guys,
>
> 	My wife needed to print something this evening to our normal HP 4 
> attached to our cups server running samba-3.2.1-0.1.126. Nothing has 
> changed in the last two months going from 3.0.28a to the 3.2.x flavor of 
> samba. However, something has brought printing to its knees.
>
> 	I pulled out all the old tricks, hacked the registry to delete any 
> entries in HKCU\Printers\DevModes and DevModes2 of the type 
> \\server\printer. Removal of the entries didn't change a thing. I 
> captured an ethereal/wireshark trace and I have that available to anyone 
> if interested.
>
> 	Have there been any changes in 3.2.x that would effect printing? It does 
> seem to print once every conceivable timer in window times out, but were 
> talking 120-150 seconds. Any Ideas?
There's a bug with a missing reply_printclose() that just
got fixed in the tree by Bartosz Antosik that may be
causing this. It could cause print jobs to timeout
on the Windows side.

Patch is attached, and it will be in 3.2.2.

Jeremy.
-------------- next part --------------
diff --git a/source/smbd/reply.c b/source/smbd/reply.c
index ef49d58..88c8ae8 100644
--- a/source/smbd/reply.c
+++ b/source/smbd/reply.c
@@ -4672,6 +4672,8 @@ void reply_printclose(struct smb_request *req)
 		return;
 	}
 
+	reply_outbuf(req, 0, 0);
+
 	END_PROFILE(SMBsplclose);
 	return;
 }