While working on adding support for local-binding, I found this piece of code
in libmsrpc.c. Maybe I'm confused..but should that strcmp maybe be compared
to != 0?
/*change the server name in the server handle if necessary*/
if(srv && hnd->server && strcmp(hnd->server, srv) ==
0) {
SAFE_FREE(hnd->server);
hnd->server = SMB_STRDUP(srv);
}
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Ben Greear wrote:> While working on adding support for local-binding, I found this piece of > code > in libmsrpc.c. Maybe I'm confused..but should that strcmp maybe be > compared to != 0? > > /*change the server name in the server handle if necessary*/ > if(srv && hnd->server && strcmp(hnd->server, srv) == 0) { > SAFE_FREE(hnd->server); > hnd->server = SMB_STRDUP(srv); > }Looks like it. Send me a patch ? I'm lazy... Plus would you like to see you name in the release notes? :-) :-) jerry ====================================================================Samba ------- http://www.samba.org Centeris ----------- http://www.centeris.com "What man is a man who does not make the world better?" --Balian -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iD8DBQFEttsyIR7qMdg1EfYRAk1rAJ9KGWjGwgHd8lLB243HABCuZNiV8QCgxSUW ibfcB99MUVbdRRwDGmHiwcI=Qvvf -----END PGP SIGNATURE-----