search for: safe_free

First thing - I'd like to say a big "THANK YOU" to the developers. I just upgraded to samba-3.0.23 and I've noticed an alarming issue with respect to my configuration. I've been using the built-in keytab management and it looks like the updated code no longer creates the userPrincipal in Active Directory. Whether this is an issue for others or not, it would be nice to have

...client/client.c), release 4.12.6 (so sorry as this is no patching syntax, but hope you can figure out what it means): 2349 } else { ++ 2350 if (mask_match(lname,client_get_fileselection(),false)) { 2351 SAFE_FREE(quest); 2352 if (asprintf(&quest,"Put file %s? ", lname) < 0) { 2353 break; 2354 } 2355 if (prompt && !yesno(quest)) { 2356...

...ere in configure unless it's under another name, but it seems to me based on the description given by "mbp" in the code that it may need to look like this: #if !defined(HAVE_SNPRINTF) || !defined(HAVE_SNPRINTF_DECL) anyway the bug i'm tracking is a failure to expand the macros SAFE_FREE and VA_COPY. is compiles fine in AIX 5.1. as soon as i figure that one out, i'll forward it. Bill

...nst argv[]) goto out; } - ccache = get_default_cc(); + ccache = get_existing_cc(env_cachename); /* Couldn't find credcache? Try to use keytab */ if (ccache == NULL && arg.username != NULL) ccache = init_cc_from_keytab(keytab_name, arg.username); @@ -959,6 +1094,7 @@ out: SAFE_FREE(arg.ip); SAFE_FREE(arg.username); SAFE_FREE(keydata); + SAFE_FREE(env_cachename); syslog(LOG_DEBUG, "Exit status %ld", rc); return rc; } -- 2.9.3

Third respin of this series. Reordered for better safety for bisecting. The environment scraping is now on by default, but can be disabled with "-E" in environments where it's not needed. Also, I've added a patch to make cifs.upcall drop capabilities before doing most of its work. This may help reduce the attack surface of the program. Jeff Layton (4): cifs.upcall: convert

...upport for local-binding, I found this piece of code in libmsrpc.c. Maybe I'm confused..but should that strcmp maybe be compared to != 0? /*change the server name in the server handle if necessary*/ if(srv && hnd->server && strcmp(hnd->server, srv) == 0) { SAFE_FREE(hnd->server); hnd->server = SMB_STRDUP(srv); } -- Ben Greear <greearb@candelatech.com> Candela Technologies Inc http://www.candelatech.com

Small respin of the patches that I posted a few days ago. The main difference is the reordering of the series to make it do the group and grouplist manipulation first, and then the patch that makes it grab the KRB5CCNAME from the initiating process. I think the code is sound, my main question is whether we really need the command-line switch for this. Should this just be the default mode of

When using Samba 3.0.23b (slightly old, I know) on CentOS 4.4, smbstatus -B fails with a segmentation fault. smbstatus works, and tdbdump is able to dump brlock.tdb and locking.tdb without any errors (which is not what I expected). Here's the backtrace (non-ASCII characters replaced with 'X'): #0 0x0017fa2c in memcpy () from /lib/tls/libc.so.6 #1 0x0029b19f in tdb_write

...set_cmdline_auth_info_username(auth_info, puser); } SAFE_FREE(puser); } break; Are there use cases which we aren't thinking of, or does this modification make sense. Please let us know. Regards, Mike

Apologies for v3 series, I had some extra patches in there. This is the one that should have been sent. Relabeled as v4 for clarity. Third respin of this series. Reordered for better safety for bisecting. The environment scraping is now on by default, but can be disabled with "-E" in environments where it's not needed. Also, I've added a patch to make cifs.upcall drop

My apologies if this isn't the correct posting address -- I didn't see an obvious "report problems here" on the website. Some of the code modifications introduced between 2.2.7 and 2.2.8 don't appear to agree with Solaris, using Sun's CC, with the LDAP support code. Note that I'm linking against the Solaris-bundled LDAP package (SUNWlldap). |% env

Dear Andrew. You are right, I should have taken a deeper look into the standard output during compilation. I did just assume source4 was the one for Samba4. Anyway, besides the source confusion (really, even if I had found the right one, following the code would have been out of my reach), I don't seem to find how that is related with the documentation issue, or the mput/mask/recurse

...+ (share_entry->pid != pid)) { + DEBUG(3, ("check_file_sharing: bailing early\n")); goto free_and_exit; - + } } /* end for */ if(broke_oplock) { + DEBUG(3, ("check_file_sharing: reloading share modes\n")); SAFE_FREE(old_shares); num_share_modes = get_share_modes(conn, dev, inode, &old_shares); } @@ -1332,7 +1361,7 @@ ret = True; free_and_exit: - + DEBUG(3, ("check_file_sharing: returning %s\n", ret ? "True" : "False")); unlock_share_entry(conn, dev, i...

...;, pdb_get_fullname(u)); + if(push_utf8_allocate(&fullname_utf8,pdb_get_fullname(u)) == (size_t)-1){ + return NT_STATUS_NO_MEMORY; + } + + if (fullname_utf8 && strcmp(fullname_utf8, "")) + xmlNewChild(user, data->ns, "fullname", fullname_utf8); + + SAFE_FREE(fullname_utf8); if (pdb_get_homedir(u) && strcmp(pdb_get_homedir(u), "")) xmlNewChild(user, data->ns, "homedir", pdb_get_homedir(u)); @@ -497,7 +504,7 @@ xmlNewChild(user, data->ns, "bad_password_count", iota(pdb_get_bad_password_count(u))); xm...

...SWD_PROGRAM="/usr/bin/passwd" -DSMB_PASSWD_FILE="/usr/local/samba/private/smbpasswd" -DTDB_PASSWD_FILE="/usr/local/samba/private/smbpasswd.tdb" Using LIBS = -lpam Linking bin/smbd ld: 0711-317 ERROR: Undefined symbol: .VA_COPY ld: 0711-317 ERROR: Undefined symbol: .SAFE_FREE ld: 0711-345 Use the -bloadmap or -bnoquiet option to obtain more information. collect2: ld returned 8 exit status make: 1254-004 The error code from the last command is 1. I've already googled the web with no luck, please help me!

...ith -g flag to be able to list sources from gdb when debugging pdbedit and discovered some more info but don't know how to interpret it: (gdb) frame 1 #1 0x0806c899 in init_sam_from_buffer (sampass=0x81b8c28, buf=0x81b8d78 "", buflen=208) at passdb/passdb.c:1462 1462 SAFE_FREE(domain); (gdb) print domain $8 = 0x10000 <Address 0x10000 out of bounds> It looks like domain is invalid address. It seems some integer has been sucked in into the pointer. This architecture is i686-pc-linux-gnu. Or maybe the whole memory is fatally corrupt and just generic strange things h...

Hi all, My old and stable backup script don't work anymore. It's based on smbclient's tar command using crX parameters for creating archive, excluding files based on basic regular expressions. The box is running Fedora core 2, fully updated: kernel-2.6.8-1.521 samba-common-3.0.7-2.FC2 samba-client-3.0.7-2.FC2 The error is easily reproducible: smbclient //ntpdc/share -A credfile \ -c

...ponse. o Amitay Isaacs <amitay at gmail.com> * BUG 10620: s4-dns: Add support for BIND 9.10. o Bj?rn Jacke <bj at sernet.de> * BUG 10835: nss_winbind: Add getgroupmembership for FreeBSD. o Volker Lendecke <vl at samba.org> * BUG 10932: pdb_tdb: Fix a TALLOC/SAFE_FREE mixup. o Stefan Metzmacher <metze at samba.org> * BUG 10472: pidl/wscript: Remove --with-perl-* options. * BUG 10921: s3:smbd: Fix file corruption using "write cache size != 0". o Jose A. Rivera <jarrpa at redhat.com> * BUG 10889: vfs_glusterfs: Remove &quo...

...ponse. o Amitay Isaacs <amitay at gmail.com> * BUG 10620: s4-dns: Add support for BIND 9.10. o Bj?rn Jacke <bj at sernet.de> * BUG 10835: nss_winbind: Add getgroupmembership for FreeBSD. o Volker Lendecke <vl at samba.org> * BUG 10932: pdb_tdb: Fix a TALLOC/SAFE_FREE mixup. o Stefan Metzmacher <metze at samba.org> * BUG 10472: pidl/wscript: Remove --with-perl-* options. * BUG 10921: s3:smbd: Fix file corruption using "write cache size != 0". o Jose A. Rivera <jarrpa at redhat.com> * BUG 10889: vfs_glusterfs: Remove &quo...

I am having a problem with Samba 3.0.20b runninn on Fedora core 4, with a 2.6.11-1.1369_FC4smp kernel. Each time I open a connection a new smbd process is forked. That is fine, but then that process never goes away, even after the client has disconnected. Even though there are only a few clients who make an smb connection to the server in question, dozens and dozens of smbd processes are