samba - Jan 2005 - new printing patch for 3.0.10 may fix the 'failure to remove print jobs from queue list display'

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I've uploaded a new draft of the printing patch for 3.0.10
to http://www.samba.org/~jerry/patches/post-3.0.10/
The only change is a small fix to fix the register_message_flags()
error messages in the logs.  After some thought, I think this
might address the 'jobs failing to be removed from the queue
list' bug.  If people could test and let me know, I would
appreciate it.





cheers, jerry
- ---------------------------------------------------------------------
Alleviating the pain of Windows(tm)      ------- http://www.samba.org
GnuPG Key                ----- http://www.plainjoe.org/gpg_public.asc
"If we're adding to the noise, turn off this song"--Switchfoot
(2003)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFB3CptIR7qMdg1EfYRAnruAKDEqHvZfHDA+OxyuQjquT+R6RXLSgCdHUpz
er3/vj9lCMQxNotsYGHSuFU=YW+/
-----END PGP SIGNATURE-----

On Wed 5 Jan 2005, at 17:57, Gerald (Jerry) Carter wrote:
> I've uploaded a new draft of the printing patch for 3.0.10
> to http://www.samba.org/~jerry/patches/post-3.0.10/
> The only change is a small fix to fix the register_message_flags()
> error messages in the logs.  After some thought, I think this
> might address the 'jobs failing to be removed from the queue
> list' bug.  If people could test and let me know, I would
> appreciate it.
Hi Jerry,

The patch (version #2) is working; when I print from an XP client to a CUPS
queue
(queue on hold), the print icon appears in the taskbar of the XP client.
When I remove 
the print job from the CUPS queue, within 30 seconds the print icon on the
XP client
disappears.

I also added this patch from Jerome Borsboom to your patch.

--- samba-3.0.10/source/printing/printing.c	2005-01-10
15:07:27.060999122 +0100
+++ samba-3.0.10.new/source/printing/printing.c	2005-01-10
15:07:36.784464292 +0100
@@ -1077,6 +1077,7 @@
 
 	if ( !print_cache_expired(sharename, False) ) {
 		DEBUG(5,("print_queue_update_internal: print cache for %s is
still ok\n", sharename));
+		release_print_db( pdb );
 		return;
 	}

Is your printing patch Ok to use in production environments? 

I saw that in the SAMBA_3_0 branch that printing/printing.c is changed with 
your patch, but your patch also patches:

param/loadparm.c
smbd/lanman.c 
smbd/negprot.c
smbd/reply.c 
smbd/server.c

but I can see that these files are not updated with your patch in the
SAMBA_3_0
branch, or am I wrong?

Regards,
Alex.