samba-bugs@samba.org
2006-May-04 17:27 UTC
DO NOT REPLY [Bug 3752] New: rsync unusable with EncFS filesystem
https://bugzilla.samba.org/show_bug.cgi?id=3752
Summary: rsync unusable with EncFS filesystem
Product: rsync
Version: 2.6.8
Platform: x86
OS/Version: Linux
Status: NEW
Severity: critical
Priority: P3
Component: core
AssignedTo: wayned@samba.org
ReportedBy: micheala@jacey.org
QAContact: rsync-qa@samba.org
Hi
I've just installed EncFS... Looks like RSYNC does not set the file
timestamp
to the original timestamp... In fact, it is set to the current time.
So, the next time RSYNC is run, it just copies all the files.
Have downloaded the source & tried to figure out what's causing the
problem.
The timestamp is set properly after finish_transfer(). However, it gets reset
after 8 files have been copied; i.e after 8 files have been copied, the time
stamp of the 1st copied file is reset... after 9 files, 2nd file get reset, 10
files, 3rd file get reset & so on.
Looks like the problem is somewhere in recv_files() / receive_data()... Could
not pinpoint as the 'reset' does not seem to happen at a fixed point.
Have searched the net & have not found anyone having the same problem... So
may
be I'm doing something wrong.
Would appreciate your help on this matter.
Micheal
--
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
samba-bugs@samba.org
2006-May-05 06:33 UTC
DO NOT REPLY [Bug 3752] rsync unusable with EncFS filesystem
https://bugzilla.samba.org/show_bug.cgi?id=3752 ------- Comment #1 from wayned@samba.org 2006-05-05 01:28 MST ------- After rsync sets the time/attributes on a file, it renames the file into place and it is done with it. If the timestamp is changing after that, I have a hard time imaging that this is rsync's fault. You might want to test that the renaming of a file can be done without having EncFS change the file's modify time (it shouldn't). -- Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.
samba-bugs@samba.org
2006-May-05 18:43 UTC
DO NOT REPLY [Bug 3752] rsync unusable with EncFS filesystem
https://bugzilla.samba.org/show_bug.cgi?id=3752
------- Comment #2 from micheala@jacey.org 2006-05-05 13:39 MST -------
The problem is indeed with EncFS/FUSE... e.g mv xxx yyy changes the mod time
Solved by modifying "syscall.c"
int do_rename(const char *fname1, const char *fname2)
{
if (dry_run) return 0;
RETURN_ERROR_IF_RO_OR_LO;
// return rename(fname1, fname2);
{
int x1;
struct stat s1;
x1 = stat(fname1, &s1);
if (x1 != 0)
return x1;
x1 = rename(fname1, fname2);
if (x1 != 0)
return x1;
return set_modtime(fname2, s1.st_mtime, s1.st_mode);
}
}
--
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
samba-bugs@samba.org
2006-May-05 18:45 UTC
DO NOT REPLY [Bug 3752] rsync unusable with EncFS filesystem
https://bugzilla.samba.org/show_bug.cgi?id=3752
micheala@jacey.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Comment #3 from micheala@jacey.org 2006-05-05 13:40 MST -------
samba-bugs@samba.org
2009-May-03 16:43 UTC
DO NOT REPLY [Bug 3752] rsync unusable with EncFS filesystem
https://bugzilla.samba.org/show_bug.cgi?id=3752 ------- Comment #4 from micheala@jacey.org 2009-05-03 11:44 CST ------- (In reply to comment #2)> The problem is indeed with EncFS/FUSE... e.g mv xxx yyy changes the mod time > > Solved by modifying "syscall.c" > > int do_rename(const char *fname1, const char *fname2) > { > if (dry_run) return 0; > RETURN_ERROR_IF_RO_OR_LO; > // return rename(fname1, fname2); > { > int x1; > struct stat s1; > x1 = stat(fname1, &s1); > if (x1 != 0) > return x1; > x1 = rename(fname1, fname2); > if (x1 != 0) > return x1; > return set_modtime(fname2, s1.st_mtime, s1.st_mode); > } > } >I can confirm the bug has not been fixed in rsync 3.0.5 & encfs 1.4.2. The patch still works with rsync 3.0.5 Download source from http://www.samba.org/ftp/rsync/src/rsync-3.0.5.tar.gz Extract to /tmp cd /tmp vi syscall.c Search for do_rename. Apply patch & save ./configure make install cp /usr/local/bin/rysnc /usr/bin -- Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.
samba-bugs@samba.org
2009-May-04 01:04 UTC
DO NOT REPLY [Bug 3752] rsync unusable with EncFS filesystem
https://bugzilla.samba.org/show_bug.cgi?id=3752
wayned@samba.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CLOSED |REOPENED
Resolution|FIXED |
------- Comment #5 from wayned@samba.org 2009-05-03 20:04 CST -------
This is not a bug in rsync, but a bug in EncFS. While you created a
work-around that does several extra calls per rename in the rsync source, those
calls would not be appropriate for general use and will never appear in an
rsync release. Also, this bug should not have been closed as "Fixed",
so I'll
reopen it and close it again.
--
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
samba-bugs@samba.org
2009-May-04 01:04 UTC
DO NOT REPLY [Bug 3752] rsync unusable with EncFS filesystem
https://bugzilla.samba.org/show_bug.cgi?id=3752
wayned@samba.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution| |WONTFIX
------- Comment #6 from wayned@samba.org 2009-05-03 20:05 CST -------
I'd suggest that you go into the EncFS source and fix it so that a rename
doesn't change the mtime for a file.
--
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.