search for: return_error_if_ro_or_lo

https://bugzilla.samba.org/show_bug.cgi?id=3752 Summary: rsync unusable with EncFS filesystem Product: rsync Version: 2.6.8 Platform: x86 OS/Version: Linux Status: NEW Severity: critical Priority: P3 Component: core AssignedTo: wayned@samba.org ReportedBy: micheala@jacey.org

...he permission of the files in the diff -brpu rsync-3.0.0pre9/syscall.c rsync-3.0.0pre9-flags/syscall.c --- rsync-3.0.0pre9/syscall.c Sat Jan 26 01:57:02 2008 +++ rsync-3.0.0pre9-flags/syscall.c Fri Feb 15 19:35:16 2008 @@ -50,6 +50,9 @@ int do_unlink(const char *fname) { if (dry_run) return 0; RETURN_ERROR_IF_RO_OR_LO; +#if SUPPORT_FLAGS + chflags(fname, 0); +#endif return unlink(fname); } @@ -133,6 +136,9 @@ int do_rmdir(const char *pathname) { if (dry_run) return 0; RETURN_ERROR_IF_RO_OR_LO; +#if SUPPORT_FLAGS + chflags(pathname, 0); +#endif return rmdir(pathname); } @@ -174,10 +180,22 @@ int do...

...2333GMT-d2d/syscall.c 2008-12-04 16:56:38.000000000 -0500 @@ -35,6 +35,7 @@ extern int list_only; extern int preserve_perms; extern int preserve_executability; +extern int copy_devices; #define RETURN_ERROR_IF(x,e) \ do { \ @@ -50,6 +51,7 @@ { if (dry_run) return 0; RETURN_ERROR_IF_RO_OR_LO; + if (copy_devices) return 0; return unlink(fname); }

...al 0 -rw-r--r-- 2 root wheel schg 0B Oct 1 15:50 a -rw-r--r-- 2 root wheel schg 0B Oct 1 15:50 b The patch: --- orig/syscall.c 2009-09-29 15:34:03.293118000 +0200 +++ syscall.c 2009-09-29 16:11:29.400671306 +0200 @@ -82,7 +82,23 @@ { if (dry_run) return 0; RETURN_ERROR_IF_RO_OR_LO; - return link(fname1, fname2); + if (link(fname1, fname2) == 0) + return 0; +#ifdef SUPPORT_FORCE_CHANGE + if (force_change && errno == EPERM) { + STRUCT_STAT st; + + if (x_lstat(fname1, &st, NULL) == 0 +...

...look at the changes. What is the "official" way of asking for inclusion in the rsync distribution? Reporting a bug via bugzilla? Best regards Franz -------------- next part -------------- #ifdef HAVE_LINK int do_link(const char *fname1, const char *fname2) { if (dry_run) return 0; RETURN_ERROR_IF_RO_OR_LO; if (link(fname1, fname2) == 0) return 0; #ifdef SUPPORT_FORCE_CHANGE if (force_change && (errno == EPERM || errno == EACCES)) { char parent[MAXPATHLEN]; int parent_flags; int saved_errno = errno; int file_flags = make_mutable(fname1, NULL, NO_FFLAGS, force_change); if (file_...

...854010e 100644 --- a/syscall.c +++ b/syscall.c @@ -189,6 +189,15 @@ int do_open(const char *pathname, int flags, mode_t mode) return open(pathname, flags | O_BINARY, mode); } +#ifdef HAVE_FALLOCATE +int do_fallocate(int fd, int mode, OFF_T offset, OFF_T len) +{ + RETURN_ERROR_IF(dry_run, 0); + RETURN_ERROR_IF_RO_OR_LO; + return fallocate(fd, mode, offset, len); +} +#endif + #ifdef HAVE_CHMOD int do_chmod(const char *path, mode_t mode) { -- 1.6.6.1

I am try to use rsync from my windows box (under cygwin) to back up "My Documents" on to a debian server (known on my home network as roo.home) running rsyncd from inetd where it is run as root. my rsyncd.conf file sets the gid and uid to user backup.backup thusly:- syslog facility = daemon uid = backup gid = backup hosts allow = 192.168.0.0/24 hosts deny = 0.0.0.0/0 timeout = 600

...9 12:35:36.%N -0800 @@ -27,6 +27,7 @@ #include "rsync.h" extern int dry_run; +extern int offline; extern int read_only; extern int list_only; extern int preserve_perms; @@ -43,7 +44,7 @@ int do_unlink(char *fname) { - if (dry_run) return 0; + if (dry_run || offline) return 0; RETURN_ERROR_IF_RO_OR_LO; return unlink(fname); } Index: rsync-2.6.3/rsync.1 =================================================================== --- rsync-2.6.3.orig/rsync.1 2005-03-18 17:19:29.%N -0800 +++ rsync-2.6.3/rsync.1 2005-03-19 23:09:32.%N -0800 @@ -424,6 +424,7 @@ \-\-bwlimit=KBPS limit I/O ban...