search for: set_modtim

...2002 --- backup.c Tue Apr 9 15:21:56 2002 *************** *** 110,116 **** rprintf(FERROR,"make_bak_dir stat %s : %s\n",fullpath,strerror(errno)); } else { st2=&st; ! set_modtime(fullpath,st2->st_mtime); if(do_lchown(fullpath,st2->st_uid,st2->st_gid)!=0) { rprintf(FERROR,"make_bak_dir chown %s : %s\n",fullpath,strerror(errno)); }; --- 110,117 ---- rprintf(FERROR,&quot...

...enerator.c rsync-2.6.6_patch/generator.c --- rsync-2.6.6/generator.c 2005-07-28 21:06:03.000000000 +0200 +++ rsync-2.6.6_patch/generator.c 2005-11-25 11:33:33.000000000 +0100 @@ -917,6 +917,13 @@ fnamecmpbuf, 1, itemizing && verbose > 1, code) == 0) { + if (set_modtime(fname,file->modtime, + file->acctime) != 0) { + rsyserr(FERROR, errno, + "failed to set times on %s", + full_fname(fname)); + return; + } if (preserve_hard_links && file->link_u.links) { hard_link_cluster(file, ndx,...

'rsync -a' updates the ctime on a directory even if no file in that directory has changed. A kind of workaround is to use '-O', but then the mtimes of directories are not preserved. (Usage example where this is important: maintain a copy of filesystem A in filesystem B, and use filesystem B as the source for incremental backups (e.g., with star). rsync is run before an

...or * DR_NOT_EMPTY. Note that fname must point to a MAXPATHLEN buffer! (The * buffer is used for recursion, but returned unchanged.) @@ -786,13 +786,13 @@ @@ -353,7 +354,7 @@ void set_blocking(int fd); int fd_pair(int fd[2]); void print_child_argv(const char *prefix, char **cmd); - int set_modtime(const char *fname, time_t modtime, uint32 mod_nsec, mode_t mode); + int set_modtime(const char *fname, time_t modtime, uint32 mod_nsec, mode_t mode, uint32 fileflags); -int make_path(char *fname, int flags); +int make_path(char *fname, mode_t mode, int flags); int full_write(int desc, const ch...

...cvsroot/rsync/backup.c,v retrieving revision 1.28 diff -u -w -r1.28 backup.c --- backup.c 13 Mar 2004 20:18:03 -0000 1.28 +++ backup.c 10 Apr 2004 23:28:35 -0000 @@ -101,7 +101,7 @@ "make_bak_dir stat %s failed: %s\n", full_fname(rel), strerror(errno)); } else { - set_modtime(fullpath, st.st_mtime); + set_times(fullpath, st.st_mtime, time(NULL)); do_lchown(fullpath, st.st_uid, st.st_gid); do_chmod(fullpath, st.st_mode); } Index: batch.c =================================================================== RCS file: /cvsroot/rsync/batch.c,v retrieving rev...

We use rsync to update an nfs server. After an update, we noticed that a large number of clients didn't see the updated data. It took me a while to be able to reliably reproduce this problem, but it happens on old and new versions of rysnc. It also happens across all the platforms we use here (sun/linux/netapp). This shows the problem: [Note my home directory is NFS mounted]

https://bugzilla.samba.org/show_bug.cgi?id=3752 Summary: rsync unusable with EncFS filesystem Product: rsync Version: 2.6.8 Platform: x86 OS/Version: Linux Status: NEW Severity: critical Priority: P3 Component: core AssignedTo: wayned@samba.org ReportedBy: micheala@jacey.org

...cvsroot/rsync/backup.c,v retrieving revision 1.28 diff -u -w -r1.28 backup.c --- backup.c 13 Mar 2004 20:18:03 -0000 1.28 +++ backup.c 20 Apr 2004 21:06:17 -0000 @@ -101,7 +101,7 @@ "make_bak_dir stat %s failed: %s\n", full_fname(rel), strerror(errno)); } else { - set_modtime(fullpath, st.st_mtime); + set_times(fullpath, st.st_mtime, time(NULL)); do_lchown(fullpath, st.st_uid, st.st_gid); do_chmod(fullpath, st.st_mode); } Index: batch.c =================================================================== RCS file: /cvsroot/rsync/batch.c,v retrieving rev...

...trailing_slashes(char *name); > int do_mkdir(char *fname, mode_t mode); > @@ -326,7 +329,7 @@ int fd_pair(int fd[2]); > void print_child_argv(const char *prefix, char **cmd); > NORETURN void out_of_memory(const char *str); > NORETURN void overflow_exit(const char *str); > -int set_modtime(const char *fname, time_t modtime, mode_t mode); > +int set_modtime(const char *fname, time_t modtime, mode_t mode, > uint32 fileflags); > int mkdir_defmode(char *fname); > int create_directory_path(char *fname); > int full_write(int desc, const char *ptr, size_t len); > dif...

When rsync'ing to an Ext2 file system (via SSH), then I frequently get error messages such as "failed to set times ...". AFAICS, these error messages are caused by rsync trying to change the time (and permissions, ownership) of symbolic links, which according to my knowledge is not possible on Ext2. Is there any way to get rid of these supposedly superfluous error messages? rsync

...; @@ -276,8 +276,8 @@ void set_blocking(int fd); int fd_pair(int fd[2]); void print_child_argv(char **cmd); -NORETURN void out_of_memory(char *str); -NORETURN void overflow_exit(char *str); +NORETURN void out_of_memory(char *str) NORETURN2; +NORETURN void overflow_exit(char *str) NORETURN2; int set_modtime(char *fname, time_t modtime, mode_t mode); int mkdir_defmode(char *fname); int create_directory_path(char *fname); --- rsync-2.6.9/rsync.h.orig 2006-10-24 05:31:30.000000000 +0200 +++ rsync-2.6.9/rsync.h 2006-11-21 21:32:09.000000000 +0100 @@ -667,7 +667,16 @@ #endif #define UNUSED(x) x __at...

https://bugzilla.samba.org/show_bug.cgi?id=2913 ------- Additional Comments From wayned@samba.org 2005-07-26 09:27 ------- Created an attachment (id=1336) --> (https://bugzilla.samba.org/attachment.cgi?id=1336&action=view) Use lchmod and lutimes, if present Please test this patch and see if it works for you. You will need to run "autoconf; autoheader; make proto" (or

...if (dry_run) { + rprintf(FINFO,"modtime: %s\n",fname); + return 0; + } /* don't complain about not setting times on directories * because some filesystems can't do it */ if (set_modtime(fname,file->modtime) != 0 && @@ -157,6 +160,10 @@ change_gid = preserve_gid && file->gid != GID_NONE && st->st_gid != file->gid; if (change_uid || change_gid) { + if (dry_run) { + rprintf(FINFO,&quo...

...st = &st2; > } > > - if (preserve_times && !S_ISLNK(st->st_mode) && > - st->st_mtime != file->modtime) { > - /* don't complain about not setting times on directories > - because some filesystems can't do it */ > - if (set_modtime(fname,file->modtime) != 0 && > - !S_ISDIR(st->st_mode)) { > - rprintf(FERROR,"failed to set times on %s : %s\n", > - fname,strerror(errno)); > - return 0; > - } else { > - updated = 1; > - } > - } > - > change_uid =...

https://bugzilla.samba.org/show_bug.cgi?id=5506 Summary: support utime differences at runtime, not configure/build time Product: rsync Version: 3.0.3 Platform: All URL: http://thread.gmane.org/gmane.network.rsync.general/1794 8 OS/Version: Linux Status: NEW Severity:

...o.h > --- rsync-2.6.2.orig/proto.h Thu Apr 22 06:58:09 2004 > +++ rsync-2.6.2/proto.h Fri Jul 23 15:16:17 2004 > @@ -242,6 +242,7 @@ > void print_child_argv(char **cmd); > void out_of_memory(char *str); > void overflow(char *str); > +void update_atime(char *fname); > int set_modtime(char *fname, time_t modtime); > int create_directory_path(char *fname, int base_umask); > int copy_file(char *source, char *dest, mode_t mode); > diff -u rsync-2.6.2.orig/util.c rsync-2.6.2/util.c > --- rsync-2.6.2.orig/util.c Tue Apr 27 16:59:37 2004 > +++ rsync-2.6.2/util.c Fri...

...d length size, when at least for GCC a long is basically a machine word, that is, its size depends on the CPU architecture. ( Windows long type definition is better in that particular case, making it AFAIR an int32. ) Rsync, by the way, takes a much more reasonable approach by defining mod_nsec in set_modtime() as an uint32 ; however, this sanity is incompatible with insanity in the standard ( see e.g. http://pubs.opengroup.org/onlinepubs/7908799/xsh/time.h.html ), what will of course break the bogus nanosecond mtimes anyway. For a discussion, please refer to a following rsync lists message: https://l...

All callers of robust_rename() call copy_file() if EXDEV is received. This patch moves the copy_file() call into robust_rename(). Patch Summary: -12 +1 backup.c -15 +2 rsync.c -9 +33 util.c -------------- next part -------------- patchwork diff util.c --- util.c 2004-02-17 09:58:44.000000000 -0500 +++ util.c 2004-02-17 10:21:22.000000000 -0500 @@ -355,16 +355,40 @@

...o error is reported, and the -i output shows that the operation was completed as instructed -- which, of course, it could not have. The reason here is that, as far as I can see, in set_file_attrs, ATTRS_SET_NANO is not given and no attempt to set the mtime is made. Later however, in touch_up_dirs, set_modtime is called on the directory. It fails, but there is no error handling, because usually, the mtime would already have been set before, and an error would have become apparent already. (I guess that is anyway a dangerous assumption to make.) ================ All three cases have in common that the...

I've run into a bug in the IO handling when reading a file. Suppose I have a file that lives on an NFS filesystem. That filesystem is NOT being exported with auth=0 permissions. So, if I try to access a file as root, it successfully opens the file, but subsequent reads fail with EACCES. This produces a destination file full of null bytes. I noticed this with 2.5.7, but checked 2.6.2 as