rsync - Feb 2005 - [Bug 2389] block/character devices on Solaris yield wacky rsync stats

https://bugzilla.samba.org/show_bug.cgi?id=2389





------- Additional Comments From woodd@deshaw.com  2005-02-24 16:43 -------
Created an attachment (id=979)
 --> (https://bugzilla.samba.org/attachment.cgi?id=979&action=view)
Proposed syscall.c patch


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=2389





------- Additional Comments From wayned@samba.org  2005-02-24 19:35 -------
Created an attachment (id=982)
 --> (https://bugzilla.samba.org/attachment.cgi?id=982&action=view)
A simpler fix

I think a better/simpler fix is to tweak the code in flist.c where it adds up
the size of the transfer.  Currently it adds in the size of any non-directory. 
This should be changed to ignore devices at the very least.  However, since the
stat is the file size of the transfer, I think it might be best to ignore
symlinks too.  Here is a patch that ignores everything that is not a regular
file.

Please let me know if this fixes the problem.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=2389


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED




------- Additional Comments From wayned@samba.org  2005-02-25 16:10 -------
I've checked in a change to CVS that is similar to the one I attched to this
bug
report, but still counts symlinks in the total file size (i.e. it should just
omit devices).  I think this should fix this bug.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=2389





------- Additional Comments From woodd@deshaw.com  2005-02-27 16:19 -------
Odd, my reply never made it through.  I'll paste my reply in
"manually".  David

-----Original Message-----
From: Wood, David 
Sent: Friday, February 25, 2005 4:52 PM
To: 'samba-bugs@samba.org'
Subject: RE: [Bug 2389] block/character devices on Solaris yield wacky rsync
stats

> Please let me know if this fixes the problem.
Hi Wayne,

The patch works just fine - thanks!  I had originally used the same patch;
however, I went with the stat wrapper because:

1) I thought including symlink (pipe, etc) sizes in statistics was intentional

2) I figured a purist would be upset if bogus data lingered in the stat
structure

3) I'm not familiar enough with rsync internals to ensure that I would find
all
possible "bad" uses of st_size.  You're certainly well versed in
rsync internals
and can make such a determination ;-).

Anyway, much obliged for the fix.  David


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.