I have three class,HotActivity, Activity和ActivityType HotActivity and Activity is one to one association, Activity belongs to ActivityType in controller I code like this @hot_activities = HotActivity.includes(:activity) chrome will prompt me this user: william N+1 Query detected Activity => [:activity_type] Add to your finder: :include => [:activity_type] N+1 Query method call stack if I add like this @hot_activities = HotActivity.includes(:activity => :activity_type) it prompt this user: william Unused Eager Loading detected HotActivity => [:activity] Remove from your finder: :include => [:activity] activities:575 Uniform Notifier activities:587 user: william Unused Eager Loading detected Activity => [:activity_type] Remove from your finder: :include => [:activity_type] some one please help, thanks in advs -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group. To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-talk+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org To post to this group, send email to rubyonrails-talk-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/groups/opt_out.
andreo-FdlSlcb4kYpknbxzx/v8hQ@public.gmane.org
2013-Feb-02 23:04 UTC
Re: Question about includes
HI william, how exactly does chrome prompt that? whats the view like? is that the only line you have on your controller? can you be a little more specific and post exactly what is the error you get. all the best, Andre On Friday, 1 February 2013 10:06:40 UTC+1, William Herry wrote:> > I have three class,HotActivity, Activity和ActivityType > > HotActivity and Activity is one to one association, Activity belongs to > ActivityType > > in controller I code like this > > @hot_activities = HotActivity.includes(:activity) > > chrome will prompt me this > > user: william > N+1 Query detected > Activity => [:activity_type] > Add to your finder: :include => [:activity_type] > N+1 Query method call stack > > if I add like this > > @hot_activities = HotActivity.includes(:activity => :activity_type) > > it prompt this > > user: william > Unused Eager Loading detected > HotActivity => [:activity] > Remove from your finder: :include => [:activity] activities:575 > Uniform Notifier activities:587 > user: william > Unused Eager Loading detected > Activity => [:activity_type] > Remove from your finder: :include => [:activity_type] > > some one please help, > > thanks in advs > >-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group. To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-talk+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org To post to this group, send email to rubyonrails-talk-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org To view this discussion on the web visit https://groups.google.com/d/msg/rubyonrails-talk/-/iHKLLzvtewoJ. For more options, visit https://groups.google.com/groups/opt_out.
hi andreo, thanks for reply answer you inline On Sun, Feb 3, 2013 at 7:04 AM, <andreo-FdlSlcb4kYpknbxzx/v8hQ@public.gmane.org> wrote:> HI william, > > how exactly does chrome prompt that? >> Uniform Notifier activities:551 <http://localhost:3000/activities> > user: william N+1 Query detected Activity => [:activity_type] Add to your > finder: :include => [:activity_type] N+1 Query method call stack > /home/william/work/lly/app/views/activities/index.html.erb:48:in `block in > _app_views_activities_index_html_erb___3943997569956187419_46069520'' > /home/william/work/lly/app/views/activities/index.html.erb:32:in > `_app_views_activities_index_html_erb___3943997569956187419_46069520'' >line 48 <li><div id="type"></div>类型: <%hot_activity.activity.activity_type.name %></li> line 32 <li><div id="type"></div>类型: <%hot_activity.activity.activity_type.name %></li> whats the view like?><% @hot_activities.each_with_index do |hot_activity, index| %> <div id="detail<%= index + 1 %>" class="detail cf"> <ul> <li class="header"> <%= link_to hot_activity.activity.title, activity_path(hot_activity.activity) %> </li> <li> <div id="date"></div> ...> > is that the only line you have on your controller? >def index @hot_activities = HotActivity.includes(:activity) .where("activities.status = ''open''") .order(''start_at ASC'') .limit(5) @closed_activities = Activity.includes(:participants) .where("status = ''closed''") .order("participants_count desc") .limit(5) @hot_sponsors = User.includes(:created_activities) .where("status = ''A''") .order("created_activities_count desc") .limit(8) end> can you be a little more specific and post exactly what is the error you > get. > > all the best, > > Andre > > > On Friday, 1 February 2013 10:06:40 UTC+1, William Herry wrote: >> >> I have three class,HotActivity, Activity和ActivityType >> >> HotActivity and Activity is one to one association, Activity belongs to >> ActivityType >> >> in controller I code like this >> >> @hot_activities = HotActivity.includes(:**activity) >> >> chrome will prompt me this >> >> user: william >> N+1 Query detected >> Activity => [:activity_type] >> Add to your finder: :include => [:activity_type] >> N+1 Query method call stack >> >> if I add like this >> >> @hot_activities = HotActivity.includes(:activity => :activity_type) >> >> it prompt this >> >> user: william >> Unused Eager Loading detected >> HotActivity => [:activity] >> Remove from your finder: :include => [:activity] activities:575 >> Uniform Notifier activities:587 >> user: william >> Unused Eager Loading detected >> Activity => [:activity_type] >> Remove from your finder: :include => [:activity_type] >> >> some one please help, >> >> thanks in advs >> >> -- > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Talk" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to rubyonrails-talk+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org > To post to this group, send email to rubyonrails-talk-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org > To view this discussion on the web visit > https://groups.google.com/d/msg/rubyonrails-talk/-/iHKLLzvtewoJ. > For more options, visit https://groups.google.com/groups/opt_out. > > >-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group. To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-talk+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org To post to this group, send email to rubyonrails-talk-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/groups/opt_out.