Hi
I have this code
def destroy
@property = Property.find(params[:id])
IsAuthorized?(@property.user_id)
@property.destroy
respond_to do |format|
format.html { redirect_to(properties_url) }
format.xml { head :ok }
end
end
def IsAuthorized?(id)
if current_user.id!= id
flash[:notice] = ''Not authorized ''
redirect_to(properties_url)
end
end
If a not authorized user calls destroy it stills calls
@property.destroy.
How can I prevent the destory function from calling @property.destroy
if the user is not authorized?
--
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Talk" group.
To post to this group, send email to
rubyonrails-talk-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-talk+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-talk?hl=en.
On Sun, Apr 25, 2010 at 5:16 PM, Mohammed Alenazi <vb4max-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:> Hi > > I have this code > def destroy > @property = Property.find(params[:id]) > IsAuthorized?(@property.user_id) > @property.destroy > >Mohammed, you can write the above as follows: @property.destroy if IsAuthorized?(@property.user_id) Good luck, -Conrad> respond_to do |format| > format.html { redirect_to(properties_url) } > format.xml { head :ok } > end > end > > def IsAuthorized?(id) > if current_user.id!= id > flash[:notice] = ''Not authorized '' > redirect_to(properties_url) > end > end > > If a not authorized user calls destroy it stills calls > @property.destroy. > How can I prevent the destory function from calling @property.destroy > if the user is not authorized? > > -- > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Talk" group. > To post to this group, send email to rubyonrails-talk-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org > To unsubscribe from this group, send email to > rubyonrails-talk+unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org<rubyonrails-talk%2Bunsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org> > . > For more options, visit this group at > http://groups.google.com/group/rubyonrails-talk?hl=en. > >-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group. To post to this group, send email to rubyonrails-talk-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org To unsubscribe from this group, send email to rubyonrails-talk+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit this group at http://groups.google.com/group/rubyonrails-talk?hl=en.
On Sun, Apr 25, 2010 at 5:20 PM, Conrad Taylor <conradwt-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:> Mohammed, you can write the above as follows: > @property.destroy if IsAuthorized?(@property.user_id)Well, you could, *if* IsAuthorized? -- which idiomatically should be is_authorized? -- returned a boolean value :-)>> def IsAuthorized?(id) >> if current_user.id!= id >> flash[:notice] = ''Not authorized '' >> redirect_to(properties_url) >> end >> ende.g. def is_authorized?(id) current_user.id == id end -- Hassan Schroeder ------------------------ hassan.schroeder-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org twitter: @hassan -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group. To post to this group, send email to rubyonrails-talk-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org To unsubscribe from this group, send email to rubyonrails-talk+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-talk?hl=en.
On 26 April 2010 01:16, Mohammed Alenazi <vb4max-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:> Hi > > I have this code > def destroy > @property = Property.find(params[:id]) > IsAuthorized?(@property.user_id) > -33AYZwtzeUleBrXmD9aubA@public.gmane.org > > respond_to do |format| > format.html { redirect_to(properties_url) } > format.xml { head :ok } > end > end > > def IsAuthorized?(id) > if current_user.id!= id > flash[:notice] = ''Not authorized '' > redirect_to(properties_url) > end > end > > If a not authorized user calls destroy it stills calls > @property.destroy.Adding to the other replies to this, the fundamental problem is that redirect_to (somewhat non-intuitively) is not like a goto command. It initiates the redirect and then returns, so that IsAuthorized returns and the destroy is called whatever happened within IsAuthorized. Colin -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group. To post to this group, send email to rubyonrails-talk-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org To unsubscribe from this group, send email to rubyonrails-talk+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-talk?hl=en.
Conrad I did you suggested but I got this message Render and/or redirect were called multiple times in this action. Please note that you may only call render OR redirect, and at most once per action. Also note that neither redirect nor render terminate execution of the action, so if you want to exit an action after redirecting, you need to do something like "redirect_to(...) and return". On Apr 26, 3:20 am, Conrad Taylor <conra...-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:> On Sun, Apr 25, 2010 at 5:16 PM, Mohammed Alenazi <vb4...-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > > Hi > > > I have this code > > def destroy > > @property = Property.find(params[:id]) > > IsAuthorized?(@property.user_id) > > -33AYZwtzeUleBrXmD9aubA@public.gmane.org > > Mohammed, you can write the above as follows: > > @property.destroy if IsAuthorized?(@property.user_id) > > Good luck, > > -Conrad > > > > > respond_to do |format| > > format.html { redirect_to(properties_url) } > > format.xml { head :ok } > > end > > end > > > def IsAuthorized?(id) > > if current_user.id!= id > > flash[:notice] = ''Not authorized '' > > redirect_to(properties_url) > > end > > end > > > If a not authorized user calls destroy it stills calls > > @property.destroy. > > How can I prevent the destory function from calling @property.destroy > > if the user is not authorized? > > > -- > > You received this message because you are subscribed to the Google Groups > > "Ruby on Rails: Talk" group. > > To post to this group, send email to rubyonrails-talk-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org > > To unsubscribe from this group, send email to > > rubyonrails-talk+unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org<rubyonrails-talk%2Bunsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org> > > . > > For more options, visit this group at > >http://groups.google.com/group/rubyonrails-talk?hl=en. > > -- > You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group. > To post to this group, send email to rubyonrails-talk-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org > To unsubscribe from this group, send email to rubyonrails-talk+unsubscribe@googlegroups.com. > For more options, visit this group athttp://groups.google.com/group/rubyonrails-talk?hl=en.-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group. To post to this group, send email to rubyonrails-talk-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org To unsubscribe from this group, send email to rubyonrails-talk+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-talk?hl=en.
On 26 April 2010 13:09, Mohammed Alenazi <vb4max-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:> Conrad > > I did you suggested but I got this message > Render and/or redirect were called multiple times in this action. > Please note that you may only call render OR redirect, and at most > once per action. Also note that neither redirect nor render terminate > execution of the action, so if you want to exit an action after > redirecting, you need to do something like "redirect_to(...) and > return".Please put your replies inline rather than at the top of the message, then statements such as "I did as you suggested" make sense as they follow the suggestion made. Read the other replies on this thread if you have not already done so. The problem, as explained in the error message above is that redirect_to is not a goto command but a function call. Execution returns from there and drops through to the following code and so hits the respond_to code and redirects again, which is illegal. Colin> > On Apr 26, 3:20 am, Conrad Taylor <conra...-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: >> On Sun, Apr 25, 2010 at 5:16 PM, Mohammed Alenazi <vb4...-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: >> > Hi >> >> > I have this code >> > def destroy >> > @property = Property.find(params[:id]) >> > IsAuthorized?(@property.user_id) >> > -33AYZwtzeUleBrXmD9aubA@public.gmane.org >> >> Mohammed, you can write the above as follows: >> >> @property.destroy if IsAuthorized?(@property.user_id) >> >> Good luck, >> >> -Conrad >> >> >> >> > respond_to do |format| >> > format.html { redirect_to(properties_url) } >> > format.xml { head :ok } >> > end >> > end >> >> > def IsAuthorized?(id) >> > if current_user.id!= id >> > flash[:notice] = ''Not authorized '' >> > redirect_to(properties_url) >> > end >> > end >> >> > If a not authorized user calls destroy it stills calls >> > @property.destroy. >> > How can I prevent the destory function from calling @property.destroy >> > if the user is not authorized? >> >> > -- >> > You received this message because you are subscribed to the Google Groups >> > "Ruby on Rails: Talk" group. >> > To post to this group, send email to rubyonrails-talk-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org. >> > To unsubscribe from this group, send email to >> > rubyonrails-talk+unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org<rubyonrails-talk%2Bunsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org> >> > . >> > For more options, visit this group at >> >http://groups.google.com/group/rubyonrails-talk?hl=en. >> >> -- >> You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group. >> To post to this group, send email to rubyonrails-talk-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org >> To unsubscribe from this group, send email to rubyonrails-talk+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org >> For more options, visit this group athttp://groups.google.com/group/rubyonrails-talk?hl=en. > > -- > You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group. > To post to this group, send email to rubyonrails-talk-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org > To unsubscribe from this group, send email to rubyonrails-talk+unsubscribe@googlegroups.com. > For more options, visit this group at http://groups.google.com/group/rubyonrails-talk?hl=en. > >-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group. To post to this group, send email to rubyonrails-talk-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org To unsubscribe from this group, send email to rubyonrails-talk+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-talk?hl=en.
> > > Mohammed, you can write the above as follows: > > @property.destroy if IsAuthorized?(@property.user_id) > > Well, you could, *if* IsAuthorized? -- which idiomatically should > be is_authorized? -- returned a boolean value :-) >Personally I''d prefer authorized? - I never use is_...?, the is_ is just fluff (and doesn''t really make it any easier to read out loud/comprehend. Cheers, Andy -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group. To post to this group, send email to rubyonrails-talk-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org To unsubscribe from this group, send email to rubyonrails-talk+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit this group at http://groups.google.com/group/rubyonrails-talk?hl=en.
Andy Jeffries wrote:>> >> > Mohammed, you can write the above as follows: >> > @property.destroy if IsAuthorized?(@property.user_id) >> >> Well, you could, *if* IsAuthorized? -- which idiomatically should >> be is_authorized? -- returned a boolean value :-) >> > > Personally I''d prefer authorized? - I never use is_...?, the is_ is just > fluff (and doesn''t really make it any easier to read out > loud/comprehend. >Yes. Idiomatic Ruby style would be authorized? .> Cheers, > > > AndyBest, -- Marnen Laibow-Koser http://www.marnen.org marnen-sbuyVjPbboAdnm+yROfE0A@public.gmane.org -- Posted via http://www.ruby-forum.com/. -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group. To post to this group, send email to rubyonrails-talk-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org To unsubscribe from this group, send email to rubyonrails-talk+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit this group at http://groups.google.com/group/rubyonrails-talk?hl=en.