Hello Guys i want to use external validation i mean javascript validation but whenever click on create i mean (add new record submit)that time my first text box is black then it give me alert but when i click on ''ok'' it redirect to controller and give error not focus on same text box. -- Posted via http://www.ruby-forum.com/.
Wap Addon wrote:> Hello Guys > i want to use external validation i mean javascript validation but > whenever click on create i mean (add new record submit)that time my > first text box is black then it give me alert but when i click on ''ok'' > it redirect to controller and give error not focus on same text box.Whoa, take a step back here and slow down so that we can understand you. That''s one of the longest run-on sentences I''ve seen in my life. You want to use javascript validation because you are using something like a form_tag correct? Which tag are you using to start with? Start with providing the basics of what you have, show some initial code for the piece you are having issues with. You do not have to use javascript validation on external pieces. I have created custom validation methods for pieces like form_tag, etc. The larger question is you mentioned a create or a submit to add a record, which tells me that you are adding it into a database. If that is the case then your validations should be performed in the model, not with javascript. -- Posted via http://www.ruby-forum.com/.
I am using form for here is my code
new.html.erb
<h1>New animal</h1>
<% form_for(@animal) do |f| %>
<%= f.error_messages %>
<p>
<%= f.label :name %><br />
<%= f.text_field :name %>
</p>
<p>
<%= f.label :desc %><br />
<%= f.text_field :desc %>
</p>
<p>
<%= f.submit ''Create'', :onClick =>
''new_animal();'' %>
</p>
<% end %>
<%= link_to ''Back'', animals_path %>
main.js
function new_animal(){
alert(''animal'');
if(document.getElementById(''animal_name'').value=="")
{
alert("Enter name...");
document.getElementById(''animal_name'').focus();
return false;
}
if(document.getElementById(''animal_desc'').value=="")
{
alert("Enter animal description ...");
document.getElementById(''animal_desc'').focus();
return false;
}
}
i got message that animal then i preesed ok form redirt to index page
and insert record in db.
--
Posted via http://www.ruby-forum.com/.
Why are you doing this in javascript when you can do this beautifully in your controller? Create the appropriate validations in your model and then in your controller check whether saving is possible. If it is, save it and redirect or whatever you want it to do. If not, catch the error and show it. On 22 aug, 09:17, Wap Addon <rails-mailing-l...-ARtvInVfO7ksV2N9l4h3zg@public.gmane.org> wrote:> I am using form for here is my code > new.html.erb > > <h1>New animal</h1> > > <% form_for(@animal) do |f| %> > <%= f.error_messages %> > > <p> > <%= f.label :name %><br /> > <%= f.text_field :name %> > </p> > <p> > <%= f.label :desc %><br /> > <%= f.text_field :desc %> > </p> > <p> > <%= f.submit ''Create'', :onClick => ''new_animal();'' %> > </p> > > <% end %> > <%= link_to ''Back'', animals_path %> > > main.js > > function new_animal(){ > alert(''animal''); > if(document.getElementById(''animal_name'').value=="") > { > alert("Enter name..."); > document.getElementById(''animal_name'').focus(); > return false; > } > if(document.getElementById(''animal_desc'').value=="") > { > alert("Enter animal description ..."); > document.getElementById(''animal_desc'').focus(); > return false; > } > > } > > i got message that animal then i preesed ok form redirt to index page > and insert record in db. > -- > Posted viahttp://www.ruby-forum.com/.
jhaagmans wrote:> Why are you doing this in javascript when you can do this beautifully > in your controller? Create the appropriate validations in your model > and then in your controller check whether saving is possible. If it > is, save it and redirect or whatever you want it to do. If not, catch > the error and show it.ok dear but this is server side validation. i want to use client side validate. server side take more time execution so that client side validation more fast. so that i want to use external js validation. -- Posted via http://www.ruby-forum.com/.
On Aug 22, 10:43 am, Wap Addon <rails-mailing-l...-ARtvInVfO7ksV2N9l4h3zg@public.gmane.org> wrote:> jhaagmans wrote: > > Why are you doing this in javascript when you can do this beautifully > > in your controller? Create the appropriate validations in your model > > and then in your controller check whether saving is possible. If it > > is, save it and redirect or whatever you want it to do. If not, catch > > the error and show it. > > ok dear but this is server side validation. i want to use client side > validate. > > server side take more time execution so that client side validation more > fast. so that i want to use external js validation.I hope you are also doing server side validation. This is better done from the form''s onsubmit, and don''t forget to return the value of your validation function (don''t just call it as you are doing now) Fred> -- > Posted viahttp://www.ruby-forum.com/.
jhaagmans wrote:> Why are you doing this in javascript when you can do this beautifully > in your controller? Create the appropriate validations in your model > and then in your controller check whether saving is possible. If it > is, save it and redirect or whatever you want it to do. If not, catch > the error and show it.ok but as per my above validation code is not possible ? -- Posted via http://www.ruby-forum.com/.
Don''t think like this - as other posters have pointed out, you''re going to have to do server-side validation anyways. Worrying about the execution time of something this small is exceptionally premature optimization. In your example, the JS validation may work, but you''re still going to have to validate server-side, as some users may have JS turned off. --Matt Jones On Aug 22, 5:43 am, Wap Addon <rails-mailing-l...-ARtvInVfO7ksV2N9l4h3zg@public.gmane.org> wrote:> server side take more time execution so that client side validation more > fast. so that i want to use external js validation.