there is a bug, it actually should be -
identifier = "http://#{identifier}" unless identifier =~ /^https?:/i
On Feb 26, 3:09 pm, Vikrant
<nas...-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
wrote:> Hi,
> There is a little bug in open_id_authentication plug-in at line 87 of
> file lib/open_id_authentication.rb
>
> identifier = "http://#{identifier}" unless identifier =~
/^http/i
>
> this line will silently ignore the uri "httpd.apache.org" without
> normalising it to "http://httpd.apache.org/"
>
> at present, writing OpenIdAuthentication.normalize_identifier
> (''httpd.apache.org'') raises a NoMethodError.
>
> Proposed solution is to replace /^http/i with /^http:/i
>
> identifier = "http://#{identifier}" unless identifier =~
/^http:/i
>
> http://github.com/rails/open_id_authentication/blob/e6df78367b2578860...
>
> I''m reporting this bug here, because don''t know how to
submit patch
> (or whatever we call it) for Git repository. Also guys at
> lighthouseapp.com will let you sign-in with an OpenID but won''t
let
> you sign-up with one! So bad.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Talk" group.
To post to this group, send email to
rubyonrails-talk-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-talk+unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-talk?hl=en
-~----------~----~----~----~------~----~------~--~---