thr3ads.net - Rails - about nested resources [Feb 2009]

If this information is useful, please help other people find it:
Share via:

Difei Zhao

2009-Feb-21 05:53 UTC

about nested resources

Hi all,

  I have several resources:

  map.resources :articles, :has_many => [:comments]
  map.resources :movies, :has_many => [:comments]
  map.resources :photos, :has_many => [:comments]

  all of them have a nested resource named comments, new comments are
able to be created by POST to URLs like article_comments_url. My problem
is, when I''m in the comments_controller, how can I know which resource
this comment belongs to? By reading the params? I think this is not
decent, are there any better ways? Thanks in advance!

Cheers,
Difei
-- 
Posted via http://www.ruby-forum.com/.

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Talk" group.
To post to this group, send email to
rubyonrails-talk-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-talk+unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-talk?hl=en
-~----------~----~----~----~------~----~------~--~---

Gavin

2009-Feb-21 13:29 UTC

head link

Re: about nested resources

Difei,

If a comment only belongs to either an article, movie or a photo
(never more than one) you could add methods in the model to determine
which it is for.

For example:

class Comment

  def article_comment?
    !article_id.nil?
  end
end

@comment.article_comment? will return true if this is a comment for an
article and false if not.

You could render your view accordingly for each type of comment.

Hope that helps?

On Feb 21, 5:53 am, Difei Zhao
<rails-mailing-l...-ARtvInVfO7ksV2N9l4h3zg@public.gmane.org>
wrote:> Hi all,
>
>   I have several resources:
>
>   map.resources :articles, :has_many => [:comments]
>   map.resources :movies, :has_many => [:comments]
>   map.resources :photos, :has_many => [:comments]
>
>   all of them have a nested resource named comments, new comments are
> able to be created by POST to URLs like article_comments_url. My problem
> is, when I''m in the comments_controller, how can I know which
resource
> this comment belongs to? By reading the params? I think this is not
> decent, are there any better ways? Thanks in advance!
>
> Cheers,
> Difei
> --
> Posted viahttp://www.ruby-forum.com/.--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Talk" group.
To post to this group, send email to
rubyonrails-talk-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-talk+unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-talk?hl=en
-~----------~----~----~----~------~----~------~--~---

Difei Zhao

2009-Feb-22 15:27 UTC

head link

Re: about nested resources

Gavin wrote:> Difei,
> 
> If a comment only belongs to either an article, movie or a photo
> (never more than one) you could add methods in the model to determine
> which it is for.
> 
> For example:
> 
> class Comment
> 
>   def article_comment?
>     !article_id.nil?
>   end
> end
> 
> @comment.article_comment? will return true if this is a comment for an
> article and false if not.
> 
> You could render your view accordingly for each type of comment.
> 
> Hope that helps?
Hi Garvin, but your way is to decide the father of an existed comment.
if I just received POST to /articles/:article_id/comments/:comment_id, 
and I have a:
@comment = Comment.new(params[:comment]), how could I tell this @comment 
is for article but not photo? By test params?

Thanks.


> 
> On Feb 21, 5:53�am, Difei Zhao
<rails-mailing-l...-ARtvInVfO7ksV2N9l4h3zg@public.gmane.org>
-- 
Posted via http://www.ruby-forum.com/.

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Talk" group.
To post to this group, send email to
rubyonrails-talk-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-talk+unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-talk?hl=en
-~----------~----~----~----~------~----~------~--~---

Gavin

2009-Feb-22 17:11 UTC

head link

Re: about nested resources

Ah - I think I understand now.

I would add a column to the comments table called ''kind'' (as
in, ''kind
of comment'')

The column should be an integer column with limit 1.

Then assign a different integer value to determine what kind of
comment it is.

i.e.,
1 = article
2 = photo
3 = movie

When you creating a new comment, simply check the value of this
integer and redirect accordingly.

Does that help?

On Feb 22, 3:27 pm, Difei Zhao
<rails-mailing-l...-ARtvInVfO7ksV2N9l4h3zg@public.gmane.org>
wrote:> Gavin wrote:
> > Difei,
>
> > If a comment only belongs to either an article, movie or a photo
> > (never more than one) you could add methods in the model to determine
> > which it is for.
>
> > For example:
>
> > class Comment
>
> >   def article_comment?
> >     !article_id.nil?
> >   end
> > end
>
> > @comment.article_comment? will return true if this is a comment for an
> > article and false if not.
>
> > You could render your view accordingly for each type of comment.
>
> > Hope that helps?
>
> Hi Garvin, but your way is to decide the father of an existed comment.
> if I just received POST to /articles/:article_id/comments/:comment_id,
> and I have a:
> @comment = Comment.new(params[:comment]), how could I tell this @comment
> is for article but not photo? By test params?
>
> Thanks.
>
>
>
> > On Feb 21, 5:53 am, Difei Zhao
<rails-mailing-l...-ARtvInVfO7ksV2N9l4h3zg@public.gmane.org>
>
> --
> Posted viahttp://www.ruby-forum.com/.--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Talk" group.
To post to this group, send email to
rubyonrails-talk-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-talk+unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-talk?hl=en
-~----------~----~----~----~------~----~------~--~---

2009-Feb-22 20:30 UTC

head link

Re: about nested resources

That seems like a fine solution.

what about just creating three different types of comments,
article_comment, movie_comment, photo_comment?

I''m not necessarily advocating for this, but it''s an option,
and it
may be better.  That way, you don''t need the functions at all. and it
should help keep your controllers & views simple.

There is in some sense a problem of code duplication between the three
comment resources, but you may be able to DRY this up with helper
methods.

-Gabe

On Feb 22, 11:11 am, Gavin
<ga...-YMj/zd8x6QpKMzDMP321V2ksYUyLi9NM@public.gmane.org>
wrote:> Ah - I think I understand now.
>
> I would add a column to the comments table called ''kind''
(as in, ''kind
> of comment'')
>
> The column should be an integer column with limit 1.
>
> Then assign a different integer value to determine what kind of
> comment it is.
>
> i.e.,
> 1 = article
> 2 = photo
> 3 = movie
>
> When you creating a new comment, simply check the value of this
> integer and redirect accordingly.
>
> Does that help?
>
> On Feb 22, 3:27 pm, Difei Zhao
<rails-mailing-l...-ARtvInVfO7ksV2N9l4h3zg@public.gmane.org>
> wrote:
>
> > Gavin wrote:
> > > Difei,
>
> > > If a comment only belongs to either an article, movie or a photo
> > > (never more than one) you could add methods in the model to
determine
> > > which it is for.
>
> > > For example:
>
> > > class Comment
>
> > >   def article_comment?
> > >     !article_id.nil?
> > >   end
> > > end
>
> > > @comment.article_comment? will return true if this is a comment
for an
> > > article and false if not.
>
> > > You could render your view accordingly for each type of comment.
>
> > > Hope that helps?
>
> > Hi Garvin, but your way is to decide the father of an existed comment.
> > if I just received POST to /articles/:article_id/comments/:comment_id,
> > and I have a:
> > @comment = Comment.new(params[:comment]), how could I tell this
@comment
> > is for article but not photo? By test params?
>
> > Thanks.
>
> > > On Feb 21, 5:53 am, Difei Zhao
<rails-mailing-l...-ARtvInVfO7ksV2N9l4h3zg@public.gmane.org>
>
> > --
> > Posted viahttp://www.ruby-forum.com/.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Talk" group.
To post to this group, send email to
rubyonrails-talk-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-talk+unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-talk?hl=en
-~----------~----~----~----~------~----~------~--~---

Gavin

2009-Feb-22 22:31 UTC

head link

Re: about nested resources

Hypothetically, if one were to create three different types of comment
would you just create a Comment model and then three other models that
were subclasses?


I''ve never played with subclasses in a rails app (other than the ones
specified by rails) so I''m curious as to which whether this would be
the way to do it?

Gav

On Feb 22, 8:30 pm, GS
<gabe.sara...-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
wrote:> That seems like a fine solution.
>
> what about just creating three different types of comments,
> article_comment, movie_comment, photo_comment?
>
> I''m not necessarily advocating for this, but it''s an
option, and it
> may be better.  That way, you don''t need the functions at all. and
it
> should help keep your controllers & views simple.
>
> There is in some sense a problem of code duplication between the three
> comment resources, but you may be able to DRY this up with helper
> methods.
>
> -Gabe
>
> On Feb 22, 11:11 am, Gavin
<ga...-YMj/zd8x6QpKMzDMP321V2ksYUyLi9NM@public.gmane.org> wrote:
>
> > Ah - I think I understand now.
>
> > I would add a column to the comments table called
''kind'' (as in, ''kind
> > of comment'')
>
> > The column should be an integer column with limit 1.
>
> > Then assign a different integer value to determine what kind of
> > comment it is.
>
> > i.e.,
> > 1 = article
> > 2 = photo
> > 3 = movie
>
> > When you creating a new comment, simply check the value of this
> > integer and redirect accordingly.
>
> > Does that help?
>
> > On Feb 22, 3:27 pm, Difei Zhao
<rails-mailing-l...-ARtvInVfO7ksV2N9l4h3zg@public.gmane.org>
> > wrote:
>
> > > Gavin wrote:
> > > > Difei,
>
> > > > If a comment only belongs to either an article, movie or a
photo
> > > > (never more than one) you could add methods in the model to
determine
> > > > which it is for.
>
> > > > For example:
>
> > > > class Comment
>
> > > >   def article_comment?
> > > >     !article_id.nil?
> > > >   end
> > > > end
>
> > > > @comment.article_comment? will return true if this is a
comment for an
> > > > article and false if not.
>
> > > > You could render your view accordingly for each type of
comment.
>
> > > > Hope that helps?
>
> > > Hi Garvin, but your way is to decide the father of an existed
comment.
> > > if I just received POST to
/articles/:article_id/comments/:comment_id,
> > > and I have a:
> > > @comment = Comment.new(params[:comment]), how could I tell this
@comment
> > > is for article but not photo? By test params?
>
> > > Thanks.
>
> > > > On Feb 21, 5:53 am, Difei Zhao
<rails-mailing-l...-ARtvInVfO7ksV2N9l4h3zg@public.gmane.org>
>
> > > --
> > > Posted viahttp://www.ruby-forum.com/.--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Talk" group.
To post to this group, send email to
rubyonrails-talk-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-talk+unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-talk?hl=en
-~----------~----~----~----~------~----~------~--~---

Difei Zhao

2009-Feb-23 04:35 UTC

head link

Re: about nested resources

Hi all,

  Since my commentable resources are not too many, I decided to do 
something like this in the comment controller:

before_filter: find_resource

private
def find_resource
  if params[:article_id]
    @resource = Article.find(params[:article_id])
  elsif params[:photo_id]
    @resource = Photo.find(params[:article_id])
  end
end

Thank y''all,
Difei
-- 
Posted via http://www.ruby-forum.com/.

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Talk" group.
To post to this group, send email to
rubyonrails-talk-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-talk+unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-talk?hl=en
-~----------~----~----~----~------~----~------~--~---

Rails - Feb 2009 - about nested resources

about nested resources

Re: about nested resources

Re: about nested resources

Re: about nested resources

Re: about nested resources

Re: about nested resources

Re: about nested resources