thr3ads.net - Rails - Default find condition in ActiveRecord [Jul 2007]

If this information is useful, please help other people find it:
Share via:

Erik Allik

2007-Jul-28 15:45 UTC

Default find condition in ActiveRecord

I''m having the following situation:

Users can upload photos (and possibly videos, music etc. in future)
each of which must be approved by an administrator before it becomes
public. The photos are being displayed in a multitude of views
(search, best photos, user profile, random photo, recently added
photos etc.) of which each (except the photo owner''s private view and
some administrative views) must only display photos that have been
approved by an administrator. That means in every of those actions, I
have to specify :conditions => ''approved is true'' which is
not DRY at
all, which is error prone etc.

Does anyone know of a good solution to this?

Erik

P.S. I''ve also thought of a solution in which unapproved/rejected
photos reside in a different table, which would also be a little
better performing for most select queries but adds complexity to the
domain model.

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Talk" group.
To post to this group, send email to
rubyonrails-talk-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-talk-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-talk?hl=en
-~----------~----~----~----~------~----~------~--~---

Todd

2007-Jul-28 16:14 UTC

head link

Re: Default find condition in ActiveRecord

On Jul 28, 10:45 am, "Erik Allik"
<eal...-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
wrote:> I''m having the following situation:
>
> Users can upload photos (and possibly videos, music etc. in future)
> each of which must be approved by an administrator before it becomes
> public. The photos are being displayed in a multitude of views
> (search, best photos, user profile, random photo, recently added
> photos etc.) of which each (except the photo owner''s private view
and
> some administrative views) must only display photos that have been
> approved by an administrator. That means in every of those actions, I
> have to specify :conditions => ''approved is true''
which is not DRY at
> all, which is error prone etc.
>
> Does anyone know of a good solution to this?
>
> Erik
>
> P.S. I''ve also thought of a solution in which unapproved/rejected
> photos reside in a different table, which would also be a little
> better performing for most select queries but adds complexity to the
> domain model.
You could create a database view (instead of a table) with the CREATE
VIEW statement.

Todd


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Talk" group.
To post to this group, send email to
rubyonrails-talk-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-talk-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-talk?hl=en
-~----------~----~----~----~------~----~------~--~---

Ryan Carmelo Briones

2007-Jul-28 18:08 UTC

head link

Re: Default find condition in ActiveRecord

eallik-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:> 
> 
> I''m having the following situation:
> 
> [...] must only display photos that have been
> approved by an administrator. That means in every of those actions, I
> have to specify :conditions => ''approved is true''
which is not DRY at
> all, which is error prone etc.
> 
> Does anyone know of a good solution to this?
> 
> 
My first thought is to add a method to the model:

def find_approved_photos
  return find(:all, :conditions => ''approved is true'')
end

and then you can reuse Model.find_approved_photos in your controllers. Then
I remembered that rails allows you to use find_all_by_#{column_name}, which
I think might be better, and works just like find. So then:

Model.find_all_by_approved(true)

would give you all approved photos. Change to false for unapproved. Also,
you can still pass find options like:

Model.find_all_by_approved(true, :order => ''user_id'',
:limit => 10)

and so on. Also, if you want, you can omit the all in find_all_by_approved
(ie. find_by_approved(true)) and I think it works like find(:first). Cheers!

---
Ryan Carmelo Briones


-- 
View this message in context:
http://www.nabble.com/Default-find-condition-in-ActiveRecord-tf4162611.html#a11845182
Sent from the RubyOnRails Users mailing list archive at Nabble.com.


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Talk" group.
To post to this group, send email to
rubyonrails-talk-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-talk-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-talk?hl=en
-~----------~----~----~----~------~----~------~--~---

eallik-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org

2007-Jul-29 19:56 UTC

head link

Re: Default find condition in ActiveRecord

I realized that this is, in fact, a problem of modeling the domain:
unapproved photos aren''t photos at all in the domain sense, there is
instead
an entity called PotentialPhoto or similar. I realized this when I
noticed that,
when using a boolean "approved" field in the table,
PhotosController''s
index isn''t showing the same list of photos than what is in the
database anymore
which adds unecessary complexity.

Erik

On Jul 28, 7:14 pm, Todd
<caduce...-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
wrote:> On Jul 28, 10:45 am, "Erik Allik"
<eal...-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>
>
>
> > I''m having the following situation:
>
> > Users can upload photos (and possibly videos, music etc. in future)
> > each of which must be approved by an administrator before it becomes
> > public. The photos are being displayed in a multitude of views
> > (search, best photos, user profile, random photo, recently added
> > photos etc.) of which each (except the photo owner''s private
view and
> > some administrative views) must only display photos that have been
> > approved by an administrator. That means in every of those actions, I
> > have to specify :conditions => ''approved is true''
which is not DRY at
> > all, which is error prone etc.
>
> > Does anyone know of a good solution to this?
>
> > Erik
>
> > P.S. I''ve also thought of a solution in which
unapproved/rejected
> > photos reside in a different table, which would also be a little
> > better performing for most select queries but adds complexity to the
> > domain model.
>
> You could create a database view (instead of a table) with the CREATE
> VIEW statement.
>
> Todd

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Talk" group.
To post to this group, send email to
rubyonrails-talk-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-talk-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-talk?hl=en
-~----------~----~----~----~------~----~------~--~---

linoj

2007-Jul-30 03:15 UTC

head link

Re: Default find condition in ActiveRecord

In addition you can scope the custom find so other parameters can be
passed too (like other criteria, sort etc)

def self.find_approved(options = {})
  with_scope :find => options do
    find_all_by_approved(true, :order => ''created_at DESC'')
  end
end

see http://media.railscasts.com/videos/005_using_with_scope.mov

-- linoj

On Jul 28, 2:08 pm, Ryan Carmelo Briones
<ryan.brio...-o0x8A767qahArYgn3q21Iw@public.gmane.org>
wrote:> eal...-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
>
> > I''m having the following situation:
>
> > [...] must only display photos that have been
> > approved by an administrator. That means in every of those actions, I
> > have to specify :conditions => ''approved is true''
which is not DRY at
> > all, which is error prone etc.
>
> > Does anyone know of a good solution to this?
>
> My first thought is to add a method to the model:
>
> def find_approved_photos
>   return find(:all, :conditions => ''approved is true'')
> end
>
> and then you can reuse Model.find_approved_photos in your controllers. Then
> I remembered that rails allows you to use find_all_by_#{column_name}, which
> I think might be better, and works just like find. So then:
>
> Model.find_all_by_approved(true)
>
> would give you all approved photos. Change to false for unapproved. Also,
> you can still pass find options like:
>
> Model.find_all_by_approved(true, :order => ''user_id'',
:limit => 10)
>
> and so on. Also, if you want, you can omit the all in find_all_by_approved
> (ie. find_by_approved(true)) and I think it works like find(:first).
Cheers!
>
> ---
> Ryan Carmelo Briones
>
> --
> View this message in
context:http://www.nabble.com/Default-find-condition-in-ActiveRecord-tf416261...
> Sent from the RubyOnRails Users mailing list archive at Nabble.com.

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Talk" group.
To post to this group, send email to
rubyonrails-talk-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-talk-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-talk?hl=en
-~----------~----~----~----~------~----~------~--~---

Trevor Harmon

2007-Aug-01 04:56 UTC

head link

Re: Default find condition in ActiveRecord

Erik Allik wrote:> Users can upload photos (and possibly videos, music etc. in future)
> each of which must be approved by an administrator before it becomes
> public. The photos are being displayed in a multitude of views
> (search, best photos, user profile, random photo, recently added
> photos etc.) of which each (except the photo owner''s private view
and
> some administrative views) must only display photos that have been
> approved by an administrator. That means in every of those actions, I
> have to specify :conditions => ''approved is true''
which is not DRY at
> all, which is error prone etc.
I had the exact same problem, and the solution I came up with was to 
override the find method in the model. For example:

# Override the find method so that if pending_approval is not specified, 
it defaults to false
def self.find(*args)
  if args.last.is_a?(Hash) and not args.last[:conditions].blank?
    if not args.last[:conditions][0].match(''pending_approval'')
      args.last[:conditions][0] = "(#{args.last[:conditions][0]}) and 
pending_approval = 0"
    end
  end
  super(*args)
end
-- 
Posted via http://www.ruby-forum.com/.

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Talk" group.
To post to this group, send email to
rubyonrails-talk-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-talk-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-talk?hl=en
-~----------~----~----~----~------~----~------~--~---

Trevor Harmon

2007-Aug-01 05:21 UTC

head link

Re: Default find condition in ActiveRecord

Trevor Harmon wrote:> # Override the find method so that if pending_approval is not specified, 
> it defaults to false
> def self.find(*args)
>   if args.last.is_a?(Hash) and not args.last[:conditions].blank?
>     if not
args.last[:conditions][0].match(''pending_approval'')
>       args.last[:conditions][0] = "(#{args.last[:conditions][0]}) and 
> pending_approval = 0"
>     end
>   end
>   super(*args)
> end
Oops, never mind that code. Here''s the correct version:

def self.find(*args)
  if args.last.is_a?(Hash)
    if args.last[:conditions].blank?
      args.last[:conditions] = ''pending_approval = 0''
    elsif not
args.last[:conditions][0].match(''pending_approval'')
      args.last[:conditions][0] = "(#{args.last[:conditions][0]}) and 
pending_approval = 0"
    end
  end
  super(*args)
end

Note that the same tactic must be applied to the count method, as well.
-- 
Posted via http://www.ruby-forum.com/.

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Talk" group.
To post to this group, send email to
rubyonrails-talk-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-talk-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-talk?hl=en
-~----------~----~----~----~------~----~------~--~---

Trevor Harmon

2007-Aug-01 23:27 UTC

head link

Re: Default find condition in ActiveRecord

Trevor Harmon wrote:> def self.find(*args)
>   if args.last.is_a?(Hash)
>     if args.last[:conditions].blank?
>       args.last[:conditions] = ''pending_approval = 0''
>     elsif not
args.last[:conditions][0].match(''pending_approval'')
>       args.last[:conditions][0] = "(#{args.last[:conditions][0]}) and 
> pending_approval = 0"
>     end
>   end
>   super(*args)
> end
Hmm, still not quite right. Third time''s a charm:

def self.find(*args)
  if args.last.is_a?(Hash)
    if args.last[:conditions].blank?
      args.last[:conditions] = ''pending_approval = 0''
    else
      if args.last[:conditions].is_a?(String)
        if not
args.last[:conditions].match(''pending_approval'')
          args.last[:conditions] = "(#{args.last[:conditions]}) and 
pending_approval = 0"
        end
      elsif not
args.last[:conditions][0].match(''pending_approval'')
        args.last[:conditions][0] = "(#{args.last[:conditions][0]}) and 
pending_approval = 0"
      end
    end
  end
  super(*args)
end

Sorry for the multiple posts, but I''m guessing this code may help 
someone else one day.

-- 
Posted via http://www.ruby-forum.com/.

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Talk" group.
To post to this group, send email to
rubyonrails-talk-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-talk-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-talk?hl=en
-~----------~----~----~----~------~----~------~--~---

Jack

2007-Aug-13 09:09 UTC

head link

Re: Default find condition in ActiveRecord

Trevor, do You know with_scope method?



def self.find(*args)
  with_scope(:find => {:conditions => ''pending_approval =
0''})
{ find(*args) }
end



Regards, Jack


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Talk" group.
To post to this group, send email to
rubyonrails-talk-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-talk-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-talk?hl=en
-~----------~----~----~----~------~----~------~--~---

Adam Cohen

2007-Aug-13 17:48 UTC

head link

Re: Default find condition in ActiveRecord

You might also want to look into the scope-out-rails plugin
(http://code.google.com/p/scope-out-rails/)

Adam

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Talk" group.
To post to this group, send email to
rubyonrails-talk-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-talk-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-talk?hl=en
-~----------~----~----~----~------~----~------~--~---

Trevor Harmon

2007-Aug-16 06:57 UTC

head link

Re: Default find condition in ActiveRecord

Jack wrote:> Trevor, do You know with_scope method?
> 
> def self.find(*args)
>   with_scope(:find => {:conditions => ''pending_approval =
0''})
> { find(*args) }
> end
> 
> Regards, Jack
Thanks for the suggestion. I tried using your code, but it gives an 
error: "odd number list for Hash"

Also, I don''t think your code would work the way I need it to, anyway. 
The ''pending_approval = 0'' should be added only if the
condition being
passed to find doesn''t already specify pending_approval. Otherwise,
I''d
never be able to query for records that have ''pending_approval =
1''.

-- 
Posted via http://www.ruby-forum.com/.

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Talk" group.
To post to this group, send email to
rubyonrails-talk-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-talk-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-talk?hl=en
-~----------~----~----~----~------~----~------~--~---

Rails - Jul 2007 - Default find condition in ActiveRecord

Default find condition in ActiveRecord

Re: Default find condition in ActiveRecord

Re: Default find condition in ActiveRecord

Re: Default find condition in ActiveRecord

Re: Default find condition in ActiveRecord

Re: Default find condition in ActiveRecord

Re: Default find condition in ActiveRecord

Re: Default find condition in ActiveRecord

Re: Default find condition in ActiveRecord

Re: Default find condition in ActiveRecord

Re: Default find condition in ActiveRecord