Berger, Daniel
2006-Apr-12 16:04 UTC
[Rails] Re: Re: Oracle unit test problem in Rails 1.1.2/Ruby-OCI 0.1
> -----Original Message----- > From: rails-bounces@lists.rubyonrails.org > [mailto:rails-bounces@lists.rubyonrails.org] On Behalf Of Lori Olson > Sent: Tuesday, April 11, 2006 8:04 PM > To: rails@lists.rubyonrails.org > Subject: [Rails] Re: Re: Oracle unit test problem in Rails > 1.1.2/Ruby-OCI 0.1 > > > Wilson Bilkovich wrote: > > On 4/11/06, Lori Olson <loriolson@labradortechnologies.com> wrote: > >> > Are you using migrations to create that table, or > >> > > I understood that you were talking about the test database, > but you''re > > right, it does look broken. I just had a conversation on IRC that > > revealed that the Oracle schema dumper also doesn''t handle boolean > > (i.e. NUMBER(1)) columns properly. > > > > Sounds like it''s time for a ticket. > > Okey, dokey. I''ll see about posting an example. Thanks for > confirming.Looks to me like there''s actually two problems. First, although there''s a ''limit'' method, there''s no ''scale'' method for ActiveRecord::ConnectionAdapters::OracleColumn. Second, even if there was, it''s not being used in the schema dumper. So, it looks like we need to add ''attr_reader :scale'' to schema_definitions.rb (which is where class Column, the superclass of OracleColumn is defined) as well as add a line in schema_dumper.rb that prints the scale, if present. I think this would go around line 89. Regards, Dan