Guys I want to ask you about current realization of method capture.
There''s
a case in tests where I want to capture output in subprocess, current
realization cannot do it because it doesn''t reopen $std{out,err} and
just
reassign this value. I think that''s enough for many cases, do we need
another realization in reporting.rb? Or I can just place it in the tests.
It related to https://github.com/rails/rails/pull/7586
--
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To view this discussion on the web visit
https://groups.google.com/d/msg/rubyonrails-core/-/z5ISS9ZbXFYJ.
To post to this group, send email to rubyonrails-core@googlegroups.com.
To unsubscribe from this group, send email to
rubyonrails-core+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en.
On Mon, Sep 10, 2012 at 08:56:12AM -0700, Dmitry Vorotilin wrote:> Guys I want to ask you about current realization of method capture. There''s > a case in tests where I want to capture output in subprocess, current > realization cannot do it because it doesn''t reopen $std{out,err} and just > reassign this value. I think that''s enough for many cases, do we need > another realization in reporting.rb? Or I can just place it in the tests. > It related to https://github.com/rails/rails/pull/7586Can you check to see if minitest''s `capture_io` will solve the problem? https://github.com/seattlerb/minitest/blob/master/lib/minitest/unit.rb#L447-460 If not, can you write a small example (outside rails) to demonstrate the problem? This sounds like something we might want to push up to minitest if possible. -- Aaron Patterson http://tenderlovemaking.com/
Thanks Aaron for reply I write a gist for these cases, here you are https://gist.github.com/3694068 On Monday, September 10, 2012 8:26:23 PM UTC+4, Aaron Patterson wrote:> > On Mon, Sep 10, 2012 at 08:56:12AM -0700, Dmitry Vorotilin wrote: > > Guys I want to ask you about current realization of method capture. > There''s > > a case in tests where I want to capture output in subprocess, current > > realization cannot do it because it doesn''t reopen $std{out,err} and > just > > reassign this value. I think that''s enough for many cases, do we need > > another realization in reporting.rb? Or I can just place it in the > tests. > > It related to https://github.com/rails/rails/pull/7586 > > Can you check to see if minitest''s `capture_io` will solve the problem? > > > https://github.com/seattlerb/minitest/blob/master/lib/minitest/unit.rb#L447-460 > > If not, can you write a small example (outside rails) to demonstrate the > problem? This sounds like something we might want to push up to > minitest if possible. > > -- > Aaron Patterson > http://tenderlovemaking.com/ >-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To view this discussion on the web visit https://groups.google.com/d/msg/rubyonrails-core/-/xr7z4MFovNAJ. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
The new method, captures all descriptors, but I''m not sure about replacement original method. On Tuesday, September 11, 2012 1:38:21 AM UTC+4, Dmitry Vorotilin wrote:> > Thanks Aaron for reply I write a gist for these cases, here you are > https://gist.github.com/3694068 > > On Monday, September 10, 2012 8:26:23 PM UTC+4, Aaron Patterson wrote: >> >> On Mon, Sep 10, 2012 at 08:56:12AM -0700, Dmitry Vorotilin wrote: >> > Guys I want to ask you about current realization of method capture. >> There''s >> > a case in tests where I want to capture output in subprocess, current >> > realization cannot do it because it doesn''t reopen $std{out,err} and >> just >> > reassign this value. I think that''s enough for many cases, do we need >> > another realization in reporting.rb? Or I can just place it in the >> tests. >> > It related to https://github.com/rails/rails/pull/7586 >> >> Can you check to see if minitest''s `capture_io` will solve the problem? >> >> >> https://github.com/seattlerb/minitest/blob/master/lib/minitest/unit.rb#L447-460 >> >> If not, can you write a small example (outside rails) to demonstrate the >> problem? This sounds like something we might want to push up to >> minitest if possible. >> >> -- >> Aaron Patterson >> http://tenderlovemaking.com/ >> >-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To view this discussion on the web visit https://groups.google.com/d/msg/rubyonrails-core/-/agxrG7PMkS0J. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
Dmitry, I commented in your gist to use the StringIO instead of Tempfile to avoid IO on disk. On Monday, September 10, 2012 6:41:38 PM UTC-3, Dmitry Vorotilin wrote:> > The new method, captures all descriptors, but I''m not sure about > replacement original method. > > On Tuesday, September 11, 2012 1:38:21 AM UTC+4, Dmitry Vorotilin wrote: >> >> Thanks Aaron for reply I write a gist for these cases, here you are >> https://gist.github.com/3694068 >> >> On Monday, September 10, 2012 8:26:23 PM UTC+4, Aaron Patterson wrote: >>> >>> On Mon, Sep 10, 2012 at 08:56:12AM -0700, Dmitry Vorotilin wrote: >>> > Guys I want to ask you about current realization of method capture. >>> There''s >>> > a case in tests where I want to capture output in subprocess, current >>> > realization cannot do it because it doesn''t reopen $std{out,err} and >>> just >>> > reassign this value. I think that''s enough for many cases, do we need >>> > another realization in reporting.rb? Or I can just place it in the >>> tests. >>> > It related to https://github.com/rails/rails/pull/7586 >>> >>> Can you check to see if minitest''s `capture_io` will solve the problem? >>> >>> >>> https://github.com/seattlerb/minitest/blob/master/lib/minitest/unit.rb#L447-460 >>> >>> If not, can you write a small example (outside rails) to demonstrate the >>> problem? This sounds like something we might want to push up to >>> minitest if possible. >>> >>> -- >>> Aaron Patterson >>> http://tenderlovemaking.com/ >>> >>-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To view this discussion on the web visit https://groups.google.com/d/msg/rubyonrails-core/-/yrqGyx8OatYJ. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
Thank you, let''s discuss it in PR https://github.com/seattlerb/minitest/pull/161 I think it will be more comfortable for us. On Tuesday, September 11, 2012 5:24:59 PM UTC+4, Gabriel Sobrinho wrote:> > Dmitry, > > I commented in your gist to use the StringIO instead of Tempfile to avoid > IO on disk. > > On Monday, September 10, 2012 6:41:38 PM UTC-3, Dmitry Vorotilin wrote: >> >> The new method, captures all descriptors, but I''m not sure about >> replacement original method. >> >> On Tuesday, September 11, 2012 1:38:21 AM UTC+4, Dmitry Vorotilin wrote: >>> >>> Thanks Aaron for reply I write a gist for these cases, here you are >>> https://gist.github.com/3694068 >>> >>> On Monday, September 10, 2012 8:26:23 PM UTC+4, Aaron Patterson wrote: >>>> >>>> On Mon, Sep 10, 2012 at 08:56:12AM -0700, Dmitry Vorotilin wrote: >>>> > Guys I want to ask you about current realization of method capture. >>>> There''s >>>> > a case in tests where I want to capture output in subprocess, current >>>> > realization cannot do it because it doesn''t reopen $std{out,err} and >>>> just >>>> > reassign this value. I think that''s enough for many cases, do we need >>>> > another realization in reporting.rb? Or I can just place it in the >>>> tests. >>>> > It related to https://github.com/rails/rails/pull/7586 >>>> >>>> Can you check to see if minitest''s `capture_io` will solve the problem? >>>> >>>> >>>> https://github.com/seattlerb/minitest/blob/master/lib/minitest/unit.rb#L447-460 >>>> >>>> If not, can you write a small example (outside rails) to demonstrate >>>> the >>>> problem? This sounds like something we might want to push up to >>>> minitest if possible. >>>> >>>> -- >>>> Aaron Patterson >>>> http://tenderlovemaking.com/ >>>> >>>-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To view this discussion on the web visit https://groups.google.com/d/msg/rubyonrails-core/-/XOmJhqVyIo8J. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.