For some strings I get a wrong (MiscPsycho) Levenstein distance:> stringMatch("abc", "ab", normalize="NO")[1] 1> stringMatch("abc", "bc", normalize="NO")[1] 2 I think the lines d <- matrix(0, nrow = n + 1, ncol = m + 1) d[, 1] <- 1:(n + 1) d[1, ] <- 1:(m + 1) d[1, 1] <- 0 should be changed to d <- matrix(0, nrow = n + 1, ncol = m + 1) d[, 1] <- 0:n d[1, ] <- 0:m
Generally bug reports should go the the package emaintainer. On Apr 14, 2010, at 5:08 AM, Ben Meijering wrote:> For some strings I get a wrong (MiscPsycho) Levenstein distance: >I see you spelled it correctly in your subject line.>> stringMatch("abc", "ab", normalize="NO") > [1] 1 > >> stringMatch("abc", "bc", normalize="NO") > [1] 2 > > I think the lines > > d <- matrix(0, nrow = n + 1, ncol = m + 1) > d[, 1] <- 1:(n + 1) > d[1, ] <- 1:(m + 1) > d[1, 1] <- 0 > > should be changed to > > d <- matrix(0, nrow = n + 1, ncol = m + 1) > d[, 1] <- 0:n > d[1, ] <- 0:m > > ______________________________________________ > R-help at r-project.org mailing list > https://stat.ethz.ch/mailman/listinfo/r-help > PLEASE do read the posting guide http://www.R-project.org/posting-guide.html > and provide commented, minimal, self-contained, reproducible code.
Thanks for pointing this out, it is indeed a bug. I have a few things on my plate today but will try and revise and place a new version on CRAN soon. -----Original Message----- From: David Winsemius [mailto:dwinsemius at comcast.net] Sent: Wednesday, April 14, 2010 9:06 AM To: Ben Meijering Cc: r help; Doran, Harold Subject: Re: [R] MiscPsycho - incorrect levenshtein distance? Generally bug reports should go the the package emaintainer. On Apr 14, 2010, at 5:08 AM, Ben Meijering wrote:> For some strings I get a wrong (MiscPsycho) Levenstein distance: >I see you spelled it correctly in your subject line.>> stringMatch("abc", "ab", normalize="NO") > [1] 1 > >> stringMatch("abc", "bc", normalize="NO") > [1] 2 > > I think the lines > > d <- matrix(0, nrow = n + 1, ncol = m + 1) > d[, 1] <- 1:(n + 1) > d[1, ] <- 1:(m + 1) > d[1, 1] <- 0 > > should be changed to > > d <- matrix(0, nrow = n + 1, ncol = m + 1) > d[, 1] <- 0:n > d[1, ] <- 0:m > > ______________________________________________ > R-help at r-project.org mailing list > https://stat.ethz.ch/mailman/listinfo/r-help > PLEASE do read the posting guide http://www.R-project.org/posting-guide.html > and provide commented, minimal, self-contained, reproducible code.
Ben MiscPsycho 1.6 has been placed on CRAN with the bug fix. Should hit mirrors in a day or so. If for any reason you need it sooner, I can send the tar.gz file. Thanks for the bug report. -----Original Message----- From: David Winsemius [mailto:dwinsemius at comcast.net] Sent: Wednesday, April 14, 2010 9:06 AM To: Ben Meijering Cc: r help; Doran, Harold Subject: Re: [R] MiscPsycho - incorrect levenshtein distance? Generally bug reports should go the the package emaintainer. On Apr 14, 2010, at 5:08 AM, Ben Meijering wrote:> For some strings I get a wrong (MiscPsycho) Levenstein distance: >I see you spelled it correctly in your subject line.>> stringMatch("abc", "ab", normalize="NO") > [1] 1 > >> stringMatch("abc", "bc", normalize="NO") > [1] 2 > > I think the lines > > d <- matrix(0, nrow = n + 1, ncol = m + 1) > d[, 1] <- 1:(n + 1) > d[1, ] <- 1:(m + 1) > d[1, 1] <- 0 > > should be changed to > > d <- matrix(0, nrow = n + 1, ncol = m + 1) > d[, 1] <- 0:n > d[1, ] <- 0:m > > ______________________________________________ > R-help at r-project.org mailing list > https://stat.ethz.ch/mailman/listinfo/r-help > PLEASE do read the posting guide http://www.R-project.org/posting-guide.html > and provide commented, minimal, self-contained, reproducible code.