Pkg xen devel - Nov 2012 - Bug#694429: blktap-dkms: unowned files after purge (policy 6.8, 10.8): /lib/modules/$KVERS/kernel/

Package: blktap-dkms
Version: 2.0.91-1
Severity: important
User: debian-qa at lists.debian.org
Usertags: piuparts

Hi,

during a test with piuparts I noticed your package left unowned files on
the system after purge, which is a violation of policy 6.8 (or 10.8):

http://www.debian.org/doc/debian-policy/ch-maintainerscripts.html#s-removedetails

Filing this as important as having a piuparts clean archive is a release
goal since lenny.
>From the attached log (scroll to the bottom...):
  Removing blktap-dkms ...
  
  -------- Uninstall Beginning --------
  Module:  blktap
  Version: 2.0.91
  Kernel:  3.2.0-4-amd64 (x86_64)
  -------------------------------------
  
  Status: Before uninstall, this module version was ACTIVE on this kernel.
  
  blktap.ko:
   - Uninstallation
     - Deleting from: /lib/modules/3.2.0-4-amd64/kernel/../extra//
   - Original module
     - No original module was found for this module on this kernel.
     - Use the dkms install command to reinstall any previous module version.
  
  depmod....
  
  DKMS: uninstall completed.
  
  ------------------------------
  Deleting module version: 2.0.91
  completely from the DKMS tree.
  ------------------------------
  Done.
[...]
1m1.4s ERROR: FAIL: Package purging left files on system:
  /lib/modules/3.2.0-4-amd64/kernel/	 not owned


I recently patched dkms to (try to) remove the directories it created in
/lib/modules/*/ to install the kernel modules. This works fine for all
packages except blktap-dkms which uses
  DEST_MODULE_LOCATION="/kernel/../extra/"
in its dkms.conf, while all other -dkms packages use a path without a
'..' component. 
The "extra" directory gets cleaned up, but the "kernel"
directory is
not, and I don't want to enhance dkms to handle '..' in these paths.

Please change this to

  DEST_MODULE_LOCATION="/extra"

(although I would prefer DEST_MODULE_LOCATION="/updates/dkms", but
I'm
afraid dkms wouldn't handle this as a smooth transition)


cheers,

Andreas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: blktap-dkms_2.0.91-1.log.gz
Type: application/x-gzip
Size: 10031 bytes
Desc: not available
URL:
<http://lists.alioth.debian.org/pipermail/pkg-xen-devel/attachments/20121126/2177d523/attachment.bin>

On 11/26/2012 08:19 PM, Andreas Beckmann wrote:
> Package: blktap-dkms
> Version: 2.0.91-1
> Severity: important
> User: debian-qa at lists.debian.org
> Usertags: piuparts
> 
> Hi,
> [...]
> I recently patched dkms to (try to) remove the directories it created in
> /lib/modules/*/ to install the kernel modules. This works fine for all
> packages except blktap-dkms which uses
>   DEST_MODULE_LOCATION="/kernel/../extra/"
> in its dkms.conf, while all other -dkms packages use a path without a
> '..' component. 
> The "extra" directory gets cleaned up, but the "kernel"
directory is
> not, and I don't want to enhance dkms to handle '..' in these
paths.
> 
> Please change this to
> 
>   DEST_MODULE_LOCATION="/extra"
> 
> (although I would prefer DEST_MODULE_LOCATION="/updates/dkms",
but I'm
> afraid dkms wouldn't handle this as a smooth transition)
Hi Andreas,

Thanks a lot for this very cool QA work.

Do I understand well that all I need to do to fix the issue, is this?

--- dkms.conf.orig	2012-11-27 19:17:43.000000000 +0000
+++ dkms.conf	2012-11-27 19:17:59.000000000 +0000
@@ -4,4 +4,4 @@
 MAKE="make -C ${kernel_source_dir}
M=${dkms_tree}/${PACKAGE_NAME}/${PACKAGE_VERSION}/build modules"
 AUTOINSTALL="yes"
 BUILT_MODULE_NAME="blktap"
-DEST_MODULE_LOCATION="/kernel/../extra/"
+DEST_MODULE_LOCATION="/extra"

If so, that's easy enough, and I can try to get this fixed before Wheezy
is out.

Let me know,
Cheers,

Thomas

Your message dated Thu, 29 Nov 2012 19:17:27 +0000
with message-id <E1Te9bz-0000se-C4 at franck.debian.org>
and subject line Bug#694429: fixed in blktap-dkms 2.0.91-2
has caused the Debian Bug report #694429,
regarding blktap-dkms: unowned files after purge (policy 6.8, 10.8):
/lib/modules/$KVERS/kernel/
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner at bugs.debian.org
immediately.)


-- 
694429: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=694429
Debian Bug Tracking System
Contact owner at bugs.debian.org with problems
-------------- next part --------------
An embedded message was scrubbed...
From: Andreas Beckmann <debian at abeckmann.de>
Subject: blktap-dkms: unowned files after purge (policy 6.8, 10.8):
/lib/modules/$KVERS/kernel/
Date: Mon, 26 Nov 2012 13:19:59 +0100
Size: 17894
URL:
<http://lists.alioth.debian.org/pipermail/pkg-xen-devel/attachments/20121129/c530af7f/attachment-0002.mht>
-------------- next part --------------
An embedded message was scrubbed...
From: Thomas Goirand <zigo at debian.org>
Subject: Bug#694429: fixed in blktap-dkms 2.0.91-2
Date: Thu, 29 Nov 2012 19:17:27 +0000
Size: 4185
URL:
<http://lists.alioth.debian.org/pipermail/pkg-xen-devel/attachments/20121129/c530af7f/attachment-0003.mht>