Pkg xen devel - Jan 2008 - Bug#458502: xen-utils-common: Slight problem with LSB header in init.d script

Package:  xen-utils-common
Version:  3.0+hg11292-2
Tags:     patch
User:     initscripts-ng-devel at lists.alioth.debian.org
Usertags: incorrect-dependency

When testing dependency based boot sequencing, I discovered a bug in
the init.d script for xen-utils-common.  It is set to stop in the boot
"runlevel" (S), but no script should stop there.  Also, xend only
depend on $local_fs, but uses files in /usr/ which is not guaranteed
to be available until after $remote_fs.  Last, the xendomains script
have the home-made header default-enabled which create a lintian
warning and was the issue that make me have a closer look at these
scripts dependencies.

This patch solve the issues:

diff -ur xen-common-3.1.0.orig/debian/xen-utils-common.xend.init
xen-common-3.1.0/debian/xen-utils-common.xend.init
--- xen-common-3.1.0.orig/debian/xen-utils-common.xend.init     2008-01-01
10:34:58.000000000 +0100
+++ xen-common-3.1.0/debian/xen-utils-common.xend.init  2008-01-01
10:36:54.000000000 +0100
@@ -1,10 +1,10 @@
 #!/bin/sh
 ### BEGIN INIT INFO
 # Provides:          xend
-# Required-Start:    $local_fs
-# Required-Stop:     $local_fs
+# Required-Start:    $remote_fs
+# Required-Stop:     $remote_fs
 # Default-Start:     2 3 4 5
-# Default-Stop:      S 0 1 6
+# Default-Stop:      0 1 6
 # Short-Description: XEN control daemon
 # Description:       XEN control daemon
 ### END INIT INFO
Only in xen-common-3.1.0/debian: xen-utils-common.xend.init.~1~
diff -ur xen-common-3.1.0.orig/debian/xen-utils-common.xendomains.init
xen-common-3.1.0/debian/xen-utils-common.xendomains.init
--- xen-common-3.1.0.orig/debian/xen-utils-common.xendomains.init      
2008-01-01 10:34:58.000000000 +0100
+++ xen-common-3.1.0/debian/xen-utils-common.xendomains.init    2008-01-01
10:36:12.000000000 +0100
@@ -6,12 +6,12 @@
 # Required-Stop:     $syslog $remote_fs xend
 # Should-Stop:
 # Default-Start:     2 3 4 5
-# Default-Stop:      S 0 1 6
-# Default-Enabled:   yes
+# Default-Stop:      0 1 6
 # Short-Description: Start/stop secondary xen domains
 # Description:       Start / stop domains automatically when domain 0
 #                    boots / shuts down.
 ### END INIT INFO
+# Default-Enabled:   yes

 PATH=/usr/lib/xen-common/bin:/sbin:/bin:/usr/sbin:/usr/bin
 VERSION=$(xen-utils-version -q 2>/dev/null || true)


As the stop xend script do not seem to do anything except killing the
daemon, that task might be better left to the sendsigs script in
runlevel 0 and 6.  If this is indeed the case, I recommend removing 0
and 6 from the Default-Stop list to speed up the shutdown.

Happy hacking,
-- 
Petter Reinholdtsen

Your message dated Fri, 07 Mar 2008 13:32:04 +0000
with message-id <E1JXcg8-000099-D7 at ries.debian.org>
and subject line Bug#458502: fixed in xen-common 3.2.0-2
has caused the Debian Bug report #458502,
regarding xen-utils-common: Slight problem with LSB header in init.d script
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner at bugs.debian.org
immediately.)


-- 
458502: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=458502
Debian Bug Tracking System
Contact owner at bugs.debian.org with problems
-------------- next part --------------
An embedded message was scrubbed...
From: Petter Reinholdtsen <pere at hungry.com>
Subject: xen-utils-common: Slight problem with LSB header in init.d script
Date: Tue, 01 Jan 2008 10:44:52 +0100
Size: 4573
Url:
http://lists.alioth.debian.org/pipermail/pkg-xen-devel/attachments/20080307/b369eb7d/attachment.eml
-------------- next part --------------
An embedded message was scrubbed...
From: Bastian Blank <waldi at debian.org>
Subject: Bug#458502: fixed in xen-common 3.2.0-2
Date: Fri, 07 Mar 2008 13:32:04 +0000
Size: 3398
Url:
http://lists.alioth.debian.org/pipermail/pkg-xen-devel/attachments/20080307/b369eb7d/attachment-0001.eml