Hi, Attached patch adds some missing HAVE_CONFIG_H guards to some places in celt/arm. Please review. Thanks, --Michael -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.xiph.org/pipermail/opus/attachments/20170127/a56493d8/attachment.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-Add-missing-HAVE_CONFIG_H-guards.patch Type: application/octet-stream Size: 980 bytes Desc: not available URL: <http://lists.xiph.org/pipermail/opus/attachments/20170127/a56493d8/attachment.obj>
On Fri, Jan 27, 2017 at 7:39 PM, Michael Bradshaw <mjbshaw at google.com> wrote:> Attached patch adds some missing HAVE_CONFIG_H guards to some places in > celt/arm. Please review. >Hi again. Just following up to see if there are any additional changes that I should make to this patch. Without it, using Ne10 fails to build without a config.h file present. --Michael -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.xiph.org/pipermail/opus/attachments/20170215/9605ad57/attachment.html>
Hi Michael, I guess the main issue here is that config.h is never actually supposed to be included from a header file in the first place. So it might be best to fix that directly rather than adding ifdefs. Cheers, Jean-Marc On 15/02/17 01:21 PM, Michael Bradshaw wrote:> On Fri, Jan 27, 2017 at 7:39 PM, Michael Bradshaw <mjbshaw at google.com > <mailto:mjbshaw at google.com>> wrote: > > Attached patch adds some missing HAVE_CONFIG_H guards to some places > in celt/arm. Please review. > > > Hi again. Just following up to see if there are any additional changes > that I should make to this patch. Without it, using Ne10 fails to build > without a config.h file present. > > --Michael > > > _______________________________________________ > opus mailing list > opus at xiph.org > http://lists.xiph.org/mailman/listinfo/opus >