similar to: [PATCH] Add missing HAVE_CONFIG_H guards

Hi Michael, I guess the main issue here is that config.h is never actually supposed to be included from a header file in the first place. So it might be best to fix that directly rather than adding ifdefs. Cheers, Jean-Marc On 15/02/17 01:21 PM, Michael Bradshaw wrote: > On Fri, Jan 27, 2017 at 7:39 PM, Michael Bradshaw <mjbshaw at google.com > <mailto:mjbshaw at

Hi, Attached patch modifies some of the Ne10 includes in celt/arm. The original includes worked, but ended up pulling in extra Ne10 headers that were unnecessary. This allows libopus to be built with just the Ne10 DSP module installed on the user's machine. Please review. Thanks, --Michael -------------- next part -------------- An HTML attachment was scrubbed... URL:

On Fri, Jan 27, 2017 at 7:39 PM, Michael Bradshaw <mjbshaw at google.com> wrote: > Attached patch adds some missing HAVE_CONFIG_H guards to some places in > celt/arm. Please review. > Hi again. Just following up to see if there are any additional changes that I should make to this patch. Without it, using Ne10 fails to build without a config.h file present. --Michael

Hi Michael, Sorry for accidentally dropping that. Can you send me the latest version of the patch? Thanks, Jean-Marc On 15/02/17 04:30 PM, Michael Bradshaw wrote: > On Fri, Jan 27, 2017 at 7:41 PM, Michael Bradshaw <mjbshaw at google.com > <mailto:mjbshaw at google.com>> wrote: > > Attached patch modifies some of the Ne10 includes in celt/arm. The >

On Wed, Feb 15, 2017 at 10:45 AM, Jean-Marc Valin <jmvalin at jmvalin.ca> wrote: > Hi Michael, > > I guess the main issue here is that config.h is never actually supposed > to be included from a header file in the first place. So it might be > best to fix that directly rather than adding ifdefs. Thanks for the response. Attached patch removes the config.h include. I tested

Copying my report from sf.net: The source uses a mixture of "#ifdef HAVE_CONFIG_H" and "#if HAVE_CONFIG_H" checks. Judging from DEFS=-DHAVE_CONFIG_H in the configure I supposed it should be "#ifdef" in all cases. These incorrect checks cause build errors since it tries to include the config.h on a custom configuration, that doesn't provide one. I can provide a

autotools define HAVE_CONFIG_H to signal a config.h was generated; since this file is built directly also in bindings without the use of config.h, make sure config.h is not requested in those cases. This file uses only POSIX functions anyway, so it should not be a problem. --- utils/stringlists-utils.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/utils/stringlists-utils.c

Hello opus-dev, I've been cooking up this patchset to integrate NE10 library into opus. Current patchset focuses on encode use case mainly effecting performance of clt_mdct_forward() and opus_fft() (for float only) Glad to report the following on Encode use case: (Measured on my Beaglebone Black Cortex-A8 board) - Performance improvement for encode use case ~= 12.34% (Based on time -p

Hello Timothy / Jean-Marc / opus-dev, This patch series is follow up on work I posted on [1]. In addition to what was posted on [1], this patch series mainly integrates Fixed point FFT implementations in NE10 library into opus. You can view my opus wip code at [2]. Note that while I found some issues both with the NE10 library(fixed fft) and with Linaro toolchain (armv8 intrinsics), the work

> Oliver St?neberg wrote: > > > Copying my report from sf.net: > > > > The source uses a mixture of "#ifdef HAVE_CONFIG_H" and "#if HAVE_CONFIG_H" > > checks. Judging from > > > > DEFS=-DHAVE_CONFIG_H > > > > in the configure I supposed it should be "#ifdef" in all cases. These incorrect > > checks cause

Hi All, Changes from RFC v2 [1] armv7,armv8: Extend fixed fft NE10 optimizations to mdct - Overflow issue fixed by Phil at ARM. Ne10 wip at [2]. Should be upstream soon. - So, re-enabled using fixed fft for mdct_forward which was disabled in RFCv2 armv7,armv8: Optimize fixed point fft using NE10 library - Thanks to Jonathan Lennox, fixed some build fixes on iOS and some copy-paste errors Rest

Hi All, Since I continue to base my work on top of Jonathan's patch, and my previous Ne10 fft/ifft/mdct_forward/backward patches, I thought it would be better to just post all new patches as a patch series. Please let me know if anyone disagrees with this approach. You can see wip branch of all latest patches at https://git.linaro.org/people/viswanath.puttagunta/opus.git Branch:

Hi All, As per Timothy's suggestion, disabling mdct_forward for fixed point. Only effects armv7,armv8: Extend fixed fft NE10 optimizations to mdct Rest of patches are same as in [1] For reference, latest wip code for opus is at [2] Still working with NE10 team at ARM to get corner cases of mdct_forward. Will update with another patch when issue in NE10 gets fixed. Regards, Vish [1]:

Hi Timothy, As I mentioned earlier [1], I now fixed compile issues with fixed point and resubmitting the patch. I also have new patch that does intrinsics optimizations for celt_pitch_xcorr targetting aarch64. You can find my latest work-in-progress branch at [2] For reference, you can use the Ne10 pre-built libraries at [3] Note that I am working with Phil at ARM to get my patch at [4]

Actually, it looks like this is already done in Speex as of revision 7150 in SVN (7/15/2004). As long as HAVE_CONFIG_H is defined in the project settings (which it is in all of the project files in SVN), win32\config.h should be included, and this has #define inline __inline in it. Oleg - you should make sure HAVE_CONFIG_H is defined in your project settings. And, you didn't say which

Changes from RFC PATCH v1: - passing arch parameter explicitly - reduced stack usage by ~3.5K by using scaled NE10 fft version - moved all optimization array functions to arm_celt_map.c - Other cleanups pointed out by Timothy Phil, As you mentioned earlier, could you please address all compile and linker errors/warnings coming out of Ne10 library? You can find my working Ne10 repo at [1] You

On Fri, Jan 27, 2017 at 7:41 PM, Michael Bradshaw <mjbshaw at google.com> wrote: > Attached patch modifies some of the Ne10 includes in celt/arm. The > original includes worked, but ended up pulling in extra Ne10 headers that > were unnecessary. This allows libopus to be built with just the Ne10 DSP > module installed on the user's machine. Please review. > Hello again.

Changes from RFC PATCH v2 - fixed compile issue when just compiling for --enable-intrinsics for ARMv7 without NE10 - Notes for NE10: - All compile/link warnings are now in upstream NE10 - Only patch pending upstream in NE10 is the one that needs to add -funsafe-math-optimizations for ARMv7 targets. - Phil Wang @ ARM is working on getting this fixed. - Note that even without

Changes from RFC PATCH v3 - Just rebased on tip - For all else, please see notes from RFC PATCH v3 at http://lists.xiph.org/pipermail/opus/2015-March/002902.html - latest wip opus tree/branch https://git.linaro.org/people/viswanath.puttagunta/Ne10.git branch: rfcv4_final_fft_ne10 Viswanath Puttagunta (1): armv7(float): Optimize encode usecase using NE10 library Makefile.am

I'm just curious, who and why came up with that strange way to write includes: #ifdef _BUILD_SPEEX # include "speex_types.h" #else # include <speex/speex_types.h> #endif I personally consider it a bug. If I use speex then obviously I should not have _BUILD_SPEEX defined. The broken behavior happens in this simple scenario: 1) I check out latest git version to ./src/speex 2)