search for: mjbshaw

Hi, Attached patch adds some missing HAVE_CONFIG_H guards to some places in celt/arm. Please review. Thanks, --Michael -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.xiph.org/pipermail/opus/attachments/20170127/a56493d8/attachment.html> -------------- next part -------------- A non-text attachment was scrubbed... Name:

Hi, Attached patch modifies some of the Ne10 includes in celt/arm. The original includes worked, but ended up pulling in extra Ne10 headers that were unnecessary. This allows libopus to be built with just the Ne10 DSP module installed on the user's machine. Please review. Thanks, --Michael -------------- next part -------------- An HTML attachment was scrubbed... URL:

...e here is that config.h is never actually supposed to be included from a header file in the first place. So it might be best to fix that directly rather than adding ifdefs. Cheers, Jean-Marc On 15/02/17 01:21 PM, Michael Bradshaw wrote: > On Fri, Jan 27, 2017 at 7:39 PM, Michael Bradshaw <mjbshaw at google.com > <mailto:mjbshaw at google.com>> wrote: > > Attached patch adds some missing HAVE_CONFIG_H guards to some places > in celt/arm. Please review. > > > Hi again. Just following up to see if there are any additional changes > that I should make...

Hi Michael, Sorry for accidentally dropping that. Can you send me the latest version of the patch? Thanks, Jean-Marc On 15/02/17 04:30 PM, Michael Bradshaw wrote: > On Fri, Jan 27, 2017 at 7:41 PM, Michael Bradshaw <mjbshaw at google.com > <mailto:mjbshaw at google.com>> wrote: > > Attached patch modifies some of the Ne10 includes in celt/arm. The > original includes worked, but ended up pulling in extra Ne10 headers > that were unnecessary. This allows libopus to be built with jus...

On Fri, Jan 27, 2017 at 7:39 PM, Michael Bradshaw <mjbshaw at google.com> wrote: > Attached patch adds some missing HAVE_CONFIG_H guards to some places in > celt/arm. Please review. > Hi again. Just following up to see if there are any additional changes that I should make to this patch. Without it, using Ne10 fails to build without a config....

On Fri, Jan 27, 2017 at 7:41 PM, Michael Bradshaw <mjbshaw at google.com> wrote: > Attached patch modifies some of the Ne10 includes in celt/arm. The > original includes worked, but ended up pulling in extra Ne10 headers that > were unnecessary. This allows libopus to be built with just the Ne10 DSP > module installed on the user's mach...

On Wed, Feb 15, 2017 at 10:45 AM, Jean-Marc Valin <jmvalin at jmvalin.ca> wrote: > Hi Michael, > > I guess the main issue here is that config.h is never actually supposed > to be included from a header file in the first place. So it might be > best to fix that directly rather than adding ifdefs. Thanks for the response. Attached patch removes the config.h include. I tested

On Wed, Feb 15, 2017 at 1:40 PM, Jean-Marc Valin <jmvalin at jmvalin.ca> wrote: > Hi Michael, > > Sorry for accidentally dropping that. Can you send me the latest version > of the patch? No worries, thanks for taking a look! Attached is the patch rebased from master's HEAD. --Michael -------------- next part -------------- An HTML attachment was scrubbed... URL: